cholpas commented on a change in pull request #2472:
URL: https://github.com/apache/lucene-solr/pull/2472#discussion_r648148773
##########
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##########
@@ -271,7 +274,34 @@ public IndexFetcher(@SuppressWarnings({"rawtypes"})final
NamedList initArgs, fin
String httpBasicAuthPassword = (String)
initArgs.get(HttpClientUtil.PROP_BASIC_AUTH_PASS);
myHttpClient = createHttpClient(solrCore, httpBasicAuthUser,
httpBasicAuthPassword, useExternalCompression);
}
-
+
+ private void setLeaderUrl(String leaderUrl) {
+ if (leaderUrl != null) {
+ ShardHandlerFactory shardHandlerFactory =
solrCore.getCoreContainer().getShardHandlerFactory();
+ if (shardHandlerFactory instanceof HttpShardHandlerFactory) {
+ ZkController zkController =
solrCore.getCoreContainer().getZkController();
+ ClusterState clusterState = zkController == null ? null :
zkController.getClusterState();
+ try {
+ ((HttpShardHandlerFactory)
shardHandlerFactory).getWhitelistHostChecker()
+ .checkWhitelist(clusterState, null,
Collections.singletonList(leaderUrl));
Review comment:
When using Solr with only leader/follower replication and not with
SolrCloud, this whitelist check is failing - unless
`-Dsolr.disable.shardsWhitelist=true` is passed. In my point of view it does
not make sense to have to pass this flag when SolrCloud is not being used. What
do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
