[GitHub] [lucene] zacharymorn commented on pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-11 Thread GitBox
zacharymorn commented on pull request #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-839419774 Thanks Adrien for the suggestion! Let me give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [lucene] neoremind commented on pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on pull request #91: URL: https://github.com/apache/lucene/pull/91#issuecomment-839400284 Thanks for taking time working on my branch. I merged your change into this PR, the code looks much better 😄. I was wondering which test case do I neglect besides `TestIndexSorti

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630693579 ## File path: lucene/core/src/test/org/apache/lucene/util/bkd/TestMutablePointsReaderUtils.java ## @@ -180,15 +189,16 @@ private static BKDConfig createRand

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630692867 ## File path: lucene/core/src/java/org/apache/lucene/util/StableMSBRadixSorter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] gsmiller commented on a change in pull request #131: LUCENE-9953: Make FacetResult#value accurate for LongValueFacetCounts

2021-05-11 Thread GitBox
gsmiller commented on a change in pull request #131: URL: https://github.com/apache/lucene/pull/131#discussion_r630606547 ## File path: lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java ## @@ -429,15 +429,15 @@ public void testRandomMultiValued() thro

[GitHub] [lucene] gautamworah96 commented on a change in pull request #131: LUCENE-9953: Make FacetResult#value accurate for LongValueFacetCounts

2021-05-11 Thread GitBox
gautamworah96 commented on a change in pull request #131: URL: https://github.com/apache/lucene/pull/131#discussion_r630599188 ## File path: lucene/facet/src/test/org/apache/lucene/facet/TestLongValueFacetCounts.java ## @@ -429,15 +429,15 @@ public void testRandomMultiValued()

[GitHub] [lucene] rmuir commented on pull request #134: LUCENE-9935: Enable bulk merge for stored fields with index sort

2021-05-11 Thread GitBox
rmuir commented on pull request #134: URL: https://github.com/apache/lucene/pull/134#issuecomment-839175711 Change looks great, a few questions: * Can we add tests to `BaseStoredFieldsFormatTestCase` that call `setIndexSort`, exercise merging, and validate correctness (e.g. check that s

[GitHub] [lucene] rmuir commented on a change in pull request #134: LUCENE-9935: Enable bulk merge for stored fields with index sort

2021-05-11 Thread GitBox
rmuir commented on a change in pull request #134: URL: https://github.com/apache/lucene/pull/134#discussion_r630522095 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene90/compressing/Lucene90CompressingStoredFieldsWriter.java ## @@ -76,7 +75,8 @@ static fin

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342820#comment-17342820 ] David Smiley commented on LUCENE-9836: -- Thanks Uwe! > Fix 8.x Maven Validation and

[GitHub] [lucene] dnhatn commented on pull request #134: LUCENE-9935: Enable bulk merge for stored fields with index sort

2021-05-11 Thread GitBox
dnhatn commented on pull request #134: URL: https://github.com/apache/lucene/pull/134#issuecomment-839016753 @rmuir It would be great if you can take a look at this PR. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [lucene] dnhatn opened a new pull request #134: LUCENE-9935: Enable bulk merge for stored fields with index sort

2021-05-11 Thread GitBox
dnhatn opened a new pull request #134: URL: https://github.com/apache/lucene/pull/134 This commit enables bulk-merges (i.e., raw chunk copying) for stored fields when index sort is enabled. I benchmarked this change with Elasticsearch using Rally and found that this reduced the merge time

[GitHub] [lucene] jpountz commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
jpountz commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630403562 ## File path: lucene/core/src/java/org/apache/lucene/util/StableMSBRadixSorter.java ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342734#comment-17342734 ] Uwe Schindler commented on LUCENE-9836: --- Smoke tester succeeded: https://ci-build

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-05-11 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342730#comment-17342730 ] Greg Miller commented on LUCENE-9950: - Just posted a PR for a new facet counting imp

[GitHub] [lucene] gsmiller opened a new pull request #133: LUCENE-9950: New facet counting implementation for general string doc value fields

2021-05-11 Thread GitBox
gsmiller opened a new pull request #133: URL: https://github.com/apache/lucene/pull/133 # Description Adding a new implementation for facet counting that works against any string doc value field (i.e., SortedSetDocValues, SortedDocValues). This implementation doesn't require "dimens

[GitHub] [lucene] jpountz commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
jpountz commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630299581 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MutablePointValues.java ## @@ -41,4 +41,10 @@ protected MutablePointValues() {} /** Swap the i

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342663#comment-17342663 ] Uwe Schindler commented on LUCENE-9836: --- Background information: {quote} i figure

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342659#comment-17342659 ] Uwe Schindler commented on LUCENE-9836: --- I was not able to test this (Smoketester

[jira] [Resolved] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler resolved LUCENE-9836. --- Resolution: Fixed > Fix 8.x Maven Validation and publication to work with Maven Central and

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342649#comment-17342649 ] ASF subversion and git services commented on LUCENE-9836: - Commi

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630267185 ## File path: lucene/core/src/java/org/apache/lucene/codecs/MutablePointValues.java ## @@ -41,4 +41,10 @@ protected MutablePointValues() {} /** Swap the

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630266715 ## File path: lucene/core/src/java/org/apache/lucene/util/StableMSBRadixSorter.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-11 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r630265647 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java ## @@ -35,63 +37,60 @@ MutablePointsReaderUtils() {} - /

[GitHub] [lucene] mikemccand commented on a change in pull request #132: Parallel processing

2021-05-11 Thread GitBox
mikemccand commented on a change in pull request #132: URL: https://github.com/apache/lucene/pull/132#discussion_r630244090 ## File path: lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/ReutersContentSource.java ## @@ -102,19 +103,33 @@ public void close() t

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342569#comment-17342569 ] Uwe Schindler commented on LUCENE-9836: --- I figured out: The aggregator POM can com

[jira] [Reopened] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler reopened LUCENE-9836: --- Reopen to fix the Maven deployment issues. > Fix 8.x Maven Validation and publication to work w

[jira] [Comment Edited] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342546#comment-17342546 ] Uwe Schindler edited comment on LUCENE-9836 at 5/11/21, 1:24 PM: -

[jira] [Comment Edited] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342546#comment-17342546 ] Uwe Schindler edited comment on LUCENE-9836 at 5/11/21, 1:24 PM: -

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342560#comment-17342560 ] Uwe Schindler commented on LUCENE-9836: --- Hi, i figured this out. Due to my change

[jira] [Comment Edited] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342546#comment-17342546 ] Uwe Schindler edited comment on LUCENE-9836 at 5/11/21, 1:07 PM: -

[jira] [Commented] (LUCENE-9836) Fix 8.x Maven Validation and publication to work with Maven Central and HTTPS again; remove pure Maven build (did not work anymore)

2021-05-11 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17342546#comment-17342546 ] Uwe Schindler commented on LUCENE-9836: --- Hi, bq. I'm a bit confused what's going

[GitHub] [lucene] balmukundblr commented on pull request #132: Parallel processing

2021-05-11 Thread GitBox
balmukundblr commented on pull request #132: URL: https://github.com/apache/lucene/pull/132#issuecomment-838437933 @mikemccand We have raised a new PR as you suggested in new lucene github repo. Thanks & Regards, Balmukund -- This is an automated message from the Apache Git

[GitHub] [lucene] balmukundblr opened a new pull request #132: Parallel processing

2021-05-11 Thread GitBox
balmukundblr opened a new pull request #132: URL: https://github.com/apache/lucene/pull/132 # Description Description Please note- This is not a new PR- Original PR (apache/lucene-solr#2345) was raised on old apache/lucene-solr github repository. This is just a cop