[GitHub] [lucene] zacharymorn commented on pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-06 Thread GitBox
zacharymorn commented on pull request #101: URL: https://github.com/apache/lucene/pull/101#issuecomment-834114823 > I played with your branch in order to try to speed things up a bit and I'm getting a bit closer to our current WAND implementation: https://github.com/jpountz/lucene/tree/LUC

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960571 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -605,6 +610,15 @@ public Status checkIndex(List onlySegments) throws IO

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws IOE

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627960267 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws IOE

[GitHub] [lucene] zacharymorn commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
zacharymorn commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627959173 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -731,40 +747,188 @@ public Status checkIndex(List onlySegments) throws

[GitHub] [lucene] neoremind commented on a change in pull request #91: LUCENE-9932: Performance improvement for BKD index building

2021-05-06 Thread GitBox
neoremind commented on a change in pull request #91: URL: https://github.com/apache/lucene/pull/91#discussion_r627930760 ## File path: lucene/core/src/java/org/apache/lucene/util/bkd/MutablePointsReaderUtils.java ## @@ -35,63 +37,60 @@ MutablePointsReaderUtils() {} - /

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834040647 It occurred to me that we don't need to be so strict with setting up the seg-tree counter to only be single- or multi-valued. In fact, it's a bit more optimal to use the single-va

[GitHub] [lucene] gsmiller commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
gsmiller commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-834034324 @rmuir interesting thought. There might be something to optimize here with the knowledge that each value (within the context of a doc) is sorted, but I don't think it will fully r

[GitHub] [lucene] rmuir commented on pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
rmuir commented on pull request #127: URL: https://github.com/apache/lucene/pull/127#issuecomment-833971467 @gsmiller do you think we are taking advantage of the sortedness of `SORTED_NUMERIC` here? e.g. do we really need a bitset or could we record hits high-level like this: ```

[jira] [Commented] (LUCENE-9456) Stored fields should store the number of chunks in the meta file

2021-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340477#comment-17340477 ] ASF subversion and git services commented on LUCENE-9456: - Commi

[GitHub] [lucene] mocobeta merged pull request #129: LUCENE-9456: revise format description of TermVectorsFormat

2021-05-06 Thread GitBox
mocobeta merged pull request #129: URL: https://github.com/apache/lucene/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [lucene-solr] daniel6691 commented on pull request #2489: SOLR-6152 Pre-populating values into search parameters on the query page of solr admin

2021-05-06 Thread GitBox
daniel6691 commented on pull request #2489: URL: https://github.com/apache/lucene-solr/pull/2489#issuecomment-833909922 Thank you for your fast response: I created a second PR vor the main branch, as that was my understanding: https://github.com/apache/lucene-solr/pull/2490 Please le

[GitHub] [lucene-solr] daniel6691 opened a new pull request #2490: SOLR-6152 Pre-populating values into search parameters on the query page of solr admin

2021-05-06 Thread GitBox
daniel6691 opened a new pull request #2490: URL: https://github.com/apache/lucene-solr/pull/2490 commit to main from 8.9.0: https://github.com/apache/lucene-solr/pull/2489 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Resolved] (LUCENE-9843) Remove compression option on doc values

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-9843. - Fix Version/s: main (9.0) Resolution: Fixed Thanks [~jdconradson]! > Remove compression

[jira] [Commented] (LUCENE-9843) Remove compression option on doc values

2021-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340435#comment-17340435 ] ASF subversion and git services commented on LUCENE-9843: - Commi

[jira] [Commented] (LUCENE-9945) Extend DrillSideways to support exposing FacetCollectors directly

2021-05-06 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340434#comment-17340434 ] Greg Miller commented on LUCENE-9945: - Thanks [~sejalpawar]! I'm not working on this

[jira] [Commented] (LUCENE-9945) Extend DrillSideways to support exposing FacetCollectors directly

2021-05-06 Thread Sejal Pawar (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340416#comment-17340416 ] Sejal Pawar commented on LUCENE-9945: - I am interested in picking this up as a first

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r627662566 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/DoubleRangeFacetCounts.java ## @@ -79,76 +94,150 @@ public DoubleRangeFacetCounts(

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340359#comment-17340359 ] ASF subversion and git services commented on LUCENE-9905: - Commi

[jira] [Commented] (LUCENE-9905) Revise approach to specifying NN algorithm

2021-05-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340358#comment-17340358 ] ASF subversion and git services commented on LUCENE-9905: - Commi

[GitHub] [lucene] msokolov merged pull request #114: LUCENE-9905: PerFieldVectorFormat

2021-05-06 Thread GitBox
msokolov merged pull request #114: URL: https://github.com/apache/lucene/pull/114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [lucene] jpountz commented on a change in pull request #101: LUCENE-9335: [Discussion Only] Add BMM scorer and use it for pure disjunction term query

2021-05-06 Thread GitBox
jpountz commented on a change in pull request #101: URL: https://github.com/apache/lucene/pull/101#discussion_r627389726 ## File path: lucene/core/src/java/org/apache/lucene/search/BlockMaxMaxscoreScorer.java ## @@ -0,0 +1,339 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r627620585 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/DoubleRangeFacetCounts.java ## @@ -79,76 +94,150 @@ public DoubleRangeFacetCounts(

[GitHub] [lucene] rmuir commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
rmuir commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627567282 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -605,6 +610,15 @@ public Status checkIndex(List onlySegments) throws IOExcept

[GitHub] [lucene] mocobeta commented on pull request #129: LUCENE-9456: revise format description of TermVectorsFormat

2021-05-06 Thread GitBox
mocobeta commented on pull request #129: URL: https://github.com/apache/lucene/pull/129#issuecomment-833608914 @jpountz Could you take a look at this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene] mocobeta opened a new pull request #129: LUCENE-9456: revise format description of TermVectorsFormat

2021-05-06 Thread GitBox
mocobeta opened a new pull request #129: URL: https://github.com/apache/lucene/pull/129 https://issues.apache.org/jira/browse/LUCENE-9456 decoupled termvector's metadata from .tvd file. This is a follow-up to reflect the changes to the format description. latest javadoc ![termve

[GitHub] [lucene] rmuir commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
rmuir commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r627497501 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/DoubleRangeFacetCounts.java ## @@ -79,76 +94,150 @@ public DoubleRangeFacetCounts( Do

[GitHub] [lucene] msokolov commented on a change in pull request #114: LUCENE-9905: PerFieldVectorFormat

2021-05-06 Thread GitBox
msokolov commented on a change in pull request #114: URL: https://github.com/apache/lucene/pull/114#discussion_r627497358 ## File path: lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldVectorFormat.java ## @@ -0,0 +1,293 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene] gsmiller commented on a change in pull request #127: LUCENE-9946: Support multi-value fields in range facet counting

2021-05-06 Thread GitBox
gsmiller commented on a change in pull request #127: URL: https://github.com/apache/lucene/pull/127#discussion_r627471783 ## File path: lucene/facet/src/java/org/apache/lucene/facet/range/DoubleRangeFacetCounts.java ## @@ -79,76 +94,150 @@ public DoubleRangeFacetCounts(

[GitHub] [lucene] msokolov commented on pull request #114: LUCENE-9905: PerFieldVectorFormat

2021-05-06 Thread GitBox
msokolov commented on pull request #114: URL: https://github.com/apache/lucene/pull/114#issuecomment-833567527 > is the plan to do a separate followup to break out euclidean and dot product into codec parameter and remove from FieldInfo? as these are hnsw-specific parameters, they really b

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-05-06 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340242#comment-17340242 ] Robert Muir commented on LUCENE-9950: - +1 to add a "normal" facet method here, and d

[jira] [Commented] (LUCENE-9950) Support both single- and multi-value string fields in facet counting (non-taxonomy based approaches)

2021-05-06 Thread Greg Miller (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17340241#comment-17340241 ] Greg Miller commented on LUCENE-9950: - I've started digging into this code a bit and

[GitHub] [lucene-solr] janhoy commented on pull request #2489: SOLR-6152 Pre-populating values into search parameters on the query page of solr admin

2021-05-06 Thread GitBox
janhoy commented on pull request #2489: URL: https://github.com/apache/lucene-solr/pull/2489#issuecomment-833524515 Thanks for this. This PR is good for the 8.9 release. But we also need a PR against the 'main' branch in the brand new 9.0 git repo https://github.com/apache/solr ? The same

[GitHub] [lucene-solr] daniel6691 opened a new pull request #2489: SOLR-6152 Pre-populating values into search parameters on the query page of solr admin

2021-05-06 Thread GitBox
daniel6691 opened a new pull request #2489: URL: https://github.com/apache/lucene-solr/pull/2489 In some use cases, it is highly desirable to be able to pre-populate the query page of solr admin with specific values. In particular use case of mine, the solr admin user must pass a dat

[jira] [Resolved] (LUCENE-9826) Move lucene-site to using "main" branch

2021-05-06 Thread Jira
[ https://issues.apache.org/jira/browse/LUCENE-9826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved LUCENE-9826. - Resolution: Done This is already done, closing > Move lucene-site to using "main" branch >

[GitHub] [lucene-solr] janhoy commented on pull request #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin

2021-05-06 Thread GitBox
janhoy commented on pull request #1362: URL: https://github.com/apache/lucene-solr/pull/1362#issuecomment-833350574 @ravowlga123 There is an instruction at https://github.com/apache/lucene-solr/blob/master/PRs.md for how to prepare a PR for the main branch in the new repo. I'll close this,

[GitHub] [lucene-solr] janhoy closed pull request #1362: SOLR-13768 Remove requiresub parameter in JWTAuthPlugin

2021-05-06 Thread GitBox
janhoy closed pull request #1362: URL: https://github.com/apache/lucene-solr/pull/1362 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [lucene-solr] janhoy merged pull request #2486: SOLR-15384 Zookeeper Status handler /admin/zookeeper/status not queryable from SolrJ

2021-05-06 Thread GitBox
janhoy merged pull request #2486: URL: https://github.com/apache/lucene-solr/pull/2486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [lucene] dweiss commented on a change in pull request #128: LUCENE-9662: [WIP] CheckIndex should be concurrent

2021-05-06 Thread GitBox
dweiss commented on a change in pull request #128: URL: https://github.com/apache/lucene/pull/128#discussion_r627177953 ## File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java ## @@ -810,6 +976,8 @@ public Status checkIndex(List onlySegments) throws IOExcept