rmuir commented on a change in pull request #128:
URL: https://github.com/apache/lucene/pull/128#discussion_r627567282
##########
File path: lucene/core/src/java/org/apache/lucene/index/CheckIndex.java
##########
@@ -605,6 +610,15 @@ public Status checkIndex(List<String> onlySegments) throws
IOException {
result.newSegments.clear();
result.maxSegmentName = -1;
+ // nocommit number of threads should be set dynamically
Review comment:
can the checkIndex() method just take ExecutorService as a parameter?
This way, e.g. the calling `main` method could configure the ExecutorService
(possibly based on commandline options), unit tests can use a single thread,
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
