msokolov commented on pull request #114: URL: https://github.com/apache/lucene/pull/114#issuecomment-833567527
> is the plan to do a separate followup to break out euclidean and dot product into codec parameter and remove from FieldInfo? as these are hnsw-specific parameters, they really belong in that codec versus FieldInfo. Hmm, I think the similarity function is not specific to hnsw, but is likely to apply to any vector search, for which you always need to define some similarity function. Adrien's had earlier proposed we should move the truly HNSW-specific parameters like max-connections and beam-width, which pertain to the graph construction, out of VectorField (where we have VectorField.createHnswType) and into the codec, so I was thinking that would be the next step to make the API truly agnostic to the vector indexing codec. I'll address all the comments here (thanks!) and post a new rev today -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
