[GitHub] [lucene-solr] donnerpeter commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-28 Thread GitBox
donnerpeter commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566635372 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] wo

[jira] [Closed] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2021-01-28 Thread Pieter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pieter closed SOLR-15031. - > NPE caused by FunctionQParser returning a null ValueSource > --

[GitHub] [lucene-solr] asalamon74 commented on pull request #2252: SOLR-15111: Use JDK8 Base64 instead of own implementation

2021-01-28 Thread GitBox
asalamon74 commented on pull request #2252: URL: https://github.com/apache/lucene-solr/pull/2252#issuecomment-769637051 @madrob **ISO_8859_1** In the first version I used UTF_8 but later I checked the source code of java.util.Base64 ( http://hg.openjdk.java.net/jdk8/jdk8/jdk

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2253: LUCENE-9702: Hunspell: support alternate casing for short language codes

2021-01-28 Thread GitBox
dweiss commented on a change in pull request #2253: URL: https://github.com/apache/lucene-solr/pull/2253#discussion_r566629532 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Dictionary.java ## @@ -370,7 +370,7 @@ private void readAffixFile(In

[jira] [Commented] (LUCENE-9703) Hunspell: prohibit FORBIDDENWORD words and their case variations

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274207#comment-17274207 ] ASF subversion and git services commented on LUCENE-9703: - Commi

[jira] [Resolved] (LUCENE-9703) Hunspell: prohibit FORBIDDENWORD words and their case variations

2021-01-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9703. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: prohibit FORBIDDENWORD words an

[GitHub] [lucene-solr] dweiss merged pull request #2254: LUCENE-9703: Hunspell: prohibit FORBIDDENWORD words and their case variations

2021-01-28 Thread GitBox
dweiss merged pull request #2254: URL: https://github.com/apache/lucene-solr/pull/2254 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2260: LUCENE-9704: Hunspell: support capitalization for German ß

2021-01-28 Thread GitBox
dweiss commented on a change in pull request #2260: URL: https://github.com/apache/lucene-solr/pull/2260#discussion_r566626601 ## File path: lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Stemmer.java ## @@ -158,14 +173,52 @@ WordCase caseOf(char[] word, i

[jira] [Commented] (LUCENE-9706) Hunspell: support NEEDAFFIX flag on affixes

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274201#comment-17274201 ] ASF subversion and git services commented on LUCENE-9706: - Commi

[jira] [Resolved] (LUCENE-9706) Hunspell: support NEEDAFFIX flag on affixes

2021-01-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9706. - Fix Version/s: master (9.0) Resolution: Fixed > Hunspell: support NEEDAFFIX flag on affix

[GitHub] [lucene-solr] dweiss merged pull request #2262: LUCENE-9706: Hunspell: support NEEDAFFIX flag on affixes

2021-01-28 Thread GitBox
dweiss merged pull request #2262: URL: https://github.com/apache/lucene-solr/pull/2262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9700) Hunspell: support words with trailing dots

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274199#comment-17274199 ] ASF subversion and git services commented on LUCENE-9700: - Commi

[jira] [Resolved] (LUCENE-9700) Hunspell: support words with trailing dots

2021-01-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9700. - Resolution: Fixed > Hunspell: support words with trailing dots > ---

[jira] [Updated] (LUCENE-9700) Hunspell: support words with trailing dots

2021-01-28 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9700?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-9700: Fix Version/s: master (9.0) > Hunspell: support words with trailing dots > ---

[GitHub] [lucene-solr] dweiss merged pull request #2249: LUCENE-9700: Hunspell: support words with trailing dots

2021-01-28 Thread GitBox
dweiss merged pull request #2249: URL: https://github.com/apache/lucene-solr/pull/2249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274150#comment-17274150 ] David Smiley commented on SOLR-15119: - I think AB's comments on the issue originating

[GitHub] [lucene-solr] jaisonbi commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
jaisonbi commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-769534164 > I'm curious what your plan is for surfacing this DocValuesConfig configuration in the API - are you thinking of adding it to the DocValuesFormat in place of the existing

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r566531012 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi

[GitHub] [lucene-solr] madrob commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
madrob commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r566505171 ## File path: solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java ## @@ -106,6 +108,50 @@ public void doTest() throws IOException, SolrServer

[jira] [Comment Edited] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274053#comment-17274053 ] Megan Carey edited comment on SOLR-15119 at 1/29/21, 12:26 AM:

[GitHub] [lucene-solr] megancarey commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
megancarey commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r566495456 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -407,15 +432,6 @@ public boolean split(ClusterStat

[GitHub] [lucene-solr] megancarey commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
megancarey commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r566495266 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -60,7 +60,10 @@ import static org.apache.solr.com

[GitHub] [lucene-solr] megancarey commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
megancarey commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r56642 ## File path: solr/core/src/test/org/apache/solr/cloud/SplitShardTest.java ## @@ -106,6 +108,50 @@ public void doTest() throws IOException, SolrSe

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274053#comment-17274053 ] Megan Carey commented on SOLR-15119: [~anshum] - in a sense, that's true. The IndexWr

[jira] [Commented] (SOLR-15120) Reduce duplicative core creation work

2021-01-28 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274051#comment-17274051 ] Mike Drob commented on SOLR-15120: -- [~ahubold] - this fix touches some of the code intro

[GitHub] [lucene-solr] madrob opened a new pull request #2266: SOLR-15120 Reduce duplicated core creation work

2021-01-28 Thread GitBox
madrob opened a new pull request #2266: URL: https://github.com/apache/lucene-solr/pull/2266 Use j.u.c collections instead of sync block Rework how we load implicit handlers Additional debug and trace logging for zookeeper comms ---

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274049#comment-17274049 ] Anshum Gupta commented on SOLR-15119: - Also, the IndexSizeTrigger that uses {{LINK}}

[jira] [Created] (SOLR-15120) Reduce duplicative core creation work

2021-01-28 Thread Mike Drob (Jira)
Mike Drob created SOLR-15120: Summary: Reduce duplicative core creation work Key: SOLR-15120 URL: https://issues.apache.org/jira/browse/SOLR-15120 Project: Solr Issue Type: Sub-task Securit

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread Anshum Gupta (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274046#comment-17274046 ] Anshum Gupta commented on SOLR-15119: - Unless something changed recently, I feel like

[GitHub] [lucene-solr] madrob commented on a change in pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
madrob commented on a change in pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265#discussion_r566467915 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java ## @@ -80,16 +83,33 @@ public void call(ClusterState state,

[jira] [Commented] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274039#comment-17274039 ] David Smiley commented on SOLR-15119: - +1 absolutely.  I wish it was simply set this

[GitHub] [lucene-solr] megancarey opened a new pull request #2265: SOLR-15119 Add logs and make default splitMethod to be LINK

2021-01-28 Thread GitBox
megancarey opened a new pull request #2265: URL: https://github.com/apache/lucene-solr/pull/2265 # Description REWRITE splitMethod is considerably slower than LINK. Deprecated Autoscaling triggers used LINK method as default, contradicting SplitShardCmd. # Solution

[GitHub] [lucene-solr-operator] thelabdude closed issue #192: Support custom log4j2.xml via user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude closed issue #192: URL: https://github.com/apache/lucene-solr-operator/issues/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [lucene-solr-operator] thelabdude merged pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude merged pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Comment Edited] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274026#comment-17274026 ] Julie Tibshirani edited comment on LUCENE-9616 at 1/28/21, 10:07 PM: -

[jira] [Resolved] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julie Tibshirani resolved LUCENE-9616. -- Resolution: Fixed > Improve test coverage for internal format versions > -

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274026#comment-17274026 ] Julie Tibshirani commented on LUCENE-9616: -- It sounds like we're on the same pa

[jira] [Commented] (SOLR-14616) Remove CDCR from 9.0

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274014#comment-17274014 ] ASF subversion and git services commented on SOLR-14616: Commit a

[GitHub] [lucene-solr] madrob commented on a change in pull request #2252: SOLR-15111: Use JDK8 Base64 instead of own implementation

2021-01-28 Thread GitBox
madrob commented on a change in pull request #2252: URL: https://github.com/apache/lucene-solr/pull/2252#discussion_r566409696 ## File path: solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java ## @@ -298,7 +299,7 @@ private static String getFieldFlags( Sch

[jira] [Updated] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9334: - Priority: Blocker (was: Major) > Require consistency between data-structures on a per-field bas

[jira] [Updated] (LUCENE-9334) Require consistency between data-structures on a per-field basis

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9334: - Fix Version/s: master (9.0) > Require consistency between data-structures on a per-field basis >

[jira] [Updated] (LUCENE-9047) Directory APIs should be little endian

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9047: - Fix Version/s: master (9.0) > Directory APIs should be little endian > -

[jira] [Updated] (LUCENE-9047) Directory APIs should be little endian

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand updated LUCENE-9047: - Priority: Blocker (was: Major) > Directory APIs should be little endian > -

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2249: LUCENE-9700: Hunspell: support words with trailing dots

2021-01-28 Thread GitBox
jpountz commented on a change in pull request #2249: URL: https://github.com/apache/lucene-solr/pull/2249#discussion_r566410259 ## File path: lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/base.good ## @@ -0,0 +1,27 @@ +created +uncreate +uncreated +imply

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273995#comment-17273995 ] Adrien Grand commented on LUCENE-9705: -- +1 to split all file formats that are used

[GitHub] [lucene-solr] madrob merged pull request #2264: Require Thread Names in Solr

2021-01-28 Thread GitBox
madrob merged pull request #2264: URL: https://github.com/apache/lucene-solr/pull/2264 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-28 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273992#comment-17273992 ] Adrien Grand commented on LUCENE-9616: -- [~julietibs] +1 to more aggressively copy-o

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
HoustonPutman commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566367646 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (c

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-28 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566362852 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/BinaryDocValueSelector.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr-operator] sepulworld edited a comment on issue #204: Deprecate official support for the SolrCollection and SolrCollectionAlias CRDs

2021-01-28 Thread GitBox
sepulworld edited a comment on issue #204: URL: https://github.com/apache/lucene-solr-operator/issues/204#issuecomment-769293093 I can help with this. I was thinking we could start a [Terraform Provider](https://www.terraform.io/docs/extend/index.html) and automate resource management for

[jira] [Resolved] (LUCENE-9695) Don't include deleted documents when merging vectors

2021-01-28 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Sokolov resolved LUCENE-9695. - Resolution: Fixed > Don't include deleted documents when merging vectors > -

[GitHub] [lucene-solr] madrob opened a new pull request #2264: Require Thread Names in Solr

2021-01-28 Thread GitBox
madrob opened a new pull request #2264: URL: https://github.com/apache/lucene-solr/pull/2264 When we are creating a new thread we should give it a name. This doesn't apply to Runnable or Callable objects that we pass to an executor, since those should be getting named by the executor itsel

[jira] [Commented] (SOLR-14886) Suppress stack trace in Query response.

2021-01-28 Thread Isabelle Giguere (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273951#comment-17273951 ] Isabelle Giguere commented on SOLR-14886: - Note that the patch cannot fix the cas

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566340100 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl

[jira] [Created] (SOLR-15119) Make LINK splitMethod the default for SplitShardCmd

2021-01-28 Thread Megan Carey (Jira)
Megan Carey created SOLR-15119: -- Summary: Make LINK splitMethod the default for SplitShardCmd Key: SOLR-15119 URL: https://issues.apache.org/jira/browse/SOLR-15119 Project: Solr Issue Type: Impr

[jira] [Commented] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273937#comment-17273937 ] ASF subversion and git services commented on SOLR-14672: Commit 0

[GitHub] [lucene-solr-operator] HoustonPutman closed issue #194: Change the Solr Operator docker namespace to "Apache"

2021-01-28 Thread GitBox
HoustonPutman closed issue #194: URL: https://github.com/apache/lucene-solr-operator/issues/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #199: Change docker image location to apache/

2021-01-28 Thread GitBox
HoustonPutman merged pull request #199: URL: https://github.com/apache/lucene-solr-operator/pull/199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
HoustonPutman commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566324592 ## File path: docs/solr-cloud/solr-cloud-crd.md ## @@ -127,4 +127,118 @@ the solr-operator can manage Zookeeper ensemble(s) for you. U

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-28 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566324738 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/BinaryDocValueSelector.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr-operator] sepulworld commented on issue #204: Deprecate official support for the SolrCollection and SolrCollectionAlias CRDs

2021-01-28 Thread GitBox
sepulworld commented on issue #204: URL: https://github.com/apache/lucene-solr-operator/issues/204#issuecomment-769293093 I can help with this. I was thinking we could start a [Terraform Provider](https://www.terraform.io/docs/extend/index.html) and provide state and resource management f

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-28 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566324474 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/BinaryDocValueSelector.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software

[GitHub] [lucene-solr] zhaih commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-28 Thread GitBox
zhaih commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566324286 ## File path: lucene/CHANGES.txt ## @@ -247,6 +247,13 @@ Other * LUCENE-9627: Remove unused Lucene50FieldInfosFormat codec and small refactor some cod

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
HoustonPutman commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566277962 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (c

[GitHub] [lucene-solr-operator] thelabdude commented on pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#issuecomment-769283945 Now with docs! ;-) This is an automated message from the Apache Git Service. To respond to the me

[jira] [Commented] (SOLR-15116) Wrong HTTP status for HEAD request

2021-01-28 Thread Thomas Corthals (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273918#comment-17273918 ] Thomas Corthals commented on SOLR-15116: Prodding around in the code a bit, I not

[jira] [Updated] (SOLR-15116) Wrong HTTP status for HEAD request

2021-01-28 Thread Thomas Corthals (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Corthals updated SOLR-15116: --- Attachment: 0001-Same-PermissionName-for-HEAD-requests-as-for-GET-req.patch > Wrong HTTP stat

[jira] [Commented] (LUCENE-9705) Move all codec formats to the o.a.l.codecs.Lucene90 package

2021-01-28 Thread Julie Tibshirani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273903#comment-17273903 ] Julie Tibshirani commented on LUCENE-9705: -- This proposal makes sense to me. I'

[GitHub] [lucene-solr-operator] HoustonPutman opened a new issue #205: Delete Managed Kube resources that are no longer used

2021-01-28 Thread GitBox
HoustonPutman opened a new issue #205: URL: https://github.com/apache/lucene-solr-operator/issues/205 The Solr Operator creates many Kubernetes resources while reconciling. The operator will often choose to create or not create resources depending on the configuration of Solr resourc

[jira] [Commented] (SOLR-15116) Wrong HTTP status for HEAD request

2021-01-28 Thread Thomas Corthals (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273892#comment-17273892 ] Thomas Corthals commented on SOLR-15116: I hit another one that seems related, in

[jira] [Resolved] (SOLR-15113) More gracefully handle embedded ZK failure to start

2021-01-28 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob resolved SOLR-15113. -- Fix Version/s: master (9.0) Resolution: Fixed > More gracefully handle embedded ZK failure to st

[jira] [Commented] (SOLR-15113) More gracefully handle embedded ZK failure to start

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273890#comment-17273890 ] ASF subversion and git services commented on SOLR-15113: Commit 9

[GitHub] [lucene-solr] madrob merged pull request #2255: SOLR-15113 Do not attempt to start Solr server when embedded ZK fails

2021-01-28 Thread GitBox
madrob merged pull request #2255: URL: https://github.com/apache/lucene-solr/pull/2255 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (SOLR-15118) Make /v2/collections APIs annotation-based

2021-01-28 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15118: --- Summary: Make /v2/collections APIs annotation-based (was: Convert /v2/collections v2 APIs to

[jira] [Created] (SOLR-15118) Convert /v2/collections v2 APIs to annotation

2021-01-28 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-15118: -- Summary: Convert /v2/collections v2 APIs to annotation Key: SOLR-15118 URL: https://issues.apache.org/jira/browse/SOLR-15118 Project: Solr Issue Type: Su

[jira] [Created] (SOLR-15117) Support for "description" metadata in annotation-based v2 APIs

2021-01-28 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-15117: -- Summary: Support for "description" metadata in annotation-based v2 APIs Key: SOLR-15117 URL: https://issues.apache.org/jira/browse/SOLR-15117 Project: Solr

[GitHub] [lucene-solr-operator] HoustonPutman opened a new issue #204: Deprecate official support for the SolrCollection and SolrCollectionAlias CRDs

2021-01-28 Thread GitBox
HoustonPutman opened a new issue #204: URL: https://github.com/apache/lucene-solr-operator/issues/204 The `SolrCollection` and `SolrCollectionAlias` CRDs are nice constructs that allow users to create Solr collections and aliases through Kubernetes APIs (and tools, such as kubectl).

[GitHub] [lucene-solr] HoustonPutman commented on a change in pull request #2263: SOLR-14978 OOM Killer in Foreground (#2055)

2021-01-28 Thread GitBox
HoustonPutman commented on a change in pull request #2263: URL: https://github.com/apache/lucene-solr/pull/2263#discussion_r566275295 ## File path: solr/docker/Dockerfile ## @@ -54,7 +54,7 @@ ARG SOLR_VERSION # Used by solr-fg ENV SOLR_VERSION $SOLR_VERSION -COPY --from=inp

[GitHub] [lucene-solr] mikemccand commented on a change in pull request #2246: LUCENE-9694: New tool for creating a deterministic index

2021-01-28 Thread GitBox
mikemccand commented on a change in pull request #2246: URL: https://github.com/apache/lucene-solr/pull/2246#discussion_r566271500 ## File path: lucene/misc/src/java/org/apache/lucene/misc/index/BinaryDocValueSelector.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene-solr] madrob opened a new pull request #2263: SOLR-14978 OOM Killer in Foreground (#2055)

2021-01-28 Thread GitBox
madrob opened a new pull request #2263: URL: https://github.com/apache/lucene-solr/pull/2263 Combine Docker and bin/solr OOM handling scripts, move OOM handling to foreground Solr as well. Co-authored-by: Houston Putman -

[jira] [Commented] (SOLR-15116) Wrong HTTP status for HEAD request

2021-01-28 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273852#comment-17273852 ] David Eric Pugh commented on SOLR-15116: Makes sense to me.   I suspect you hit o

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566236753 ## File path: controllers/suite_test.go ## @@ -76,6 +78,9 @@ func SetupTestReconcile(inner reconcile.Reconciler) (reconcile.Reconciler, ch

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566235409 ## File path: controllers/util/solr_util.go ## @@ -327,13 +330,42 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566235249 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl

[GitHub] [lucene-solr-operator] HoustonPutman merged pull request #202: Update helm docs, and add link to new artifactHub.

2021-01-28 Thread GitBox
HoustonPutman merged pull request #202: URL: https://github.com/apache/lucene-solr-operator/pull/202 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [lucene-solr-operator] HoustonPutman commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
HoustonPutman commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566232749 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (c

[jira] [Created] (SOLR-15116) Wrong HTTP status for HEAD request

2021-01-28 Thread Thomas Corthals (Jira)
Thomas Corthals created SOLR-15116: -- Summary: Wrong HTTP status for HEAD request Key: SOLR-15116 URL: https://issues.apache.org/jira/browse/SOLR-15116 Project: Solr Issue Type: Bug Sec

[jira] [Commented] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-01-28 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273810#comment-17273810 ] ASF subversion and git services commented on SOLR-14672: Commit a

[GitHub] [lucene-solr-operator] thelabdude commented on a change in pull request #193: Support custom log4j2 config from user-provided ConfigMap

2021-01-28 Thread GitBox
thelabdude commented on a change in pull request #193: URL: https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566184234 ## File path: controllers/solrcloud_controller.go ## @@ -182,44 +182,61 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl

[GitHub] [lucene-solr-operator] janhoy opened a new pull request #203: Fix copy/paste typo addressed -> updated

2021-01-28 Thread GitBox
janhoy opened a new pull request #203: URL: https://github.com/apache/lucene-solr-operator/pull/203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (SOLR-14672) Make timeouts configurable for the Streaming Expression SolrClientCache

2021-01-28 Thread Joel Bernstein (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Bernstein updated SOLR-14672: -- Attachment: SOLR-14672.patch > Make timeouts configurable for the Streaming Expression SolrClie

[GitHub] [lucene-solr] donnerpeter opened a new pull request #2262: LUCENE-9706: Hunspell: support NEEDAFFIX flag on affixes

2021-01-28 Thread GitBox
donnerpeter opened a new pull request #2262: URL: https://github.com/apache/lucene-solr/pull/2262 # Description From `man`: > This flag signs virtual stems in the dictionary, words only valid when affixed. Except, if the dictionary word has a homonym or a zero affi

[jira] [Created] (LUCENE-9706) Hunspell: support NEEDAFFIX flag on affixes

2021-01-28 Thread Peter Gromov (Jira)
Peter Gromov created LUCENE-9706: Summary: Hunspell: support NEEDAFFIX flag on affixes Key: LUCENE-9706 URL: https://issues.apache.org/jira/browse/LUCENE-9706 Project: Lucene - Core Issue Typ

[GitHub] [lucene-solr] msokolov commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
msokolov commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r566092357 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi

[GitHub] [lucene-solr] msokolov commented on pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
msokolov commented on pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#issuecomment-769042377 @jaisonbi I'm curious what your plan is for surfacing this DocValuesConfig configuration in the API - are you thinking of adding it to the DocValuesFormat in place of the e

[GitHub] [lucene-solr] jaisonbi commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
jaisonbi commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r566042201 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addTermsDi

[GitHub] [lucene-solr] asalamon74 opened a new pull request #2261: SOLR-15115: Remove unused methods from TestRerankBase

2021-01-28 Thread GitBox
asalamon74 opened a new pull request #2261: URL: https://github.com/apache/lucene-solr/pull/2261 # Description There are two unused methods in TestRerankBase: buildIndexUsingAdoc, loadModelAndFeatures which can be removed. # Solution Remove the methods.

[jira] [Created] (SOLR-15115) Remove unused methods from TestRerankBase

2021-01-28 Thread Andras Salamon (Jira)
Andras Salamon created SOLR-15115: - Summary: Remove unused methods from TestRerankBase Key: SOLR-15115 URL: https://issues.apache.org/jira/browse/SOLR-15115 Project: Solr Issue Type: Task

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2213: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted DocValues

2021-01-28 Thread GitBox
bruno-roustant commented on a change in pull request #2213: URL: https://github.com/apache/lucene-solr/pull/2213#discussion_r566003862 ## File path: lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesConsumer.java ## @@ -791,6 +806,107 @@ private void addT

[jira] [Commented] (LUCENE-9616) Improve test coverage for internal format versions

2021-01-28 Thread Ignacio Vera (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273484#comment-17273484 ] Ignacio Vera commented on LUCENE-9616: -- I open LUCENE-9705 to move all current form

  1   2   >