thelabdude commented on a change in pull request #193:
URL:
https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566236753
##########
File path: controllers/suite_test.go
##########
@@ -76,6 +78,9 @@ func SetupTestReconcile(inner reconcile.Reconciler)
(reconcile.Reconciler, chan
requests := make(chan reconcile.Request)
fn := reconcile.Func(func(req reconcile.Request) (reconcile.Result,
error) {
result, err := inner.Reconcile(req)
+ if err != nil {
+ fmt.Printf("\n\nReconcile Error: %s\n\n", err)
Review comment:
this is a bit ugly but so useful in tracking down errors during
reconcile that are returned like this:
```
if !strings.Contains(solrXml, "${hostPort:") {
return requeueOrNot,
fmt.Errorf("Custom solr.xml in
ConfigMap %s must contain a placeholder for the 'hostPort' variable, such as
<int name=\"hostPort\">${hostPort:80}</int>",
providedConfigMapName)
}
```
W/o this change, the error isn't reported and the test just fails with
reconcile timeouts. I think it's a useful addition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
