thelabdude commented on a change in pull request #193:
URL: 
https://github.com/apache/lucene-solr-operator/pull/193#discussion_r566235409



##########
File path: controllers/util/solr_util.go
##########
@@ -327,13 +330,42 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, 
solrCloudStatus *solr.SolrCl
                envVars = append(envVars, customPodOptions.EnvVariables...)
        }
 
+       // Did the user provide a custom log config?
+       if configMapInfo[LogXmlFile] != "" {
+
+               if configMapInfo[LogXmlMd5Annotation] != "" {
+                       if podAnnotations == nil {
+                               podAnnotations = make(map[string]string, 1)
+                       }
+                       podAnnotations[LogXmlMd5Annotation] = 
configMapInfo[LogXmlMd5Annotation]
+               }
+
+               // cannot use /var/solr as a mountPath, so mount the custom log 
config in a sub-dir
+               volName := "log4j2-xml"
+               mountPath := fmt.Sprintf("/var/solr/%s-log-config", 
solrCloud.Name)
+               log4jPropsEnvVarPath := fmt.Sprintf("%s/%s", mountPath, 
LogXmlFile)
+
+               solrVolumes = append(solrVolumes, corev1.Volume{

Review comment:
       Latest commit addresses this issue.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to