[jira] [Commented] (SOLR-12613) Rename "Cloud" tab as "Cluster" in Admin UI

2021-01-06 Thread Tim Dillon (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260293#comment-17260293 ] Tim Dillon commented on SOLR-12613: --- Is there still interest in pursuing this renaming?

[GitHub] [lucene-solr] zacharymorn commented on pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer

2021-01-06 Thread GitBox
zacharymorn commented on pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#issuecomment-755943893 > Thanks this looks good to me. I'll merge in the next few days. Thanks Adrien for the review and approval! I also took a look and thought about the possible steps

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer

2021-01-06 Thread GitBox
zacharymorn commented on a change in pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r553153718 ## File path: lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer

2021-01-06 Thread GitBox
zacharymorn commented on a change in pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r553153647 ## File path: lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java ## @@ -230,10 +232,13 @@ private Scorer opt( for (

[jira] [Created] (SOLR-15072) Support building and testing Solr on ARM64 architecture

2021-01-06 Thread liusheng (Jira)
liusheng created SOLR-15072: --- Summary: Support building and testing Solr on ARM64 architecture Key: SOLR-15072 URL: https://issues.apache.org/jira/browse/SOLR-15072 Project: Solr Issue Type: Improv

[GitHub] [lucene-solr] muse-dev[bot] commented on a change in pull request #2170: LUCENE-9648: Add a numbers query in sandbox that takes advantage of index sorting

2021-01-06 Thread GitBox
muse-dev[bot] commented on a change in pull request #2170: URL: https://github.com/apache/lucene-solr/pull/2170#discussion_r553110906 ## File path: lucene/sandbox/src/java/org/apache/lucene/sandbox/search/IndexSortDocValuesNumbersQuery.java ## @@ -0,0 +1,272 @@ +/* + * License

[GitHub] [lucene-solr] noblepaul edited a comment on pull request #2177: SOLR-15052: Per-replica states for reducing overseer bottlenecks (trunk)

2021-01-06 Thread GitBox
noblepaul edited a comment on pull request #2177: URL: https://github.com/apache/lucene-solr/pull/2177#issuecomment-755019793 > Please note that there are still a lot of outstanding comments on the 8x version of this PR, I worry that you are going to end up doing double work trying to main

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-06 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-755818100 Hi @msokolov: If you have so time, you may check performance again. I rewrote the getBytes() and getLEXxxx() methods a bit. -

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-06 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-755789343 FYI, I added some interface in oal.util.Unwrapable that can be implemented by our mocking layers in test-framework. The new interface allows us to unwrap the Path without

[GitHub] [lucene-solr] uschindler removed a comment on pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-06 Thread GitBox
uschindler removed a comment on pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-755788737 FYI, I added some interface in oal.util.Unwrapable that can be implemented by our mocking layers in test-framework. The new interface allows us to unwrap the `Pat

[GitHub] [lucene-solr] uschindler commented on pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-06 Thread GitBox
uschindler commented on pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175#issuecomment-755788737 FYI, I added some interface in oal.util.Unwrapable that can be implemented by our mocking layers in test-framework. The new interface allows us to unwrap the `Path` witho

[GitHub] [lucene-solr] uschindler commented on pull request #2176: Initial rewrite of MMapDirectory for JDK-16 preview (incubating) PANAMA APIs

2021-01-06 Thread GitBox
uschindler commented on pull request #2176: URL: https://github.com/apache/lucene-solr/pull/2176#issuecomment-755778832 Hi @msokolov: I added the readLEFloats() from #2175 here. This is an automated message from the Apache Gi

[jira] [Resolved] (SOLR-15069) child doc transformer should make parentFilter obsolete

2021-01-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley resolved SOLR-15069. - Fix Version/s: 8.8 Resolution: Fixed > child doc transformer should make parentFilter obso

[jira] [Commented] (SOLR-15069) child doc transformer should make parentFilter obsolete

2021-01-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260100#comment-17260100 ] ASF subversion and git services commented on SOLR-15069: Commit 7

[jira] [Commented] (SOLR-15069) child doc transformer should make parentFilter obsolete

2021-01-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260093#comment-17260093 ] ASF subversion and git services commented on SOLR-15069: Commit 3

[GitHub] [lucene-solr] dsmiley merged pull request #2181: SOLR-15069 child parent filter

2021-01-06 Thread GitBox
dsmiley merged pull request #2181: URL: https://github.com/apache/lucene-solr/pull/2181 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2159: SOLR-14923: Nested docs indexing performance.

2021-01-06 Thread GitBox
dsmiley commented on a change in pull request #2159: URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552999880 ## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ## @@ -218,31 +225,40 @@ Indexing nested documents _requires_ an indexed field n

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2159: SOLR-14923: Nested docs indexing performance.

2021-01-06 Thread GitBox
ctargett commented on a change in pull request #2159: URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552983347 ## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ## @@ -218,31 +225,40 @@ Indexing nested documents _requires_ an indexed field

[jira] [Commented] (LUCENE-9652) DataInput.readFloats to be used by Lucene90VectorReader

2021-01-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260062#comment-17260062 ] ASF subversion and git services commented on LUCENE-9652: - Commi

[GitHub] [lucene-solr] msokolov merged pull request #2175: LUCENE-9652: DataInput.readFloats for use by Lucene90VectorReader

2021-01-06 Thread GitBox
msokolov merged pull request #2175: URL: https://github.com/apache/lucene-solr/pull/2175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [lucene-solr] jpountz commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer

2021-01-06 Thread GitBox
jpountz commented on a change in pull request #2141: URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r552956753 ## File path: lucene/core/src/java/org/apache/lucene/search/ScorerUtil.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Commented] (SOLR-14787) Inequality support in Payload Check query parser

2021-01-06 Thread Kevin Watters (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17260038#comment-17260038 ] Kevin Watters commented on SOLR-14787: -- Hey [~gus]  I think this PR is all cleaned u

[GitHub] [lucene-solr] dsmiley commented on a change in pull request #2159: SOLR-14923: Nested docs indexing performance.

2021-01-06 Thread GitBox
dsmiley commented on a change in pull request #2159: URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552920830 ## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ## @@ -218,31 +225,40 @@ Indexing nested documents _requires_ an indexed field n

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-06 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259994#comment-17259994 ] David Eric Pugh commented on SOLR-13105: Very excited about this. If you need so

[jira] [Commented] (SOLR-15071) Bug on LTR when using solr 8.6.3 - index out of bounds DisiPriorityQueue.add(DisiPriorityQueue.java:102)

2021-01-06 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259985#comment-17259985 ] Christine Poerschke commented on SOLR-15071: Thanks [~florin.babes] for creat

[jira] [Comment Edited] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-06 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259981#comment-17259981 ] Cassandra Targett edited comment on SOLR-13105 at 1/6/21, 6:51 PM:

[GitHub] [lucene-solr] gerlowskija commented on pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-06 Thread GitBox
gerlowskija commented on pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-755510683 It looks like SimpleOrderedMap is preferred in the sort of serialization/deserialization usecase involved here, so I've updated the PR to use it instead as Mike suggeste

[jira] [Commented] (SOLR-13105) A visual guide to Solr Math Expressions and Streaming Expressions

2021-01-06 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259981#comment-17259981 ] Cassandra Targett commented on SOLR-13105: -- This issue was completed enough for

[GitHub] [lucene-solr] gerlowskija commented on pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-06 Thread GitBox
gerlowskija commented on pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-755468135 > would using another SimpleOrderedMap (which extends NamedList) be better than a NamedList directly? Maybe? I'll admit I'm not as familiar as I should be with th

[GitHub] [lucene-solr] nknize commented on a change in pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

2021-01-06 Thread GitBox
nknize commented on a change in pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#discussion_r552871766 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointQuery.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] nknize commented on a change in pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

2021-01-06 Thread GitBox
nknize commented on a change in pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155#discussion_r552871575 ## File path: lucene/core/src/java/org/apache/lucene/document/LatLonPointQuery.java ## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-06 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552865278 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java ## @@ -564,12 +539,17 @@ public boolean isPreOp() { }

[jira] [Resolved] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2021-01-06 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter resolved SOLR-15047. --- Fix Version/s: master (9.0) 8.8 Resolution: Fixed > 'collap

[jira] [Commented] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2021-01-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259944#comment-17259944 ] ASF subversion and git services commented on SOLR-15047: Commit c

[GitHub] [lucene-solr] kwatters commented on a change in pull request #1954: SOLR-14787 - Adding support to use inequalities to the payload check query parser.

2021-01-06 Thread GitBox
kwatters commented on a change in pull request #1954: URL: https://github.com/apache/lucene-solr/pull/1954#discussion_r552863407 ## File path: lucene/queries/src/java/org/apache/lucene/queries/payloads/PayloadMatcherFactory.java ## @@ -0,0 +1,243 @@ +/* + * Licensed to the Apa

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2021-01-06 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r552861978 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java ## @@ -0,0 +1,600 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [lucene-solr] madrob commented on pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-06 Thread GitBox
madrob commented on pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183#issuecomment-755457983 would using another SimpleOrderedMap (which extends NamedList) be better than a NamedList directly? This is

[GitHub] [lucene-solr] ctargett commented on pull request #2159: SOLR-14923: Nested docs indexing performance.

2021-01-06 Thread GitBox
ctargett commented on pull request #2159: URL: https://github.com/apache/lucene-solr/pull/2159#issuecomment-755454728 Other than the one section in docs that I commented on, the rest of the doc changes look good - thanks! Th

[GitHub] [lucene-solr] gerlowskija opened a new pull request #2183: SOLR-15070: Remove HashMap usage in SuggestComponent rsp

2021-01-06 Thread GitBox
gerlowskija opened a new pull request #2183: URL: https://github.com/apache/lucene-solr/pull/2183 # Description The HashMap added to the response by SuggestComponent is handled differently by each output format/wt/ResponseParser that Solr supports. This discrepancy causes SolrJ pro

[GitHub] [lucene-solr] ctargett commented on a change in pull request #2159: SOLR-14923: Nested docs indexing performance.

2021-01-06 Thread GitBox
ctargett commented on a change in pull request #2159: URL: https://github.com/apache/lucene-solr/pull/2159#discussion_r552851326 ## File path: solr/solr-ref-guide/src/indexing-nested-documents.adoc ## @@ -218,31 +225,40 @@ Indexing nested documents _requires_ an indexed field

[jira] [Commented] (SOLR-15069) child doc transformer should make parentFilter obsolete

2021-01-06 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259888#comment-17259888 ] David Smiley commented on SOLR-15069: - I'll be committing this later today.  I know I

[jira] [Commented] (SOLR-15047) 'collapse' on numeric field treats all docs with '0' in collapse field as part of the null group

2021-01-06 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259887#comment-17259887 ] ASF subversion and git services commented on SOLR-15047: Commit 0

[jira] [Commented] (SOLR-14999) Add built-in option to advertise Solr with a different port than Jetty listens on.

2021-01-06 Thread Houston Putman (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259834#comment-17259834 ] Houston Putman commented on SOLR-14999: --- So we can't "deprecate" jetty.port really,

[jira] [Updated] (SOLR-15070) SolrJ ClassCastException on XML /suggest requests

2021-01-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15070: --- Description: SolrJ throws a ClassCastException when parsing XML {{/suggest}} responses. The

[jira] [Updated] (SOLR-15070) SolrJ ClassCastException on XML /suggest requests

2021-01-06 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gerlowski updated SOLR-15070: --- Description: SolrJ throws a ClassCastException when parsing XML {{/suggest}} responses. The

[jira] [Created] (SOLR-15071) Bug on LTR when using solr 8.6.3 - index out of bounds DisiPriorityQueue.add(DisiPriorityQueue.java:102)

2021-01-06 Thread Florin Babes (Jira)
Florin Babes created SOLR-15071: --- Summary: Bug on LTR when using solr 8.6.3 - index out of bounds DisiPriorityQueue.add(DisiPriorityQueue.java:102) Key: SOLR-15071 URL: https://issues.apache.org/jira/browse/SOLR-150

[jira] [Created] (SOLR-15070) SolrJ ClassCastException on XML /suggest requests

2021-01-06 Thread Jason Gerlowski (Jira)
Jason Gerlowski created SOLR-15070: -- Summary: SolrJ ClassCastException on XML /suggest requests Key: SOLR-15070 URL: https://issues.apache.org/jira/browse/SOLR-15070 Project: Solr Issue Type

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

2021-01-06 Thread GitBox
bruno-roustant commented on a change in pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552628244 ## File path: solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java ## @@ -339,10 +332,10 @@ public boolean exists(String path)

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

2021-01-06 Thread GitBox
bruno-roustant commented on a change in pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552623138 ## File path: solr/core/src/java/org/apache/solr/core/DelegatingDirectoryFactory.java ## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Soft

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

2021-01-06 Thread GitBox
bruno-roustant commented on a change in pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552618150 ## File path: solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java ## @@ -339,10 +332,10 @@ public boolean exists(String path)

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

2021-01-06 Thread GitBox
bruno-roustant commented on a change in pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552618150 ## File path: solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java ## @@ -339,10 +332,10 @@ public boolean exists(String path)

[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

2021-01-06 Thread Michael McCandless (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17259708#comment-17259708 ] Michael McCandless commented on LUCENE-9640: Right, the idea here is that th

[GitHub] [lucene-solr] sigram commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-06 Thread GitBox
sigram commented on a change in pull request #2179: URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552606865 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -254,8 +280,27 @@ public void call(ClusterState

[GitHub] [lucene-solr] bruno-roustant commented on a change in pull request #2166: SOLR-15060: Introduce DelegatingDirectoryFactory.

2021-01-06 Thread GitBox
bruno-roustant commented on a change in pull request #2166: URL: https://github.com/apache/lucene-solr/pull/2166#discussion_r552606223 ## File path: solr/core/src/java/org/apache/solr/core/CachingDirectoryFactory.java ## @@ -405,11 +398,6 @@ public void incRef(Directory directo

[GitHub] [lucene-solr] sigram commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-06 Thread GitBox
sigram commented on a change in pull request #2179: URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552527986 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -193,6 +195,22 @@ public PlacementPlan

[GitHub] [lucene-solr] sigram commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-06 Thread GitBox
sigram commented on a change in pull request #2179: URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552527986 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java ## @@ -193,6 +195,22 @@ public PlacementPlan

[GitHub] [lucene-solr] sigram commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-06 Thread GitBox
sigram commented on a change in pull request #2179: URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552526286 ## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java ## @@ -116,6 +121,25 @@ public void call(ClusterState

[GitHub] [lucene-solr] sigram commented on a change in pull request #2179: SOLR-15055 Re-implement 'withCollection' and 'maxShardsPerNode'

2021-01-06 Thread GitBox
sigram commented on a change in pull request #2179: URL: https://github.com/apache/lucene-solr/pull/2179#discussion_r552524187 ## File path: solr/solrj/src/java/org/apache/solr/common/params/CollectionAdminParams.java ## @@ -80,6 +80,17 @@ */ String COLL_CONF = "collect