[GitHub] [lucene-solr] dweiss commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-17 Thread GitBox
dweiss commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-747906708 You can try to ask on JDK's compiler-dev mailing list, Zach. Sources for the JDK are also available - I sometimes hack and recompile a custom distro and this proves the simpl

[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-17 Thread GitBox
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-747890887 > > Alas, `gradlew precommit` from the command-line on Linux box is still angry for me: > > ``` > > > Task :lucene:misc:compileJava > > /l/trunk/lucene/misc/src

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-17 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r545438137 ## File path: solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java ## @@ -81,6 +81,7 @@ public class SolrCloudTestCase extends S

[GitHub] [lucene-solr] madrob commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks

2020-12-17 Thread GitBox
madrob commented on a change in pull request #2148: URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r544619375 ## File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java ## @@ -432,7 +432,7 @@ final private void doReplicateOnlyRecovery(SolrCore

[GitHub] [lucene-solr] madrob merged pull request #2156: Clean up IDEA config generation

2020-12-17 Thread GitBox
madrob merged pull request #2156: URL: https://github.com/apache/lucene-solr/pull/2156 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene-solr] madrob opened a new pull request #2156: Clean up IDEA config generation

2020-12-17 Thread GitBox
madrob opened a new pull request #2156: URL: https://github.com/apache/lucene-solr/pull/2156 Remove references to clustering contrib, catch up ivy version, remove obsolete references to spatial contrib. This is an automated

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545162052 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetric.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545160385 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java ## @@ -70,6 +71,12 @@ */ AttributeFetcher requestNod

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545154753 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/ReplicaMetric.java ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software F

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545153262 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/CollectionMetrics.java ## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545151767 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java ## @@ -65,11 +65,16 @@ /** * For the given node: metr

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545146525 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeValues.java ## @@ -65,11 +65,16 @@ /** * For the given node: metr

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2133: SOLR-15019: Replica placement API needs a way to fetch existing replica metrics

2020-12-17 Thread GitBox
murblanc commented on a change in pull request #2133: URL: https://github.com/apache/lucene-solr/pull/2133#discussion_r545143577 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/AttributeFetcher.java ## @@ -78,13 +85,15 @@ AttributeFetcher fetchFrom(Set no

[GitHub] [lucene-solr] iverase opened a new pull request #2155: LUCENE-9641: Support for spatial relationships in LatLonPoint

2020-12-17 Thread GitBox
iverase opened a new pull request #2155: URL: https://github.com/apache/lucene-solr/pull/2155 This PR adds the possibility of querying a LatLonPoint using the same spatial relationships supported by LatLonShape. In order to do that, I have rename ShapeQuery class to SpatialQuery and added

[jira] [Commented] (LUCENE-9640) Add TrackingQuery to track matching documents

2020-12-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251059#comment-17251059 ] Robert Muir commented on LUCENE-9640: - This sounds like yet another filter with all

[jira] [Commented] (SOLR-14981) Remove search results clustering contrib from 8x

2020-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251056#comment-17251056 ] ASF subversion and git services commented on SOLR-14981: Commit f

[jira] [Commented] (SOLR-15046) bin/solr check to see if solr.jetty.https.port should be set always returns true

2020-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251057#comment-17251057 ] ASF subversion and git services commented on SOLR-15046: Commit f

[GitHub] [lucene-solr] cpoerschke merged pull request #2149: Add two solr/CHANGES.txt entries for SOLR-14981 and SOLR-15046.

2020-12-17 Thread GitBox
cpoerschke merged pull request #2149: URL: https://github.com/apache/lucene-solr/pull/2149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [lucene-solr] iverase opened a new pull request #2154: LUCENE-9642: Rotate triangle points before checking triangle orientation

2020-12-17 Thread GitBox
iverase opened a new pull request #2154: URL: https://github.com/apache/lucene-solr/pull/2154 When encoding.a triangle we perform two actions: 1) Make sure that the orientation of the triangle is CCW 2) Place the point with minimum X in the first position so we might rotate the p

[GitHub] [lucene-solr] dweiss opened a new pull request #2153: A non-mergable PR with reformatted code.

2020-12-17 Thread GitBox
dweiss opened a new pull request #2153: URL: https://github.com/apache/lucene-solr/pull/2153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-12-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251038#comment-17251038 ] Dawid Weiss commented on LUCENE-9564: - I've added the infrastructure and will progre

[jira] [Commented] (LUCENE-9564) Format code automatically and enforce it

2020-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17251037#comment-17251037 ] ASF subversion and git services commented on LUCENE-9564: - Commi

[GitHub] [lucene-solr] dweiss merged pull request #1950: LUCENE-9564: add spotless and gjf.

2020-12-17 Thread GitBox
dweiss merged pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (LUCENE-9643) Create .git-blame-ignore-revs file with revisions that only apply reformatting

2020-12-17 Thread Dawid Weiss (Jira)
Dawid Weiss created LUCENE-9643: --- Summary: Create .git-blame-ignore-revs file with revisions that only apply reformatting Key: LUCENE-9643 URL: https://issues.apache.org/jira/browse/LUCENE-9643 Project:

[jira] [Resolved] (LUCENE-9571) Handle generated files (exclude from automated formatting)

2020-12-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9571. - Resolution: Invalid Will be reviewed on a package-by-package basis as we go committing reformatt

[jira] [Updated] (SOLR-15055) Re-implement 'withCollection' and 'maxShardsPerNode'

2020-12-17 Thread Andrzej Bialecki (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrzej Bialecki updated SOLR-15055: Description: Solr 8x replica placement provided two settings that are very useful in certai

[jira] [Created] (LUCENE-9642) TestXYShapeEncoding.testRandomPolygonEncoding failure

2020-12-17 Thread Ignacio Vera (Jira)
Ignacio Vera created LUCENE-9642: Summary: TestXYShapeEncoding.testRandomPolygonEncoding failure Key: LUCENE-9642 URL: https://issues.apache.org/jira/browse/LUCENE-9642 Project: Lucene - Core

[jira] [Created] (SOLR-15055) Re-implement 'withCollection' and 'maxShardsPerNode'

2020-12-17 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-15055: --- Summary: Re-implement 'withCollection' and 'maxShardsPerNode' Key: SOLR-15055 URL: https://issues.apache.org/jira/browse/SOLR-15055 Project: Solr Issue

[GitHub] [lucene-solr] trdillon opened a new pull request #2152: SOLR-14034: remove deprecated min_rf references

2020-12-17 Thread GitBox
trdillon opened a new pull request #2152: URL: https://github.com/apache/lucene-solr/pull/2152 # Description Remove min_rf and MIN_REPFACT references in code, tests and documentation. # Solution Incrementally remove min_rf and MIN_REPFACT references. #

[jira] [Commented] (LUCENE-9637) Clean up ShapeField /ShapeQuery random test

2020-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250913#comment-17250913 ] ASF subversion and git services commented on LUCENE-9637: - Commi

[jira] [Commented] (LUCENE-9637) Clean up ShapeField /ShapeQuery random test

2020-12-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17250911#comment-17250911 ] ASF subversion and git services commented on LUCENE-9637: - Commi