[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-04 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244429#comment-17244429 ] Tomoko Uchida commented on LUCENE-9623: --- {quote}exports are done manual {quote} Id

[GitHub] [lucene-solr] dweiss commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-04 Thread GitBox
dweiss commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-739139541 Thanks for satisfying my curiosity! This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (LUCENE-9623) Add module descriptor (module-info.java) to lucene jars

2020-12-04 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244424#comment-17244424 ] Tomoko Uchida commented on LUCENE-9623: --- As for tests, I think it might be a good

[jira] [Commented] (SOLR-14451) debug=query does not reliably ensure json.facet debug info returned in cloud clusters

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244423#comment-17244423 ] Munendra S N commented on SOLR-14451: - [^SOLR-14451.patch] Initial patch. Propagate

[jira] [Updated] (SOLR-14451) debug=query does not reliably ensure json.facet debug info returned in cloud clusters

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14451: Attachment: SOLR-14451.patch > debug=query does not reliably ensure json.facet debug info returned

[jira] [Commented] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244419#comment-17244419 ] Munendra S N commented on SOLR-10732: - [^SOLR-10732.patch] All tests are passing. I

[jira] [Updated] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-10732: Status: Patch Available (was: Open) > potential optimizations in callers of SolrIndexSearcher.numD

[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-04 Thread GitBox
zacharymorn commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r536531755 ## File path: lucene/misc/native/build.gradle ## @@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach { // is present. systemIncludes

[jira] [Updated] (SOLR-10732) potential optimizations in callers of SolrIndexSearcher.numDocs when docset is empty

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-10732: Attachment: SOLR-10732.patch > potential optimizations in callers of SolrIndexSearcher.numDocs when

[jira] [Updated] (SOLR-14514) json.facets: method:stream is incompatible with allBuckets:true

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14514: Status: Patch Available (was: Open) > json.facets: method:stream is incompatible with allBuckets:t

[jira] [Updated] (SOLR-12539) JSON Facet shorthand list syntax (Comma seperated list) doesn't trim leading/trailing spaces -- affects range "other" and "include" options (probably more)

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-12539: Status: Patch Available (was: Open) > JSON Facet shorthand list syntax (Comma seperated list) does

[jira] [Updated] (SOLR-12559) FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-12559: Status: Patch Available (was: Open) > FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when

[jira] [Updated] (SOLR-14950) schema api sometimes fails to replace-field-type

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14950: Status: Patch Available (was: Open) > schema api sometimes fails to replace-field-type > -

[jira] [Assigned] (SOLR-12559) FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-12559: --- Assignee: Munendra S N > FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subpars

[jira] [Commented] (SOLR-12559) FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244417#comment-17244417 ] Munendra S N commented on SOLR-12559: - [^SOLR-12559.patch] The patch handles the 1

[jira] [Updated] (SOLR-12559) FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are involved

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-12559: Attachment: SOLR-12559.patch > FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparse

[jira] [Commented] (SOLR-12539) JSON Facet shorthand list syntax (Comma seperated list) doesn't trim leading/trailing spaces -- affects range "other" and "include" options (probably more)

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244414#comment-17244414 ] Munendra S N commented on SOLR-12539: - [^SOLR-12539.patch] include, other and exclu

[jira] [Assigned] (SOLR-12539) JSON Facet shorthand list syntax (Comma seperated list) doesn't trim leading/trailing spaces -- affects range "other" and "include" options (probably more)

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-12539: --- Assignee: Munendra S N > JSON Facet shorthand list syntax (Comma seperated list) doesn't tri

[jira] [Updated] (SOLR-12539) JSON Facet shorthand list syntax (Comma seperated list) doesn't trim leading/trailing spaces -- affects range "other" and "include" options (probably more)

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-12539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-12539: Attachment: SOLR-12539.patch > JSON Facet shorthand list syntax (Comma seperated list) doesn't trim

[jira] [Commented] (SOLR-14514) json.facets: method:stream is incompatible with allBuckets:true

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244413#comment-17244413 ] Munendra S N commented on SOLR-14514: - [^SOLR-14514.patch] In the current patch, Fa

[jira] [Updated] (SOLR-14514) json.facets: method:stream is incompatible with allBuckets:true

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N updated SOLR-14514: Attachment: SOLR-14514.patch > json.facets: method:stream is incompatible with allBuckets:true > --

[jira] [Assigned] (SOLR-14514) json.facets: method:stream is incompatible with allBuckets:true

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14514: --- Assignee: Munendra S N > json.facets: method:stream is incompatible with allBuckets:true > -

[jira] [Commented] (SOLR-14950) schema api sometimes fails to replace-field-type

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244412#comment-17244412 ] Munendra S N commented on SOLR-14950: - During regeneration of copyFields, only fields

[GitHub] [lucene-solr] munendrasn opened a new pull request #2122: SOLR-14950: Fix copyfield regeneration with explicit src/dest matching dyn rule

2020-12-04 Thread GitBox
munendrasn opened a new pull request #2122: URL: https://github.com/apache/lucene-solr/pull/2122 CopyFields are regenerated in case of replace-field or replace-field-type. While regenerating, source and destination are checked against fields but source/dest could match dynamic rule to

[jira] [Assigned] (SOLR-14950) schema api sometimes fails to replace-field-type

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-14950: --- Assignee: Munendra S N > schema api sometimes fails to replace-field-type >

[jira] [Assigned] (SOLR-10860) in-place updates currently throw NumberFormatException instead of a Bad Request SolrException for bad input

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Munendra S N reassigned SOLR-10860: --- Assignee: Munendra S N (was: Ishan Chattopadhyaya) > in-place updates currently throw Numbe

[jira] [Commented] (SOLR-10860) in-place updates currently throw NumberFormatException instead of a Bad Request SolrException for bad input

2020-12-04 Thread Munendra S N (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244410#comment-17244410 ] Munendra S N commented on SOLR-10860: - I have rebased the patch against latest upstre

[GitHub] [lucene-solr] munendrasn opened a new pull request #2121: SOLR-10860: Return proper error code for bad input incase of inplace updates

2020-12-04 Thread GitBox
munendrasn opened a new pull request #2121: URL: https://github.com/apache/lucene-solr/pull/2121 Additionally, * Return proper error when inc operation is specified for non-numeric fields This is an automated message f

[jira] [Created] (SOLR-15033) 8x Smoke test fails missing clustering jar

2020-12-04 Thread Mike Drob (Jira)
Mike Drob created SOLR-15033: Summary: 8x Smoke test fails missing clustering jar Key: SOLR-15033 URL: https://issues.apache.org/jira/browse/SOLR-15033 Project: Solr Issue Type: Task Securi

[GitHub] [lucene-solr] madrob commented on a change in pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-04 Thread GitBox
madrob commented on a change in pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120#discussion_r53651 ## File path: solr/core/src/java/org/apache/solr/cloud/ZkShardTerms.java ## @@ -315,7 +312,8 @@ private boolean saveTerms(ShardTerms newTerms) throws

[GitHub] [lucene-solr] chatman commented on pull request #1963: SOLR-14827: Refactor schema loading to not use XPath

2020-12-04 Thread GitBox
chatman commented on pull request #1963: URL: https://github.com/apache/lucene-solr/pull/1963#issuecomment-739124443 Updated to latest master. This is an automated message from the Apache Git Service. To respond to the messag

[jira] [Comment Edited] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244359#comment-17244359 ] Uwe Schindler edited comment on LUCENE-9632 at 12/4/20, 11:52 PM:

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-04 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244359#comment-17244359 ] Uwe Schindler commented on LUCENE-9632: --- Not sure why you ask me, but the Tomorrow

[jira] [Commented] (SOLR-15029) Allow Shard Leader to give up leadership gracefully via shard terms

2020-12-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244347#comment-17244347 ] Mike Drob commented on SOLR-15029: -- Put up a draft PR for how I think this could work, i

[GitHub] [lucene-solr] madrob opened a new pull request #2120: SOLR-15029 More gracefully give up shard leadership

2020-12-04 Thread GitBox
madrob opened a new pull request #2120: URL: https://github.com/apache/lucene-solr/pull/2120 https://issues.apache.org/jira/browse/SOLR-15029 This is an automated message from the Apache Git Service. To respond to the message

[jira] [Updated] (SOLR-14965) Adding metrics to track size of Overseer queues

2020-12-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Smiley updated SOLR-14965: Fix Version/s: 8.8 Assignee: David Smiley Resolution: Fixed Status: Resol

[jira] [Commented] (SOLR-14965) Adding metrics to track size of Overseer queues

2020-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244335#comment-17244335 ] ASF subversion and git services commented on SOLR-14965: Commit 7

[jira] [Commented] (LUCENE-9599) Disable sort optimization in comparators on index sort

2020-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244321#comment-17244321 ] ASF subversion and git services commented on LUCENE-9599: - Commi

[GitHub] [lucene-solr] dsmiley merged pull request #2040: SOLR-14965 add overseer queue size metrics

2020-12-04 Thread GitBox
dsmiley merged pull request #2040: URL: https://github.com/apache/lucene-solr/pull/2040 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-14965) Adding metrics to track size of Overseer queues

2020-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244299#comment-17244299 ] ASF subversion and git services commented on SOLR-14965: Commit 1

[GitHub] [lucene-solr] sigram commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
sigram commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536361329 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java ## @@ -40,13 +40,23 @@ * * See {@lin

[jira] [Commented] (SOLR-14182) Move metric reporters config from solr.xml to ZK cluster properties

2020-12-04 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244271#comment-17244271 ] David Smiley commented on SOLR-14182: - +1 to everything Tomas said. > Move metric re

[GitHub] [lucene-solr] sigram commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
sigram commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536353469 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java ## @@ -17,15 +17,39 @@ package org.apache.solr.clust

[jira] [Resolved] (LUCENE-9599) Disable sort optimization in comparators on index sort

2020-12-04 Thread Mayya Sharipova (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova resolved LUCENE-9599. - Fix Version/s: 8.8 Resolution: Fixed > Disable sort optimization in comparators o

[jira] [Commented] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244199#comment-17244199 ] Mike Drob commented on LUCENE-9632: --- [~uschindler] - is there some historical subtlety

[jira] [Created] (LUCENE-9632) Replace our TimSort with JDK TimSort

2020-12-04 Thread Mike Drob (Jira)
Mike Drob created LUCENE-9632: - Summary: Replace our TimSort with JDK TimSort Key: LUCENE-9632 URL: https://issues.apache.org/jira/browse/LUCENE-9632 Project: Lucene - Core Issue Type: Improvemen

[GitHub] [lucene-solr] murblanc commented on pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#issuecomment-738942564 Looks good to me! This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [lucene-solr] saatchibhalla commented on pull request #2040: SOLR-14965 add overseer queue size metrics

2020-12-04 Thread GitBox
saatchibhalla commented on pull request #2040: URL: https://github.com/apache/lucene-solr/pull/2040#issuecomment-738939855 Thanks @dsmiley! Looks good to me. This is an automated message from the Apache Git Service. To respon

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536287423 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/RandomPlacementFactory.java ## @@ -0,0 +1,91 @@ +/* + * Licensed to the A

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536274851 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java ## @@ -40,13 +40,23 @@ * * See {@l

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536270908 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java ## @@ -40,13 +40,23 @@ * * See {@l

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536262348 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryLoader.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536262072 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryLoader.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536261667 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/impl/PlacementPluginFactoryLoader.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to th

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536257122 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java ## @@ -17,15 +17,39 @@ package org.apache.solr.clu

[GitHub] [lucene-solr] murblanc commented on a change in pull request #2101: SOLR-15016 Replica placement plugins should use container plugins API / configs

2020-12-04 Thread GitBox
murblanc commented on a change in pull request #2101: URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536256783 ## File path: solr/core/src/java/org/apache/solr/cluster/placement/PlacementPluginFactory.java ## @@ -17,15 +17,39 @@ package org.apache.solr.clu

[GitHub] [lucene-solr] gf2121 commented on pull request #2113: LUCENE-9629: Use computed masks

2020-12-04 Thread GitBox
gf2121 commented on pull request #2113: URL: https://github.com/apache/lucene-solr/pull/2113#issuecomment-738901135 @dweiss Thank you very much for the guiding of how to do a benchmark on Lucene, the lueneutil tool is really nice! I repeatedly execute the wikimedium1m 20 times, the foll

[jira] [Commented] (LUCENE-9629) Use computed mask values in ForUtil

2020-12-04 Thread Feng Guo (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244139#comment-17244139 ] Feng Guo commented on LUCENE-9629: -- [~jpountz] Thank you very much! > Use computed mas

[GitHub] [lucene-solr] heqianw closed pull request #2119: Added support to download index folders from gcs url

2020-12-04 Thread GitBox
heqianw closed pull request #2119: URL: https://github.com/apache/lucene-solr/pull/2119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (SOLR-15029) Allow Shard Leader to give up leadership gracefully via shard terms

2020-12-04 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244119#comment-17244119 ] Mike Drob commented on SOLR-15029: -- The existing code for increasing shard terms works w

[GitHub] [lucene-solr] heqianw opened a new pull request #2119: Added support to download index folders from gcs url

2020-12-04 Thread GitBox
heqianw opened a new pull request #2119: URL: https://github.com/apache/lucene-solr/pull/2119 Added support in luke to read from GCS URI. Downloads the file/folder locally and points the resulting browse path that location. To use: verify that BUCKET_NAME and project_id are properly

[jira] [Commented] (LUCENE-9599) Disable sort optimization in comparators on index sort

2020-12-04 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-9599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244006#comment-17244006 ] ASF subversion and git services commented on LUCENE-9599: - Commi

[GitHub] [lucene-solr] mayya-sharipova merged pull request #2117: LUCENE-9599 Disable sort optim on index sort

2020-12-04 Thread GitBox
mayya-sharipova merged pull request #2117: URL: https://github.com/apache/lucene-solr/pull/2117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Updated] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-04 Thread Pieter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pieter updated SOLR-15031: -- Description: When parsing a sub query in a function query, {{FunctionQParser#parseValueSource}} does not check

[jira] [Commented] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-04 Thread Pieter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243910#comment-17243910 ] Pieter commented on SOLR-15031: --- FYI; the reproduction query is a bit silly, but this is ju

[jira] [Comment Edited] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-04 Thread Pieter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243908#comment-17243908 ] Pieter edited comment on SOLR-15031 at 12/4/20, 10:01 AM: -- [PR|h

[jira] [Commented] (SOLR-15031) NPE caused by FunctionQParser returning a null ValueSource

2020-12-04 Thread Pieter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243908#comment-17243908 ] Pieter commented on SOLR-15031: --- PR fixing this has been created. > NPE caused by Function

[GitHub] [lucene-solr] vonbox opened a new pull request #2118: SOLR-15031: Prevent null being wrapped in a QueryValueSource

2020-12-04 Thread GitBox
vonbox opened a new pull request #2118: URL: https://github.com/apache/lucene-solr/pull/2118 # Description When parsing a sub query in a function query, FunctionQParser#parseValueSource does not check if the produced query object is null. When it is, it just wraps a null in a QueryV

[GitHub] [lucene-solr] dweiss commented on a change in pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory

2020-12-04 Thread GitBox
dweiss commented on a change in pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#discussion_r535921190 ## File path: lucene/misc/native/build.gradle ## @@ -51,11 +47,7 @@ tasks.withType(CppCompile).configureEach { // is present. systemIncludes.from