murblanc commented on a change in pull request #2101:
URL: https://github.com/apache/lucene-solr/pull/2101#discussion_r536274851
##########
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/MinimizeCoresPlacementFactory.java
##########
@@ -40,13 +40,23 @@
*
* <p>See {@link AffinityPlacementFactory} for a more realistic example and
documentation.</p>
*/
-public class MinimizeCoresPlacementFactory implements PlacementPluginFactory {
+public class MinimizeCoresPlacementFactory implements
PlacementPluginFactory<PlacementPluginFactory.NoConfig> {
@Override
- public PlacementPlugin createPluginInstance(PlacementPluginConfig config) {
+ public PlacementPlugin createPluginInstance() {
return new MinimizeCoresPlacementPlugin();
}
+ @Override
+ public void configure(NoConfig cfg) {
+ // no-op
+ }
+
+ @Override
+ public NoConfig getConfig() {
Review comment:
Maybe similarly here, `PlacementPluginFactory` should provide a default
implementation returning `NoConfig.INSTANCE` given that out of 4
implementations of the interface, only one returns something else
(`AffinityPlacementFactory`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
