[ 
https://issues.apache.org/jira/browse/SOLR-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244417#comment-17244417
 ] 

Munendra S N commented on SOLR-12559:
-------------------------------------

 [^SOLR-12559.patch] 
The patch handles the 1 level dereferenced case like {{min($my_field)}} with 
my_field=some_s but doesn't handle cases like {{min($my_field)}} with 
my_field=some_s and some_s=actual_field.

> FunctionQParser.FLAG_USE_FIELDNAME_SOURCE doesn't work when subparsers are 
> involved
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-12559
>                 URL: https://issues.apache.org/jira/browse/SOLR-12559
>             Project: Solr
>          Issue Type: Bug
>          Components: Facet Module
>            Reporter: Chris M. Hostetter
>            Priority: Major
>         Attachments: SOLR-12559.patch
>
>
> While working on a patch dealing with json facet syntax parsing, i was trying 
> to write a test verifying the equivalence of 2 json facet requests that 
> should be identical and discovered that when SOLR-10613 was implemented to 
> defer the parsing of field names via {{FieldNameValueSource}} the 
> implementation did not account for the invocation of sub parsers via param 
> references.
> specifically -- this json facet request will produce two AggValueSources 
> which are not {{equals()}}...
> {noformat}
> curl http://localhost:8983/solr/query -d 'q=*:*&my_field=foo_i&
> json.facet={
>   x : "min(foo_i)",
>   y : "min($my_field)"
> }'
> {noformat}
> "x" uses {{FieldNameValueSource}} while "y" directly uses an 
> {{IntValueSource}}
> (It's not immediately obvious to me if this currently causes any user visible 
> bugs or performance hicups, but it will definitely be problematic for users 
> once we add support for {{min(multivalued_field_i)}} )



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to