noblepaul merged pull request #1635:
URL: https://github.com/apache/lucene-solr/pull/1635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150742#comment-17150742
]
ASF subversion and git services commented on SOLR-14610:
Commit 0
[
https://issues.apache.org/jira/browse/SOLR-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150723#comment-17150723
]
ASF subversion and git services commented on SOLR-10742:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-10742.
---
Fix Version/s: 8.7
Resolution: Fixed
> SolrCores.getNamesForCore is quite inefficient
[
https://issues.apache.org/jira/browse/SOLR-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150722#comment-17150722
]
ASF subversion and git services commented on SOLR-10742:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150613#comment-17150613
]
Lucene/Solr QA commented on SOLR-14569:
---
| (/) *{color:green}+1 overall{color}* |
\
zhaih edited a comment on pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#issuecomment-653223245
Erick:
Thanks for clarifying it!
However I think it's an existing code lies in current mainline that cause
this warning(but not code change in this PR):
https:
zhaih commented on pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#issuecomment-653223245
Eric:
Thanks for clarifying it!
However I think it's an existing code lies in current mainline that cause
this warning(but not code change in this PR):
https://github
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150582#comment-17150582
]
Dawid Weiss commented on SOLR-13308:
A rule is pretty simple, really. Look at the int
[
https://issues.apache.org/jira/browse/SOLR-14618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh resolved SOLR-14618.
Fix Version/s: 8.6
Resolution: Fixed
Fixed with commit d24bdd9cfb306a79d579485f3e2a2
epugh merged pull request #1642:
URL: https://github.com/apache/lucene-solr/pull/1642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dsmiley commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r449248769
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +508,31 @@ public void handleRequestBody(SolrQuery
s1monw commented on pull request #1623:
URL: https://github.com/apache/lucene-solr/pull/1623#issuecomment-653203756
this assertion checks that we don't hold the full flush lock. I am trying to
remember why I added this assertion. I understand the assertion above which
also has a comment bu
[
https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Isabelle Giguere updated SOLR-14569:
Status: Patch Available (was: Open)
> Configuring a shardHandlerFactory on the /select req
[
https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150553#comment-17150553
]
Isabelle Giguere commented on SOLR-14569:
-
Attached a patch with a fix.
This patc
David Smiley created SOLR-14619:
---
Summary: Avoid needless calls to SolrIndexSearcher.getDocSet(query)
Key: SOLR-14619
URL: https://issues.apache.org/jira/browse/SOLR-14619
Project: Solr
Issue T
dsmiley opened a new pull request #1643:
URL: https://github.com/apache/lucene-solr/pull/1643
There are places where we get a DocSet from a query when we don't need to.
Also, improved DocSet.getTopFilter to implement DocSetProducer so as to
avoid possible re-construction of the DocSet.
epugh opened a new pull request #1642:
URL: https://github.com/apache/lucene-solr/pull/1642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
[
https://issues.apache.org/jira/browse/SOLR-14569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Isabelle Giguere updated SOLR-14569:
Attachment: SOLR-14569.patch
> Configuring a shardHandlerFactory on the /select requestHand
David Eric Pugh created SOLR-14618:
--
Summary: Using Solrj Refguide Page doesn't link to
ConcurrentUpdateHttp2SolrClient properly
Key: SOLR-14618
URL: https://issues.apache.org/jira/browse/SOLR-14618
[
https://issues.apache.org/jira/browse/SOLR-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh resolved SOLR-14358.
Fix Version/s: 8.6
Assignee: David Eric Pugh
Resolution: Fixed
> Comment to
[
https://issues.apache.org/jira/browse/SOLR-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh reopened SOLR-14422:
Wrong JIRA.
> Solr 8.5 Admin UI shows Angular placeholders on first load / refresh
> -
[
https://issues.apache.org/jira/browse/SOLR-14422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Eric Pugh updated SOLR-14422:
---
Fix Version/s: 8.6
Assignee: David Eric Pugh
Resolution: Resolved
S
ErickErickson commented on pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#issuecomment-653180860
Patrick:
This is a relatively recent change (failing on unsuppressed warnings).
The preferred solution is to to type the list, e.g.
List lst = new A
[
https://issues.apache.org/jira/browse/SOLR-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150540#comment-17150540
]
ASF subversion and git services commented on SOLR-14358:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150538#comment-17150538
]
ASF subversion and git services commented on SOLR-14358:
Commit 6
[
https://issues.apache.org/jira/browse/SOLR-14358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150537#comment-17150537
]
ASF subversion and git services commented on SOLR-14358:
Commit b
epugh merged pull request #1632:
URL: https://github.com/apache/lucene-solr/pull/1632
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
zhaih commented on pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#issuecomment-653170259
Rebased to master and gradle precommit failed because of following warning
(which becomes error since `-Werror specified`):
>
/home/runner/work/lucene-solr/lucene-solr/solr
zhaih commented on a change in pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#discussion_r449200188
##
File path:
lucene/expressions/src/java/org/apache/lucene/expressions/CachingExpressionValueSource.java
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the A
dsmiley commented on pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#issuecomment-653150307
Lets use JIRA ( LUCENE-9379 ) to discuss higher level concerns and GitHub
code reviews for code details.
Th
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150465#comment-17150465
]
ASF subversion and git services commented on SOLR-14022:
Commit e
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150467#comment-17150467
]
ASF subversion and git services commented on SOLR-14022:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150466#comment-17150466
]
ASF subversion and git services commented on SOLR-14066:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150464#comment-17150464
]
ASF subversion and git services commented on SOLR-14066:
Commit e
gerlowskija commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r449163848
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -500,6 +508,31 @@ public void handleRequestBody(SolrQ
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson resolved SOLR-13308.
---
Resolution: Fixed
Chris:
You nailed it, I didn't understand how "around" works
I wasn't clea
[
https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150443#comment-17150443
]
David Smiley commented on SOLR-14597:
-
Can you post a comment on class names you prop
[
https://issues.apache.org/jira/browse/SOLR-14597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150438#comment-17150438
]
Gus Heck commented on SOLR-14597:
-
This thought has occurred to me, but the coordination
dsmiley commented on a change in pull request #1626:
URL: https://github.com/apache/lucene-solr/pull/1626#discussion_r449135773
##
File path: solr/solr-ref-guide/src/index.adoc
##
@@ -10,6 +10,7 @@
streaming-expressions, \
solrcloud, \
legacy-scaling-and-distribu
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150428#comment-17150428
]
Dawid Weiss commented on SOLR-13308:
For what it's worth, the overhead of a rule vs.
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150421#comment-17150421
]
Chris M. Hostetter commented on SOLR-13308:
---
bq. It looks like you already did
mikemccand commented on a change in pull request #1613:
URL: https://github.com/apache/lucene-solr/pull/1613#discussion_r449117471
##
File path:
lucene/expressions/src/java/org/apache/lucene/expressions/CachingExpressionValueSource.java
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-14588:
Fix Version/s: master (9.0)
Affects Version/s: (was: master (9.0))
Don't use "Affects V
[
https://issues.apache.org/jira/browse/SOLR-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150394#comment-17150394
]
David Smiley commented on SOLR-10742:
-
> I'm going to remove getNamesForCores and all
[
https://issues.apache.org/jira/browse/SOLR-14537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150389#comment-17150389
]
ASF subversion and git services commented on SOLR-14537:
Commit 1
[
https://issues.apache.org/jira/browse/SOLR-10742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150385#comment-17150385
]
Erick Erickson commented on SOLR-10742:
---
I chatted with [~ab] and he doesn't object
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150353#comment-17150353
]
ASF subversion and git services commented on SOLR-14561:
Commit 2
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150271#comment-17150271
]
Erick Erickson edited comment on SOLR-13308 at 7/2/20, 2:52 PM:
---
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150337#comment-17150337
]
Ishan Chattopadhyaya commented on SOLR-14066:
-
bq. That text is outdated I gu
[
https://issues.apache.org/jira/browse/SOLR-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150324#comment-17150324
]
Yaswanth commented on SOLR-14575:
-
Can I get an update or atleast a work around for this
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150288#comment-17150288
]
ASF subversion and git services commented on SOLR-14561:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150291#comment-17150291
]
ASF subversion and git services commented on SOLR-14561:
Commit a
[
https://issues.apache.org/jira/browse/SOLR-14561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150285#comment-17150285
]
ASF subversion and git services commented on SOLR-14561:
Commit c
janhoy merged pull request #1641:
URL: https://github.com/apache/lucene-solr/pull/1641
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150281#comment-17150281
]
Jan Høydahl commented on SOLR-14066:
That text is outdated I guess, since you already
janhoy commented on a change in pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#discussion_r449000598
##
File path:
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java
##
@@ -510,14 +510,18 @@ public void handleRequestBody(SolrQuery
[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150271#comment-17150271
]
Erick Erickson commented on SOLR-13308:
---
[~hoss...@fucit.org] It looks like you alr
janhoy commented on a change in pull request #1641:
URL: https://github.com/apache/lucene-solr/pull/1641#discussion_r448984282
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -85,11 +85,18 @@ For more information about how to use this, see the section
<>. W
janhoy commented on a change in pull request #1641:
URL: https://github.com/apache/lucene-solr/pull/1641#discussion_r448982135
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -85,11 +85,18 @@ For more information about how to use this, see the section
<>. W
janhoy opened a new pull request #1641:
URL: https://github.com/apache/lucene-solr/pull/1641
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150210#comment-17150210
]
Michael Sokolov commented on LUCENE-9286:
-
> I noticed JapaneseAnalyzer perf tes
[
https://issues.apache.org/jira/browse/LUCENE-9286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150197#comment-17150197
]
Tomoko Uchida commented on LUCENE-9286:
---
For status update:
I noticed JapaneseAna
Ishan Chattopadhyaya created SOLR-14617:
---
Summary: Remove DIH from 9.0
Key: SOLR-14617
URL: https://issues.apache.org/jira/browse/SOLR-14617
Project: Solr
Issue Type: Sub-task
Affec
[
https://issues.apache.org/jira/browse/SOLR-14617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya reassigned SOLR-14617:
---
Assignee: Ishan Chattopadhyaya
> Remove DIH from 9.0
> ---
>
Ishan Chattopadhyaya created SOLR-14616:
---
Summary: Remove CDCR from 9.0
Key: SOLR-14616
URL: https://issues.apache.org/jira/browse/SOLR-14616
Project: Solr
Issue Type: Sub-task
Affe
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150191#comment-17150191
]
Ishan Chattopadhyaya edited comment on SOLR-14066 at 7/2/20, 11:14 AM:
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150191#comment-17150191
]
Ishan Chattopadhyaya commented on SOLR-14066:
-
[~janhoy], would you like to s
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya resolved SOLR-14066.
-
Resolution: Fixed
Thanks everyone. I'll proceed to create a subtask of SOLR-13138
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150188#comment-17150188
]
ASF subversion and git services commented on SOLR-14066:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150187#comment-17150187
]
ASF subversion and git services commented on SOLR-14066:
Commit 7
[
https://issues.apache.org/jira/browse/SOLR-14066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150189#comment-17150189
]
ASF subversion and git services commented on SOLR-14066:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya resolved SOLR-14022.
-
Resolution: Fixed
Thanks to everyone. I'll proceed to remove it from master in a
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150185#comment-17150185
]
ASF subversion and git services commented on SOLR-14022:
Commit d
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150184#comment-17150184
]
ASF subversion and git services commented on SOLR-14022:
Commit b
[
https://issues.apache.org/jira/browse/SOLR-14022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150183#comment-17150183
]
ASF subversion and git services commented on SOLR-14022:
Commit 7
gerlowskija commented on pull request #1574:
URL: https://github.com/apache/lucene-solr/pull/1574#issuecomment-652934406
> All I would request is for users to be able to provide their own
request-id which should disable the auto-generation of request id inside solr
if present
This i
rmuir commented on pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#issuecomment-652931712
I'm -1 to this approach because it breaks the use of the OS cache (I stated
this on the JIRA issue, it was ignored, I don't want anyone to forget).
Because we use the os
[
https://issues.apache.org/jira/browse/SOLR-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150121#comment-17150121
]
Jan Høydahl commented on SOLR-6152:
---
This is great. My comments:
* Can you add to the p
[
https://issues.apache.org/jira/browse/LUCENE-9416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150086#comment-17150086
]
Mohammad Sadiq commented on LUCENE-9416:
Thank you [~mikemccand] ! I'll work on
juanka588 commented on a change in pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r448853099
##
File path:
lucene/core/src/java/org/apache/lucene/util/crypto/AesCtrEncrypter.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software F
juanka588 commented on a change in pull request #1608:
URL: https://github.com/apache/lucene-solr/pull/1608#discussion_r448853099
##
File path:
lucene/core/src/java/org/apache/lucene/util/crypto/AesCtrEncrypter.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software F
Atri Sharma created SOLR-14615:
--
Summary: CPU Based Circuit Breaker
Key: SOLR-14615
URL: https://issues.apache.org/jira/browse/SOLR-14615
Project: Solr
Issue Type: Improvement
Security Lev
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Atri Sharma resolved SOLR-14588.
Resolution: Fixed
> Circuit Breakers Infrastructure and Real JVM Based Circuit Breaker
> --
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149998#comment-17149998
]
ASF subversion and git services commented on SOLR-14588:
Commit 3
[
https://issues.apache.org/jira/browse/SOLR-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1714#comment-1714
]
ASF subversion and git services commented on SOLR-14588:
Commit 3
atris merged pull request #1626:
URL: https://github.com/apache/lucene-solr/pull/1626
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
87 matches
Mail list logo
