[
https://issues.apache.org/jira/browse/SOLR-13308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17150582#comment-17150582
]
Dawid Weiss commented on SOLR-13308:
------------------------------------
A rule is pretty simple, really. Look at the interface:
[https://junit.org/junit4/javadoc/4.12/org/junit/rules/TestRule.html]
There is essentially a Statement you wrap with your code (typically
before-after).
As for restoring *all* properties - this works in most cases but the rule's
code would have to have a permission to enumerate (and set) all properties. In
Lucene code the security manager prevents that so only a subset of properties
can be set/ reset (and you need to know these by name).
> Move SystemPropertiesRestoreRule to SolrTestCase
> ------------------------------------------------
>
> Key: SOLR-13308
> URL: https://issues.apache.org/jira/browse/SOLR-13308
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 8.1, master (9.0)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
>
> [~krisden] just traced flaky HDFS tests to not clearing sysprops, see the
> discussion at SOLR-13297.
> Part of SOLR-13268 is to derive all Solr test classes from SolrTestCase.
> Once that's pushed, does it make sense to put that rule in SolrTestCase so it
> gets performed automagically so this kind of error doesn't creep back in?
> I don't know the details of how that rule is implemented or whether this
> makes sense at that level but wanted to discuss.
> I've assigned it to myself, but that's just so I don't lose track of it, but
> anyone else who wants to pick it up please feel free.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
