RussellSpitzer commented on code in PR #11346:
URL: https://github.com/apache/iceberg/pull/11346#discussion_r1815721238
##
kafka-connect/kafka-connect/src/test/java/org/apache/iceberg/connect/data/RecordConverterTest.java:
##
@@ -921,11 +948,26 @@ private void assertRecordValues
aokolnychyi commented on code in PR #11238:
URL: https://github.com/apache/iceberg/pull/11238#discussion_r1815638886
##
format/puffin-spec.md:
##
@@ -123,6 +123,57 @@ The blob metadata for this blob may include following
properties:
- `ndv`: estimate of number of distinct va
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815764535
##
format/spec.md:
##
@@ -1297,54 +1308,56 @@ Example
This serialization scheme is for storing single values as individual binary
values in the lower and upper bou
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815755187
##
format/spec.md:
##
@@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and
logical type annotations
Lists must use the [3-level
represen
aihuaxu commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1816076539
##
format/spec.md:
##
@@ -1025,28 +1033,29 @@ Values should be stored in Parquet using the types and
logical type annotations
Lists must use the [3-level
represe
mdub commented on issue #9898:
URL: https://github.com/apache/iceberg/issues/9898#issuecomment-2436981886
I've also been experimenting with Bloom filters, and managed to get it
working fairly easily with a nested field:
```
ALTER TABLE glue_catalog.kafka_archive.test_topic
SET T
huaxingao commented on PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#issuecomment-2436567828
also cc @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816020709
##
format/spec.md:
##
@@ -619,19 +627,25 @@ Data files that match the query filter must be read by
the scan.
Note that for any snapshot, all file paths marked w
nastra commented on code in PR #11282:
URL: https://github.com/apache/iceberg/pull/11282#discussion_r1816081112
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
pvary commented on code in PR #11144:
URL: https://github.com/apache/iceberg/pull/11144#discussion_r1816081581
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Fo
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816032805
##
format/spec.md:
##
@@ -841,19 +855,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
pvary commented on code in PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#discussion_r1816085856
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkPlannedAvroReader.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation (A
jbonofre commented on code in PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#discussion_r1816086840
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/data/FlinkPlannedAvroReader.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software Foundation
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816030939
##
format/spec.md:
##
@@ -982,19 +998,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816028652
##
format/spec.md:
##
@@ -982,19 +998,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816028948
##
format/spec.md:
##
@@ -841,19 +855,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815717333
##
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##
@@ -323,11 +345,15 @@ private ManifestFile filterManifest(Schema tableSchema,
Manife
rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815699418
##
format/spec.md:
##
@@ -841,19 +855,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-level del
amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815725679
##
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##
@@ -185,6 +200,13 @@ List filterManifests(Schema tableSchema,
List manife
ret
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816020709
##
format/spec.md:
##
@@ -619,19 +627,25 @@ Data files that match the query filter must be read by
the scan.
Note that for any snapshot, all file paths marked w
zhongyujiang commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2436873425
Hey @amogh-jahagirdar @Fokko @nastra @danielcweeks, can you help review this
when you have time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816024185
##
open-api/rest-catalog-open-api.py:
##
@@ -854,6 +854,16 @@ class ContentFile(BaseModel):
class PositionDeleteFile(ContentFile):
content: Literal['posit
danielcweeks commented on code in PR #11282:
URL: https://github.com/apache/iceberg/pull/11282#discussion_r1815557030
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816028652
##
format/spec.md:
##
@@ -982,19 +998,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816033846
##
open-api/rest-catalog-open-api.yaml:
##
@@ -4202,6 +4203,14 @@ components:
content:
type: string
enum: [ "position-deletes" ]
+
danielcweeks commented on code in PR #11282:
URL: https://github.com/apache/iceberg/pull/11282#discussion_r1815372401
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
danielcweeks commented on code in PR #11093:
URL: https://github.com/apache/iceberg/pull/11093#discussion_r1815793488
##
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/TestBaseWithCatalog.java:
##
@@ -59,18 +70,45 @@ protected static Object[][] parameters() {
}
gaborkaszab commented on PR #10995:
URL: https://github.com/apache/iceberg/pull/10995#issuecomment-2435425999
Hi @nastra ,
Do you disagree with my reasoning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
rdblue commented on PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2436457711
Oops. I didn't mean to close this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815807981
##
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestExpireSnapshotsProcedure.java:
##
@@ -294,8 +294,8 @@ public void testEx
aihuaxu opened a new pull request, #10831:
URL: https://github.com/apache/iceberg/pull/10831
Help: #10392
Spec: add variant type
Proposal:
https://docs.google.com/document/d/1QjhpG_SVNPZh3anFcpicMQx90ebwjL7rmzFYfUP89Iw/edit
This is to layout the spec for variant type. T
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1816028652
##
format/spec.md:
##
@@ -982,19 +998,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-leve
rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815696952
##
format/spec.md:
##
@@ -585,13 +591,19 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | _optional_ |
rdblue commented on code in PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#discussion_r1815771516
##
format/spec.md:
##
@@ -1297,54 +1308,56 @@ Example
This serialization scheme is for storing single values as individual binary
values in the lower and upper bou
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815795425
##
api/src/test/java/org/apache/iceberg/TestAccessors.java:
##
@@ -247,4 +252,70 @@ public void testEmptySchema() {
Schema emptySchema = new Schema();
assert
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815795425
##
api/src/test/java/org/apache/iceberg/TestAccessors.java:
##
@@ -247,4 +252,70 @@ public void testEmptySchema() {
Schema emptySchema = new Schema();
assert
rdblue commented on code in PR #11324:
URL: https://github.com/apache/iceberg/pull/11324#discussion_r1815788236
##
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##
@@ -534,6 +534,7 @@ private static int estimateSize(Type type) {
case FIXED:
return ((T
rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815700879
##
format/spec.md:
##
@@ -52,6 +52,8 @@ Version 3 of the Iceberg spec extends data types and existing
metadata structure
* Default value support for columns
* Multi
github-actions[bot] commented on PR #10090:
URL: https://github.com/apache/iceberg/pull/10090#issuecomment-2436555213
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pul
manuzhang commented on PR #11157:
URL: https://github.com/apache/iceberg/pull/11157#issuecomment-2436574881
`ExecutorService` is used to parallelize reading files to build manifests on
the Spark executors for Spark table migration procedures (`add_files`,
`migrate`, `snapshot`).
--
This
manuzhang commented on PR #10774:
URL: https://github.com/apache/iceberg/pull/10774#issuecomment-2436665300
@RussellSpitzer Could you please take another look? It might be valuable to
be included in 1.7 since it's a long-standing issue.
--
This is an automated message from the Apache Git
ajantha-bhat commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2436946836
@danielcweeks: Thanks for the review. Conflict was due to recent row-lineage
merge. I have resolved it now. PR is ready.
--
This is an automated message from the Apache Git Serv
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815439191
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
nastra commented on PR #11349:
URL: https://github.com/apache/iceberg/pull/11349#issuecomment-2435503742
thanks @sullis, this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
rdblue commented on PR #10831:
URL: https://github.com/apache/iceberg/pull/10831#issuecomment-2436457533
@aihuaxu, I think there are a couple of things missing:
* The Avro appendix should be updated to state that a Variant is stored as a
Record with two fields, a required binary `metadata
rdblue closed pull request #10831: Spec: add variant type
URL: https://github.com/apache/iceberg/pull/10831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
RussellSpitzer commented on code in PR #11372:
URL: https://github.com/apache/iceberg/pull/11372#discussion_r1815455196
##
core/src/test/java/org/apache/iceberg/deletes/TestRoaringPositionBitmap.java:
##
@@ -0,0 +1,516 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
manuzhang commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814618649
##
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##
@@ -68,6 +68,7 @@ public class IcebergPigInputFormat extends
InputFormat {
private Li
singhpk234 commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815553135
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
jbonofre commented on PR #11380:
URL: https://github.com/apache/iceberg/pull/11380#issuecomment-2435229884
@ajantha-bhat done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
bknbkn commented on PR #11387:
URL: https://github.com/apache/iceberg/pull/11387#issuecomment-2435252649
cc @Fokko @nastra @amogh-jahagirdar Do you have time to help review it?
Thank you very much.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
nastra merged PR #11281:
URL: https://github.com/apache/iceberg/pull/11281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
kevinjqliu commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2436245388
on testing, it would be great to include an integration test with a Spark
Iceberg view
--
This is an automated message from the Apache Git Service.
To respond to the message,
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815639704
##
format/spec.md:
##
@@ -52,6 +52,8 @@ Version 3 of the Iceberg spec extends data types and existing
metadata structure
* Default value support for columns
*
aokolnychyi commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815647540
##
format/spec.md:
##
@@ -585,13 +591,19 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | _option
ajantha-bhat commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814838380
##
pig/src/main/java/org/apache/iceberg/pig/PigParquetReader.java:
##
@@ -60,9 +60,20 @@
import org.apache.pig.data.DataByteArray;
import org.apache.pig.data.T
bennychow commented on code in PR #11365:
URL: https://github.com/apache/iceberg/pull/11365#discussion_r1814329132
##
format/view-spec.md:
##
@@ -97,7 +97,10 @@ Summary is a string to string map of metadata about a view
version. Common metad
View definitions can be represent
nastra commented on code in PR #11349:
URL: https://github.com/apache/iceberg/pull/11349#discussion_r1814324603
##
aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
pvary commented on code in PR #11144:
URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814725764
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/TableMaintenance.java:
##
@@ -0,0 +1,318 @@
+/*
+ * Licensed to the Apache Software Foundati
jbonofre commented on PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#issuecomment-2435789965
The problem seems to be related to:
```
java.lang.ClassCastException: class java.lang.String cannot be cast to class
org.apache.flink.table.data.StringData (java.lang.String i
rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815695732
##
format/spec.md:
##
@@ -585,13 +591,19 @@ The schema of a manifest file is a struct called
`manifest_entry` with the follo
| _optional_ | _optional_ | _optional_ |
danielcweeks commented on code in PR #11282:
URL: https://github.com/apache/iceberg/pull/11282#discussion_r1815433195
##
gcp/src/main/java/org/apache/iceberg/gcp/gcs/OAuth2RefreshCredentialsHandler.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (AS
RussellSpitzer commented on PR #10829:
URL: https://github.com/apache/iceberg/pull/10829#issuecomment-2435891998
Reminder to @danielcweeks + @bryanck to finalize reviews on this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815446522
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
RussellSpitzer commented on code in PR #11372:
URL: https://github.com/apache/iceberg/pull/11372#discussion_r1815375952
##
core/src/main/java/org/apache/iceberg/deletes/RoaringPositionBitmap.java:
##
@@ -0,0 +1,317 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
RussellSpitzer commented on code in PR #11372:
URL: https://github.com/apache/iceberg/pull/11372#discussion_r1815344311
##
core/src/main/java/org/apache/iceberg/deletes/RoaringPositionBitmap.java:
##
@@ -0,0 +1,309 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
zeroshade commented on issue #183:
URL: https://github.com/apache/iceberg-go/issues/183#issuecomment-2435645016
I'd have to think about it a bit as far as recommending a path. But I would
definitely see this as within the scope of this implementation if we can come
up with a good/useful way
jbonofre commented on PR #11386:
URL: https://github.com/apache/iceberg/pull/11386#issuecomment-2435037863
It seems the upsert test is stale. I'm investigating (maybe the schema type
mapping).
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
pvary commented on code in PR #11144:
URL: https://github.com/apache/iceberg/pull/11144#discussion_r1814746167
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/ExpireSnapshots.java:
##
@@ -0,0 +1,124 @@
+/*
+ * Licensed to the Apache Software Foundatio
nastra merged PR #11349:
URL: https://github.com/apache/iceberg/pull/11349
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
kevinjqliu commented on PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#issuecomment-2436105637
thanks for the review @nastra. I've addressed your comments, please take
another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please
nastra commented on code in PR #11282:
URL: https://github.com/apache/iceberg/pull/11282#discussion_r1815083375
##
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##
@@ -43,6 +43,8 @@ public class GCPProperties implements Serializable {
public static final String
sullis commented on code in PR #11349:
URL: https://github.com/apache/iceberg/pull/11349#discussion_r1815134423
##
aws/src/test/java/org/apache/iceberg/aws/s3/MinioUtil.java:
##
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contr
RussellSpitzer commented on code in PR #11372:
URL: https://github.com/apache/iceberg/pull/11372#discussion_r1815332827
##
core/src/main/java/org/apache/iceberg/deletes/RoaringPositionBitmap.java:
##
@@ -0,0 +1,309 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
rdblue commented on code in PR #11240:
URL: https://github.com/apache/iceberg/pull/11240#discussion_r1815703373
##
format/spec.md:
##
@@ -841,19 +855,45 @@ Notes:
## Delete Formats
-This section details how to encode row-level deletes in Iceberg delete files.
Row-level del
uniqueinput commented on PR #766:
URL: https://github.com/apache/iceberg-python/pull/766#issuecomment-2436364333
It would be really great if this could make it into 0.8. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
jbonofre commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814846017
##
pig/src/main/java/org/apache/iceberg/pig/PigParquetReader.java:
##
@@ -60,9 +60,20 @@
import org.apache.pig.data.DataByteArray;
import org.apache.pig.data.Tuple
ajantha-bhat commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1814835999
##
pig/src/test/java/org/apache/iceberg/pig/SchemaUtilTest.java:
##
@@ -40,6 +40,10 @@
import org.apache.pig.impl.logicalLayer.FrontendException;
import org.ju
ajantha-bhat commented on PR #11380:
URL: https://github.com/apache/iceberg/pull/11380#issuecomment-2435071351
we can keep it in Draft since it is for 1.8.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gaborkaszab commented on PR #5837:
URL: https://github.com/apache/iceberg/pull/5837#issuecomment-2435424210
Hi @Fokko , @findepi ,
Is there anything I can do to make progress on this PR? The motivation is
clear, there is a need for this in a query engine, I think I could also address
the
danielcweeks commented on PR #11067:
URL: https://github.com/apache/iceberg/pull/11067#issuecomment-2436139576
@ajantha-bhat looks like we have conflicts. It would be good to get this
in, but I don't think this section of the docs is tied to the 1.7.0 release.
--
This is an automated mes
nastra commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815120386
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
nastra commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815120386
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,142 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
omkenge commented on PR #1239:
URL: https://github.com/apache/iceberg-python/pull/1239#issuecomment-2436191642
I successfully tested the code works fine for me ..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ajantha-bhat commented on code in PR #10810:
URL: https://github.com/apache/iceberg/pull/10810#discussion_r1814829769
##
site/docs/how-to-release.md:
##
@@ -270,6 +270,46 @@ git tag -am 'Release Apache Iceberg '
apache-iceberg- apache-i
Then release the candidate repository
c-thiel commented on PR #645:
URL: https://github.com/apache/iceberg-rust/pull/645#issuecomment-2435124830
Enum it is then. I'll refractor it by the end of this week.
Thanks @Xuanwo @liurenjie1024!
--
This is an automated message from the Apache Git Service.
To respond to the message, p
stevenzwu commented on code in PR #11144:
URL: https://github.com/apache/iceberg/pull/11144#discussion_r1815365314
##
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/maintenance/api/MaintenanceTaskBuilder.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Softwar
kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1815497159
##
core/src/test/java/org/apache/iceberg/TestSnapshotJson.java:
##
@@ -35,6 +40,58 @@ public class TestSnapshotJson {
public TableOperations ops = new LocalTa
singhpk234 commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815498305
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
nastra opened a new pull request, #11388:
URL: https://github.com/apache/iceberg/pull/11388
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
nastra merged PR #11339:
URL: https://github.com/apache/iceberg/pull/11339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap
jbonofre commented on PR #11380:
URL: https://github.com/apache/iceberg/pull/11380#issuecomment-2435044666
@manuzhang I did a more "agressive" pass on removing pig 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jbonofre commented on code in PR #10810:
URL: https://github.com/apache/iceberg/pull/10810#discussion_r1814941887
##
site/docs/how-to-release.md:
##
@@ -270,6 +270,46 @@ git tag -am 'Release Apache Iceberg '
apache-iceberg- apache-i
Then release the candidate repository in
nastra commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1815050273
##
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##
@@ -68,6 +72,7 @@ public class IcebergPigInputFormat extends
InputFormat {
private List
kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1815496440
##
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##
@@ -140,6 +142,8 @@ static Snapshot fromJson(JsonNode node) {
}
}
summary =
danielcweeks commented on code in PR #11389:
URL: https://github.com/apache/iceberg/pull/11389#discussion_r1815510702
##
aws/src/main/java/org/apache/iceberg/aws/s3/VendedCredentialsProvider.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
sdd commented on PR #680:
URL: https://github.com/apache/iceberg-rust/pull/680#issuecomment-2436022032
Sure, will do that now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
danielcweeks merged PR #10829:
URL: https://github.com/apache/iceberg/pull/10829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceb
bryanck commented on PR #10829:
URL: https://github.com/apache/iceberg/pull/10829#issuecomment-2436066226
Yes, definitely, I’ll follow up, hopefully with something to make it
automated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
jbonofre commented on code in PR #11379:
URL: https://github.com/apache/iceberg/pull/11379#discussion_r1815177268
##
pig/src/main/java/org/apache/iceberg/pig/IcebergPigInputFormat.java:
##
@@ -68,6 +72,7 @@ public class IcebergPigInputFormat extends
InputFormat {
private Lis
1 - 100 of 161 matches
Mail list logo
