amogh-jahagirdar commented on code in PR #11131:
URL: https://github.com/apache/iceberg/pull/11131#discussion_r1815725679
##########
core/src/main/java/org/apache/iceberg/ManifestFilterManager.java:
##########
@@ -185,6 +200,13 @@ List<ManifestFile> filterManifests(Schema tableSchema,
List<ManifestFile> manife
return ImmutableList.of();
}
+ // The current set of referenced manifests can be trusted if it is a
subset of the manifests
+ // being filtered. If a single referenced manifest is not in the set of
manifests being filtered
+ // this indicates that the referenced manifests are stale and cannot be
trusted.
+ Set<String> manifestLocations =
Review Comment:
I updated to remove the check to always rewrite a manifest just because it
had aged off deletes and no other reason to rewrite. This simplified a bit
since now a lot of the referenced sets checks could be done upfront a bit more
explicitly. See
https://github.com/apache/iceberg/pull/11131#discussion_r1815710103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
