kevinjqliu commented on code in PR #11354:
URL: https://github.com/apache/iceberg/pull/11354#discussion_r1815496440
##########
core/src/main/java/org/apache/iceberg/SnapshotParser.java:
##########
@@ -140,6 +142,8 @@ static Snapshot fromJson(JsonNode node) {
}
}
summary = builder.build();
+ Preconditions.checkArgument(
Review Comment:
I made the change, and the error message is now `Cannot parse missing
string: operation`
Does this message give enough context? Otherwise, I can use a Precondition
with a custom error message. I like `Invalid summary: operation missing`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
