a-agmon commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323262045
Hey @sdd, @FANNG1 and @liurenjie1024
Please see updated PR. I have refactored `predicate_converter` into a
separate module that follows a more visitor-ish approach.
The `scan`
ebyhr opened a new pull request, #11064:
URL: https://github.com/apache/iceberg/pull/11064
Fixes #10822
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
sdd commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323295148
Aah I see! That makes complete sense. So, what you are saying is, we do the
best we can to filter via metadata within iceberg, but whatever operations we
can't handle in iceberg will get a
github-actions[bot] commented on issue #7793:
URL: https://github.com/apache/iceberg/issues/7793#issuecomment-2323558124
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
kevinjqliu commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740179090
##
tests/integration/test_inspect_table.py:
##
@@ -672,126 +672,141 @@ def test_inspect_files(
# append more data
tbl.append(arrow_table_with_null)
kevinjqliu commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740179023
##
pyiceberg/table/__init__.py:
##
@@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_schem
github-actions[bot] closed issue #7793: Docs: Give Metadata Tables their Own
Page
URL: https://github.com/apache/iceberg/issues/7793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
github-actions[bot] commented on issue #7800:
URL: https://github.com/apache/iceberg/issues/7800#issuecomment-2323558146
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] closed issue #7819: Build: rebasing a fork triggers
redundant CI runs against master commits
URL: https://github.com/apache/iceberg/issues/7819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
manuzhang commented on PR #9888:
URL: https://github.com/apache/iceberg/pull/9888#issuecomment-2323761129
Closed in favor of #10935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
github-actions[bot] commented on issue #7822:
URL: https://github.com/apache/iceberg/issues/7822#issuecomment-2323558189
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
kevinjqliu commented on issue #1018:
URL:
https://github.com/apache/iceberg-python/issues/1018#issuecomment-2323378037
@ndrluis can this be closed now that #1096 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on issue #7707:
URL: https://github.com/apache/iceberg/issues/7707#issuecomment-2323557999
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1740062315
##
crates/catalog/sql/src/catalog.rs:
##
@@ -167,43 +177,312 @@ impl SqlCatalog {
.await
.map_err(from_sqlx_error)
}
+
+/// Ex
liurenjie1024 commented on PR #590:
URL: https://github.com/apache/iceberg-rust/pull/590#issuecomment-2323648111
cc @Xuanwo @Fokko PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
github-actions[bot] commented on issue #7819:
URL: https://github.com/apache/iceberg/issues/7819#issuecomment-2323558177
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
kevinjqliu commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740141923
##
mkdocs/docs/api.md:
##
@@ -844,6 +844,19 @@ readable_metrics: [
[6.0989]]
```
+
Review Comment:
with the new markdown linter (#1118), this might no
a-agmon commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323283411
you can see what I mean in this test case:
```rust
#[test]
fn test_predicate_conversion_with_unsupported_condition_or() {
let sql = "(foo > 1 and bar in ('tes
kevinjqliu commented on issue #1041:
URL:
https://github.com/apache/iceberg-python/issues/1041#issuecomment-2323380629
Oh interesting, thanks!
Here's the config definition for `write.data.path` and `write.metadata.path`
https://iceberg.apache.org/docs/latest/configuration/#write-prope
github-actions[bot] commented on issue #7737:
URL: https://github.com/apache/iceberg/issues/7737#issuecomment-2323558064
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
dependabot[bot] opened a new pull request, #138:
URL: https://github.com/apache/iceberg-go/pull/138
Bumps
[github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2)
from 1.17.29 to 1.17.30.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/a6e48aca89f21
manuzhang commented on code in PR #11065:
URL: https://github.com/apache/iceberg/pull/11065#discussion_r1740279743
##
site/docs/multi-engine-support.md:
##
@@ -93,7 +93,7 @@ Users should continuously upgrade their Flink version to stay
up-to-date.
| 1.17| Deprecated |
manuzhang closed pull request #9888: Core: Support IncrementalChangelogScan
with deletes
URL: https://github.com/apache/iceberg/pull/9888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
FANNG1 commented on code in PR #594:
URL: https://github.com/apache/iceberg-rust/pull/594#discussion_r1740085143
##
crates/examples/src/datafusion_read_data.rs:
##
@@ -0,0 +1,37 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
github-actions[bot] commented on PR #7833:
URL: https://github.com/apache/iceberg/pull/7833#issuecomment-2323558211
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
soumya-ghosh commented on PR #1057:
URL: https://github.com/apache/iceberg-python/pull/1057#issuecomment-2323414028
Yep, closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
github-actions[bot] commented on PR #7790:
URL: https://github.com/apache/iceberg/pull/7790#issuecomment-2323558103
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
ZENOTME opened a new issue, #596:
URL: https://github.com/apache/iceberg-rust/issues/596
This will work for now but might get problematic later on. Just a heads up.
An important concept for Iceberg is to stack snapshots in a single commit.
For example, now with append being added in t
kevinjqliu closed issue #1038: [feat] optimize read, pushdown `limit` to file
level for `to_arrow`
URL: https://github.com/apache/iceberg-python/issues/1038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
soumya-ghosh closed pull request #1057: Optimize reads of record batches by
pushing limit to file level
URL: https://github.com/apache/iceberg-python/pull/1057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
souravsingh commented on issue #1119:
URL:
https://github.com/apache/iceberg-python/issues/1119#issuecomment-2323414048
Hello, I am interested in working on this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
a-agmon commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323281873
> My main concern is that it seems like you have taken a "soft-fail"
approach, where, for unsupported operators or nodes, you return None and
proceed by effectively ignoring as-yet
manuzhang closed pull request #10647: Docs: Add note on write distribution
change when adding local order
URL: https://github.com/apache/iceberg/pull/10647
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
a-agmon commented on PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#issuecomment-2323298188
> Aah I see! That makes complete sense. So, what you are saying is, we do
the best we can to filter via metadata within iceberg, but whatever operations
we can't handle in iceberg will
FANNG1 commented on code in PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#discussion_r1740096447
##
crates/integrations/datafusion/src/physical_plan/scan.rs:
##
@@ -138,3 +147,223 @@ async fn get_batch_stream(
Ok(Box::pin(stream))
}
+
+/// Converts DataFu
kevinjqliu commented on PR #1057:
URL: https://github.com/apache/iceberg-python/pull/1057#issuecomment-2323398340
@soumya-ghosh since #1043 is merged, can we close this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
callum-ryan commented on code in PR #534:
URL: https://github.com/apache/iceberg-rust/pull/534#discussion_r1740065220
##
crates/catalog/sql/src/catalog.rs:
##
@@ -141,21 +142,30 @@ impl SqlCatalog {
}
/// SQLX Any does not implement PostgresSQL bindings, so we have t
a-agmon commented on code in PR #588:
URL: https://github.com/apache/iceberg-rust/pull/588#discussion_r1740096736
##
crates/integrations/datafusion/src/physical_plan/scan.rs:
##
@@ -138,3 +147,223 @@ async fn get_batch_stream(
Ok(Box::pin(stream))
}
+
+/// Converts DataF
kevinjqliu commented on code in PR #1068:
URL: https://github.com/apache/iceberg-python/pull/1068#discussion_r1740130936
##
pyproject.toml:
##
@@ -79,7 +79,10 @@ gcsfs = { version = ">=2023.1.0,<2024.1.0", optional = true }
psycopg2-binary = { version = ">=2.9.6", optional = tr
github-actions[bot] commented on PR #7740:
URL: https://github.com/apache/iceberg/pull/7740#issuecomment-2323558073
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
manuzhang commented on code in PR #11065:
URL: https://github.com/apache/iceberg/pull/11065#discussion_r1740395531
##
site/docs/multi-engine-support.md:
##
@@ -93,7 +93,7 @@ Users should continuously upgrade their Flink version to stay
up-to-date.
| 1.17| Deprecated |
manuzhang commented on code in PR #11065:
URL: https://github.com/apache/iceberg/pull/11065#discussion_r1740395531
##
site/docs/multi-engine-support.md:
##
@@ -93,7 +93,7 @@ Users should continuously upgrade their Flink version to stay
up-to-date.
| 1.17| Deprecated |
ZENOTME commented on issue #596:
URL: https://github.com/apache/iceberg-rust/issues/596#issuecomment-2323395450
> Exactly. Internally you want to stack the changes together. For example,
within a single transaction, you add a new field and then write the data, then
the latest schema should
github-actions[bot] commented on issue #7794:
URL: https://github.com/apache/iceberg/issues/7794#issuecomment-2323558138
This issue has been closed because it has not received any activity in the
last 14 days since being marked as 'stale'
--
This is an automated message from the Apache Gi
kevinjqliu commented on issue #1063:
URL:
https://github.com/apache/iceberg-python/issues/1063#issuecomment-2323423547
As of v0.3.0, arro3 does not support reading from different FS
https://kylebarron.dev/arro3/latest/api/io/
--
This is an automated message from the Apache Git Servic
github-actions[bot] commented on PR #7733:
URL: https://github.com/apache/iceberg/pull/7733#issuecomment-2323558032
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] closed issue #7794: Docs: Add Spec back to main menu
URL: https://github.com/apache/iceberg/issues/7794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on PR #7734:
URL: https://github.com/apache/iceberg/pull/7734#issuecomment-2323558044
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
dependabot[bot] opened a new pull request, #595:
URL: https://github.com/apache/iceberg-rust/pull/595
Bumps [crate-ci/typos](https://github.com/crate-ci/typos) from 1.24.1 to
1.24.3.
Release notes
Sourced from https://github.com/crate-ci/typos/releases";>crate-ci/typos's
releases.
dependabot[bot] opened a new pull request, #137:
URL: https://github.com/apache/iceberg-go/pull/137
Bumps
[github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2)
from 1.27.30 to 1.27.31.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/a6e48aca89f21791c4
github-actions[bot] commented on PR #7713:
URL: https://github.com/apache/iceberg/pull/7713#issuecomment-2323558010
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
kevinjqliu commented on issue #1119:
URL:
https://github.com/apache/iceberg-python/issues/1119#issuecomment-2323462427
sounds good, assigned to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
soumya-ghosh commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740157217
##
tests/integration/test_inspect_table.py:
##
@@ -672,126 +672,141 @@ def test_inspect_files(
# append more data
tbl.append(arrow_table_with_null
kevinjqliu commented on code in PR #766:
URL: https://github.com/apache/iceberg-python/pull/766#discussion_r1740136965
##
mkdocs/docs/configuration.md:
##
@@ -268,19 +268,15 @@ catalog:
catalog:
default:
uri: thrift://localhost:9083
+hive.hive2-compatible: true
+
ismailsimsek commented on PR #10536:
URL: https://github.com/apache/iceberg/pull/10536#issuecomment-2323285840
+1 , @joswlv i believe you need to add license header to the file? [example
here](https://github.com/apache/iceberg/blob/main/flink/v1.20/flink/src/main/resources/META-INF/services
dependabot[bot] opened a new pull request, #139:
URL: https://github.com/apache/iceberg-go/pull/139
Bumps
[github.com/aws/aws-sdk-go-v2/service/s3](https://github.com/aws/aws-sdk-go-v2)
from 1.60.1 to 1.61.0.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/b4c01249015f5b8c
github-actions[bot] commented on PR #7802:
URL: https://github.com/apache/iceberg/pull/7802#issuecomment-2323558161
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #7732:
URL: https://github.com/apache/iceberg/pull/7732#issuecomment-2323558022
This pull request has been marked as stale due to 30 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
joswlv commented on PR #10536:
URL: https://github.com/apache/iceberg/pull/10536#issuecomment-2323305709
@ismailsimsek Thanks for the nice comment. added linesense to the file,
thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
manuzhang opened a new pull request, #11065:
URL: https://github.com/apache/iceberg/pull/11065
Since support of Flink 1.20 is not **released** yet, I update the
multi-engine-support doc accordingly in this PR.
cc @snazy @pvary @stevenzwu @nastra
--
This is an automated message fr
github-actions[bot] commented on issue #7832:
URL: https://github.com/apache/iceberg/issues/7832#issuecomment-2323558198
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
manuzhang commented on code in PR #10935:
URL: https://github.com/apache/iceberg/pull/10935#discussion_r1740294635
##
gradle.properties:
##
@@ -32,4 +32,4 @@ org.gradle.parallel=true
org.gradle.configureondemand=true
# explicitly disable the configuration cache
org.gradle.con
liurenjie1024 commented on PR #577:
URL: https://github.com/apache/iceberg-rust/pull/577#issuecomment-2323659302
The reason we use `PartitionSpec` was that some fields, such as spec id,
partition field id should not be passed by user when creating a table. But I
think you are right when a
github-actions[bot] closed issue #7737: [Spark] Few package dependency issues
of Iceberg and AWS
URL: https://github.com/apache/iceberg/issues/7737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
liurenjie1024 commented on issue #586:
URL: https://github.com/apache/iceberg-rust/issues/586#issuecomment-2323635619
Hi, @yukkit Thanks for your interest and welcome to contribute!
> For the first question:
>
> 1. By default, use the latest version.
> 2. [Optional] Support s
kevinjqliu commented on issue #1038:
URL:
https://github.com/apache/iceberg-python/issues/1038#issuecomment-2323419488
Closed by #1043 (see
[comment](https://github.com/apache/iceberg-python/pull/1043/files?diff=unified&w=0#r1716131334))
--
This is an automated message from the Apache Gi
github-actions[bot] commented on issue #7835:
URL: https://github.com/apache/iceberg/issues/7835#issuecomment-2323558228
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
soumya-ghosh commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740158950
##
tests/integration/test_inspect_table.py:
##
@@ -672,126 +672,141 @@ def test_inspect_files(
# append more data
tbl.append(arrow_table_with_null
kevinjqliu merged PR #1118:
URL: https://github.com/apache/iceberg-python/pull/1118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@i
pvary commented on code in PR #11065:
URL: https://github.com/apache/iceberg/pull/11065#discussion_r1740337061
##
site/docs/multi-engine-support.md:
##
@@ -93,7 +93,7 @@ Users should continuously upgrade their Flink version to stay
up-to-date.
| 1.17| Deprecated | 1.3
soumya-ghosh commented on code in PR #1066:
URL: https://github.com/apache/iceberg-python/pull/1066#discussion_r1740159747
##
pyiceberg/table/__init__.py:
##
@@ -4308,7 +4308,9 @@ def history(self) -> "pa.Table":
return pa.Table.from_pylist(history, schema=history_sch
71 matches
Mail list logo
