SourabhBadhya commented on PR #10162:
URL: https://github.com/apache/iceberg/pull/10162#issuecomment-2092426702
I have updated the PR. @pvary and @ajantha-bhat Can you please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sdd commented on code in PR #363:
URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588925183
##
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##
@@ -0,0 +1,819 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
sdd commented on code in PR #363:
URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588936688
##
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##
@@ -0,0 +1,819 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
sdd commented on code in PR #363:
URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1588936688
##
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##
@@ -0,0 +1,819 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
MehulBatra commented on PR #678:
URL: https://github.com/apache/iceberg-python/pull/678#issuecomment-2092638295
> Overall LGTM! The lint issue can be resolved by executing `make lint`
Thank you @HonahX and @kevinjqliu for all the feedback!
--
This is an automated message from the Ap
Fokko commented on code in PR #10162:
URL: https://github.com/apache/iceberg/pull/10162#discussion_r1588974658
##
docs/docs/hive.md:
##
@@ -24,6 +24,21 @@ Iceberg supports reading and writing Iceberg tables through
[Hive](https://hive.
a
[StorageHandler](https://cwiki.apache.
SourabhBadhya commented on code in PR #10162:
URL: https://github.com/apache/iceberg/pull/10162#discussion_r1588980182
##
docs/docs/hive.md:
##
@@ -24,6 +24,21 @@ Iceberg supports reading and writing Iceberg tables through
[Hive](https://hive.
a
[StorageHandler](https://cwiki
Fokko commented on code in PR #10162:
URL: https://github.com/apache/iceberg/pull/10162#discussion_r1588982126
##
docs/docs/hive.md:
##
@@ -431,12 +464,120 @@ ALTER TABLE t SET TBLPROPERTIES
('storage_handler'='org.apache.iceberg.mr.hive.H
During the migration the data files a
SourabhBadhya commented on code in PR #10162:
URL: https://github.com/apache/iceberg/pull/10162#discussion_r1588984815
##
docs/docs/hive.md:
##
@@ -431,12 +464,120 @@ ALTER TABLE t SET TBLPROPERTIES
('storage_handler'='org.apache.iceberg.mr.hive.H
During the migration the data
Fokko merged PR #10162:
URL: https://github.com/apache/iceberg/pull/10162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
Fokko merged PR #10194:
URL: https://github.com/apache/iceberg/pull/10194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apa
a-agmon commented on issue #338:
URL: https://github.com/apache/iceberg-rust/issues/338#issuecomment-2092863958
Another way to resolve this, in a less workaround-ish way, is simply to
capture the fact that we have a V1 schema, a V2 schema, and a V2 compatibility
schema, which is identical t
Fokko commented on issue #338:
URL: https://github.com/apache/iceberg-rust/issues/338#issuecomment-2092909489
> @Fokko if https://github.com/apache/iceberg-rust/issues/354 is applied,
iceberg-rust will no longer be able to read the manifest list files created by
pre-1.5.0 Spark and pre-http
jbonofre commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1589245337
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -40,6 +40,8 @@ final class JdbcUtil {
// property to control if view support is added to the ex
jbonofre commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1589246926
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java:
##
@@ -21,17 +21,39 @@
import java.sql.Connection;
import java.sql.DriverManager;
import java.s
amogh-jahagirdar commented on code in PR #10140:
URL: https://github.com/apache/iceberg/pull/10140#discussion_r1588457797
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -40,6 +40,8 @@ final class JdbcUtil {
// property to control if view support is added t
marvinlanhenke commented on code in PR #363:
URL: https://github.com/apache/iceberg-rust/pull/363#discussion_r1589299148
##
crates/iceberg/src/expr/visitors/expression_evaluator.rs:
##
@@ -0,0 +1,819 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more c
jbonofre commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589368924
##
core/src/main/java/org/apache/iceberg/FastAppend.java:
##
@@ -156,6 +156,8 @@ public List apply(TableMetadata base,
Snapshot snapshot) {
manifests.addAll(
manuzhang commented on issue #10234:
URL: https://github.com/apache/iceberg/issues/10234#issuecomment-2093441393
The issue is we don't persist the partition spec along with its schema in
`metadata.json` file and always use current schema when rebuilding partition
spec from metadata file.
rahil-c commented on PR #9782:
URL: https://github.com/apache/iceberg/pull/9782#issuecomment-2093492003
Thanks @nastra and @danielcweeks for the help on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
nk1506 commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589621767
##
core/src/main/java/org/apache/iceberg/FastAppend.java:
##
@@ -156,6 +156,8 @@ public List apply(TableMetadata base,
Snapshot snapshot) {
manifests.addAll(sn
kevinjqliu commented on PR #678:
URL: https://github.com/apache/iceberg-python/pull/678#issuecomment-2093659238
Thank you for the PR! Do you mind changing the PR title and description to
match?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
sullis commented on PR #10217:
URL: https://github.com/apache/iceberg/pull/10217#issuecomment-2093673973
I am planning to continue working on this PR next week. I'll add an update
when I have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
kevinjqliu commented on issue #637:
URL: https://github.com/apache/iceberg-python/issues/637#issuecomment-2093680333
@AronsonDan I have not heard of this before. I'll take a look, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
kevinjqliu commented on issue #637:
URL: https://github.com/apache/iceberg-python/issues/637#issuecomment-2093713871
@AronsonDan please do! Feel free to tag me or reach out with any questions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
dramaticlly commented on code in PR #10202:
URL: https://github.com/apache/iceberg/pull/10202#discussion_r1589712093
##
open-api/rest-catalog-open-api.yaml:
##
@@ -2893,6 +3003,37 @@ components:
additionalProperties:
type: string
+AppendDataFileRequ
aokolnychyi commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1589703297
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##
@@ -27,6 +27,10 @@ private SparkSQLProperties() {}
// Controls whether vec
aokolnychyi commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1589715889
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##
@@ -184,7 +185,7 @@ public boolean orcVectorizationEnabled() {
.parse();
dramaticlly commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589716377
##
core/src/main/java/org/apache/iceberg/FastAppend.java:
##
@@ -156,6 +156,8 @@ public List apply(TableMetadata base,
Snapshot snapshot) {
manifests.addA
huaxingao commented on code in PR #9841:
URL: https://github.com/apache/iceberg/pull/9841#discussion_r1589730054
##
spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/data/vectorized/CometColumnReader.java:
##
@@ -0,0 +1,164 @@
+/*
+ * Licensed to the Apache Software Founda
dependabot[bot] opened a new pull request, #699:
URL: https://github.com/apache/iceberg-python/pull/699
Bumps [tqdm](https://github.com/tqdm/tqdm) from 4.66.2 to 4.66.3.
Release notes
Sourced from https://github.com/tqdm/tqdm/releases";>tqdm's
releases.
tqdm v4.66.3 stable
amogh-jahagirdar commented on code in PR #10265:
URL: https://github.com/apache/iceberg/pull/10265#discussion_r1589798517
##
core/src/test/java/org/apache/iceberg/TestRewriteManifests.java:
##
@@ -266,31 +280,38 @@ public void testReplaceManifestsWithFilter() throws
IOException
zeodtr commented on issue #338:
URL: https://github.com/apache/iceberg-rust/issues/338#issuecomment-2093913951
@a-agmon Since the problem is in the schema, IMO checking the schema itself
before reading the record is more appropriate. And since the error could be the
other one (for example,
HonahX merged PR #678:
URL: https://github.com/apache/iceberg-python/pull/678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg
HonahX commented on PR #678:
URL: https://github.com/apache/iceberg-python/pull/678#issuecomment-2093962497
Thanks everyone! Merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
prabodh1194 commented on PR #698:
URL: https://github.com/apache/iceberg-python/pull/698#issuecomment-2093965773
noticed a similar PR -- https://github.com/ray-project/ray/pull/45007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
36 matches
Mail list logo
