dramaticlly commented on code in PR #10202:
URL: https://github.com/apache/iceberg/pull/10202#discussion_r1589712093
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2893,6 +3003,37 @@ components:
additionalProperties:
type: string
+ AppendDataFileRequest:
+ type: object
+ required:
+ - data-files
+ properties:
+ identifier:
+ allOf:
+ - $ref: '#/components/schemas/TableIdentifier'
+ description: Table identifier to update; must be present for
CommitTransactionRequest
+ accept-delay-ms:
+ type: integer
+ format: int64
+ description: Acceptable delay in milliseconds for processing the
append request.
+ example: 300000
+ data-files:
+ type: array
+ items:
+ $ref: '#/components/schemas/DataFile'
+ description: A list of serialized data files to append to the table
metadata.
+
+ AppendDataFileResponse:
+ type:
+ object
+ properties:
+ location:
+ type: string
+ description:
+ URL to monitor the status of the append data file operation. This
facilitates tracking the progress and
Review Comment:
I am not sure every REST catalog will ready to provide a URL to visualize
the append progress. Also for async operation like this, how many snapshot
would be generated, how do we cancel or abort such operation?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2893,6 +3003,37 @@ components:
additionalProperties:
type: string
+ AppendDataFileRequest:
+ type: object
+ required:
+ - data-files
+ properties:
+ identifier:
+ allOf:
+ - $ref: '#/components/schemas/TableIdentifier'
+ description: Table identifier to update; must be present for
CommitTransactionRequest
+ accept-delay-ms:
+ type: integer
+ format: int64
+ description: Acceptable delay in milliseconds for processing the
append request.
+ example: 300000
Review Comment:
what happened if REST catalog is busy and cannot fulfill such delay? Is this
all or nothing append or best effort to append everything within delay-ms?
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2893,6 +3003,37 @@ components:
additionalProperties:
type: string
+ AppendDataFileRequest:
+ type: object
+ required:
+ - data-files
+ properties:
+ identifier:
+ allOf:
+ - $ref: '#/components/schemas/TableIdentifier'
+ description: Table identifier to update; must be present for
CommitTransactionRequest
+ accept-delay-ms:
+ type: integer
+ format: int64
+ description: Acceptable delay in milliseconds for processing the
append request.
+ example: 300000
+ data-files:
+ type: array
+ items:
+ $ref: '#/components/schemas/DataFile'
+ description: A list of serialized data files to append to the table
metadata.
Review Comment:
shall we add a limit to number of data files to be appended in a single
operation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
