dramaticlly commented on code in PR #10246:
URL: https://github.com/apache/iceberg/pull/10246#discussion_r1589716377
##########
core/src/main/java/org/apache/iceberg/FastAppend.java:
##########
@@ -156,6 +156,8 @@ public List<ManifestFile> apply(TableMetadata base,
Snapshot snapshot) {
manifests.addAll(snapshot.allManifests(ops.io()));
}
+ manifests.forEach(summaryBuilder::addedManifestStats);
Review Comment:
> But definitely open to hearing more, and especially if you are able to
share any data points on how this metric helped ; that would give us some more
confidence that this is useful and can generalize.
+1 on this, how would knowing these 2 new stats help with planning?
- Knowing how many can help you skip any of the manifests during planning?
- or knowing such will help make manifest rewrite decision?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
