Re: [I] doc: rust.iceberg.apache.org is not resolved [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on issue #137: URL: https://github.com/apache/iceberg-rust/issues/137#issuecomment-1876676128 https://rust.iceberg.apache.org/ is online! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] doc: rust.iceberg.apache.org is not resolved [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo closed issue #137: doc: rust.iceberg.apache.org is not resolved URL: https://github.com/apache/iceberg-rust/issues/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] docs: Change homepage to rust.i.a.o [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo opened a new pull request, #146: URL: https://github.com/apache/iceberg-rust/pull/146 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] Build: Bump sqlalchemy from 2.0.24 to 2.0.25 [iceberg-python]

2024-01-04 Thread via GitHub
Fokko merged PR #250: URL: https://github.com/apache/iceberg-python/pull/250 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] Bug fix falsy value of zero [iceberg-python]

2024-01-04 Thread via GitHub
Fokko merged PR #249: URL: https://github.com/apache/iceberg-python/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [I] bug: The current snapshot with id 0 will be skip. [iceberg-python]

2024-01-04 Thread via GitHub
Fokko closed issue #232: bug: The current snapshot with id 0 will be skip. URL: https://github.com/apache/iceberg-python/issues/232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] docs: Change homepage to rust.i.a.o [iceberg-rust]

2024-01-04 Thread via GitHub
Fokko merged PR #146: URL: https://github.com/apache/iceberg-rust/pull/146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.ap

[PR] Flink: Disable classloader check in TestIcebergSourceWithWatermarkExtractor to fix flakiness [iceberg]

2024-01-04 Thread via GitHub
manuzhang opened a new pull request, #9408: URL: https://github.com/apache/iceberg/pull/9408 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo opened a new pull request, #147: URL: https://github.com/apache/iceberg-rust/pull/147 Part of https://github.com/apache/iceberg-rust/issues/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] Core: Remove partition statistics files during purge table [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat opened a new pull request, #9409: URL: https://github.com/apache/iceberg/pull/9409 follow up from https://github.com/apache/iceberg/pull/9305 cc: @dramaticlly, @amogh-jahagirdar, @nastra, @RussellSpitzer -- This is an automated message from the Apache Git Service. T

Re: [I] How to release [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on issue #81: URL: https://github.com/apache/iceberg-rust/issues/81#issuecomment-1876737649 ## Tasks - [ ] Add release docs: https://github.com/apache/iceberg-rust/pull/147 - [ ] Add verify docs - [ ] Add CI to upload crates -- This is an automated message fro

Re: [PR] Parquet: Support reading INT96 column in row group filter [iceberg]

2024-01-04 Thread via GitHub
manuzhang commented on PR #8988: URL: https://github.com/apache/iceberg/pull/8988#issuecomment-1876754004 I submitted https://github.com/apache/iceberg/pull/9408 to fix failed flaky test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] Flink API rewriteDataFile How to set up scanning based on file size [iceberg]

2024-01-04 Thread via GitHub
GuoZhaoY commented on issue #9386: URL: https://github.com/apache/iceberg/issues/9386#issuecomment-1876786214 Thank you for your answer. I have understood your answer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] Flink API rewriteDataFile How to set up scanning based on file size [iceberg]

2024-01-04 Thread via GitHub
GuoZhaoY closed issue #9386: Flink API rewriteDataFileHow to set up scanning based on file size URL: https://github.com/apache/iceberg/issues/9386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[PR] docs: Add link for iceberg rust [iceberg-docs]

2024-01-04 Thread via GitHub
suyanhanx opened a new pull request, #300: URL: https://github.com/apache/iceberg-docs/pull/300 ![image](https://github.com/apache/iceberg-docs/assets/24221472/d6546902-9920-4e51-a37c-85a735535bd6) -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Flink: Read parquet BINARY column as String for expected [iceberg]

2024-01-04 Thread via GitHub
advancedxy commented on PR #8808: URL: https://github.com/apache/iceberg/pull/8808#issuecomment-1876803507 Spark adds a configuration to control whether to treat binary as string in parquet reader, see: https://github.com/apache/spark/blob/c8137960a0ba725d1633795a057c68f2bbef414b/sql/cataly

[I] Failed to assign splits due to the serialized split size [iceberg]

2024-01-04 Thread via GitHub
javrasya opened a new issue, #9410: URL: https://github.com/apache/iceberg/issues/9410 ### Apache Iceberg version 1.4.2 (latest release) ### Query engine Flink ### Please describe the bug 🐞 Hi there, I am trying to consume records from an Iceberg table in my

Re: [I] how to integrations object storage ceph ? [iceberg]

2024-01-04 Thread via GitHub
jkl0898 commented on issue #7158: URL: https://github.com/apache/iceberg/issues/7158#issuecomment-1876852333 > Hi @jkl0898 , > > I am looking a solution to use Ceph with Iceberg. Currently I used MinIO but the we looking for an alternative solution to replace MinIO. Could you share t

Re: [I] Failed to assign splits due to the serialized split size [iceberg]

2024-01-04 Thread via GitHub
nastra commented on issue #9410: URL: https://github.com/apache/iceberg/issues/9410#issuecomment-1876875354 @stevenzwu @pvary could you guys take a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] API: New API For sequential / streaming updates [iceberg]

2024-01-04 Thread via GitHub
jasonf20 commented on PR #9323: URL: https://github.com/apache/iceberg/pull/9323#issuecomment-1876954557 @rdblue Sure. I added support for setting the sequence number explicitly per file in `MergingSnapshotProducer`. This was almost supported already (it didn't support per file level for ad

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1441669272 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkView.java: ## @@ -0,0 +1,148 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Parquet: Support reading INT96 column in row group filter [iceberg]

2024-01-04 Thread via GitHub
manuzhang commented on PR #8988: URL: https://github.com/apache/iceberg/pull/8988#issuecomment-1877008303 @nastra can we move forward with this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Build: Bump actions/labeler from 4 to 5 [iceberg]

2024-01-04 Thread via GitHub
nastra merged PR #9331: URL: https://github.com/apache/iceberg/pull/9331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
nastra commented on code in PR #9340: URL: https://github.com/apache/iceberg/pull/9340#discussion_r1441709373 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java: ## @@ -810,4 +823,123 @@ private Catalog.TableBuilder newBuilder(Identifier ident, Schema

Re: [PR] Partition Evolution [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441716417 ## pyiceberg/partitioning.py: ## @@ -215,3 +230,118 @@ def assign_fresh_partition_spec_ids(spec: PartitionSpec, old_schema: Schema, fre ) )

Re: [PR] Partition Evolution [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441723506 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441724507 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Partition Evolution [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441725509 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Python: Add support for Python 3.12 [iceberg-python]

2024-01-04 Thread via GitHub
MehulBatra commented on PR #35: URL: https://github.com/apache/iceberg-python/pull/35#issuecomment-1877068534 Looking into this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Partition Evolution [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #245: URL: https://github.com/apache/iceberg-python/pull/245#discussion_r1441727718 ## pyiceberg/table/__init__.py: ## @@ -1904,3 +1913,200 @@ def _generate_snapshot_id() -> int: snapshot_id = snapshot_id if snapshot_id >= 0 else snapshot_id *

Re: [PR] Core: Add a util to read and write partition stats [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on code in PR #9170: URL: https://github.com/apache/iceberg/pull/9170#discussion_r1407500365 ## core/src/main/java/org/apache/iceberg/Partition.java: ## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Add a util to read and write partition stats [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on code in PR #9170: URL: https://github.com/apache/iceberg/pull/9170#discussion_r1407505119 ## core/src/main/java/org/apache/iceberg/Partition.java: ## @@ -0,0 +1,355 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

Re: [PR] Core: Add a util to read and write partition stats [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on code in PR #9170: URL: https://github.com/apache/iceberg/pull/9170#discussion_r1441737877 ## core/src/main/java/org/apache/iceberg/PartitionEntry.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Core: Add a util to read and write partition stats [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on code in PR #9170: URL: https://github.com/apache/iceberg/pull/9170#discussion_r1441749823 ## core/src/main/java/org/apache/iceberg/PartitionEntry.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] Deliver key metadata for encryption of data files [iceberg]

2024-01-04 Thread via GitHub
ggershinsky commented on code in PR #9359: URL: https://github.com/apache/iceberg/pull/9359#discussion_r1441763348 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java: ## @@ -161,7 +162,12 @@ private StructType lazyPosDeleteSparkType() {

Re: [PR] Flink: Disable classloader check in TestIcebergSourceWithWatermarkExtractor to fix flakiness [iceberg]

2024-01-04 Thread via GitHub
pvary merged PR #9408: URL: https://github.com/apache/iceberg/pull/9408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

Re: [PR] Flink: Disable classloader check in TestIcebergSourceWithWatermarkExtractor to fix flakiness [iceberg]

2024-01-04 Thread via GitHub
pvary commented on PR #9408: URL: https://github.com/apache/iceberg/pull/9408#issuecomment-1877190593 Thanks @manuzhang for the fix. CC: @stevenzwu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Use SupportsPrefixOperations for Remove OrphanFile Procedure [iceberg]

2024-01-04 Thread via GitHub
domonkosbalogh-seon commented on PR #7914: URL: https://github.com/apache/iceberg/pull/7914#issuecomment-1877212931 Ran into a similar issue (same as in https://github.com/apache/iceberg/issues/8368) using the Glue Catalog. Is there maybe a workaround to this, or this PR would be the only f

Re: [I] Failed to assign splits due to the serialized split size [iceberg]

2024-01-04 Thread via GitHub
pvary commented on issue #9410: URL: https://github.com/apache/iceberg/issues/9410#issuecomment-1877233309 @stevenzwu: After a quick check, I have found this: https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-core/src/main/java/org/apache/flink/core/memor

Re: [PR] Spark 3.5: Set log level to WARN for rewrite task failure with partial progress [iceberg]

2024-01-04 Thread via GitHub
manuzhang commented on PR #9400: URL: https://github.com/apache/iceberg/pull/9400#issuecomment-1877320865 @ajantha-bhat please help review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Core: Create JUnit5 version of TableTestBase [iceberg]

2024-01-04 Thread via GitHub
lisirrx commented on PR #9217: URL: https://github.com/apache/iceberg/pull/9217#issuecomment-1877336341 @nastra Sorry to continue working so late. I got COVID last month and worked on my graduate school applications. I add the `TestBase` class and give 2 examples using it. -- This is a

Re: [PR] Hive: Add View support for HIVE catalog [iceberg]

2024-01-04 Thread via GitHub
pvary commented on code in PR #8907: URL: https://github.com/apache/iceberg/pull/8907#discussion_r1441980492 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java: ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

[I] Iceberg Glue Concurrent Update can result in missing metadata_location [iceberg]

2024-01-04 Thread via GitHub
shaeqahmed opened a new issue, #9411: URL: https://github.com/apache/iceberg/issues/9411 ### Apache Iceberg version 1.4.2 (latest release) ### Query engine None ### Please describe the bug 🐞 Similar issue that i found that was supposed to be fixed in older v

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
rdblue merged PR #9340: URL: https://github.com/apache/iceberg/pull/9340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Spark: Add support for reading Iceberg views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on PR #9340: URL: https://github.com/apache/iceberg/pull/9340#issuecomment-1877413431 Merged! Thanks for getting this working @nastra! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Deliver key metadata for encryption of data files [iceberg]

2024-01-04 Thread via GitHub
rdblue merged PR #9359: URL: https://github.com/apache/iceberg/pull/9359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Deliver key metadata for encryption of data files [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on PR #9359: URL: https://github.com/apache/iceberg/pull/9359#issuecomment-1877443032 Merged! Thanks, @ggershinsky for getting this done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] Flink: Create JUnit5 version of TestFlinkScan [iceberg]

2024-01-04 Thread via GitHub
pvary commented on PR #9185: URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1877465254 Do we have a way to check if the new tests were running on the CI? With the correct parameters? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Flink: Create JUnit5 version of TestFlinkScan [iceberg]

2024-01-04 Thread via GitHub
nastra commented on PR #9185: URL: https://github.com/apache/iceberg/pull/9185#issuecomment-1877466639 > Do we have a way to check if the new tests were running on the CI? With the correct parameters? I don't think so, but I was verifying them all locally -- This is an automated me

Re: [PR] API, Core, Spark 3.5: Parallelize reading of deletes and cache them on executors [iceberg]

2024-01-04 Thread via GitHub
aokolnychyi commented on code in PR #8755: URL: https://github.com/apache/iceberg/pull/8755#discussion_r1442126743 ## core/src/main/java/org/apache/iceberg/deletes/EmptyPositionDeleteIndex.java: ## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442151540 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +57,17 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442152596 ## spark/v3.5/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveViews.scala: ## @@ -53,6 +57,17 @@ case class ResolveViews(spark: SparkSessio

Re: [PR] Spark: Support renaming views [iceberg]

2024-01-04 Thread via GitHub
rdblue commented on code in PR #9343: URL: https://github.com/apache/iceberg/pull/9343#discussion_r1442153222 ## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestViews.java: ## @@ -590,10 +591,7 @@ public void fullFunctionIdentifier() { @Test

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-04 Thread via GitHub
jackye1995 merged PR #9385: URL: https://github.com/apache/iceberg/pull/9385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] AWS: Add S3 Access Grants Integration [iceberg]

2024-01-04 Thread via GitHub
jackye1995 commented on PR #9385: URL: https://github.com/apache/iceberg/pull/9385#issuecomment-1877659221 Seems like this is not getting much attraction from other reviewers. Given it is a pretty straightforward plugin integration, I will go ahead to merge it. We can fix things later if ne

Re: [PR] Spark 3.5: Set log level to WARN for rewrite task failure with partial progress [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9400: URL: https://github.com/apache/iceberg/pull/9400#discussion_r1442227949 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ## @@ -345,7 +345,7 @@ private Result doExecuteWithPartial

Re: [PR] Spark 3.5: Set log level to WARN for rewrite task failure with partial progress [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9400: URL: https://github.com/apache/iceberg/pull/9400#discussion_r1442227949 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ## @@ -345,7 +345,7 @@ private Result doExecuteWithPartial

Re: [PR] Spark 3.5: Set log level to WARN for rewrite task failure with partial progress [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9400: URL: https://github.com/apache/iceberg/pull/9400#discussion_r1442236190 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java: ## @@ -345,7 +345,7 @@ private Result doExecuteWithPartial

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442241575 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java: ## @@ -72,18 +70,12 @@ public void clearRewrite(Table table, String

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442246021 ## spark/v3.4/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java: ## @@ -948,6 +950,17 @@ public static org.apache.spark.sql.catalyst.TableIdentifie

Re: [PR] Core: Remove deprecated method from BaseMetadataTable [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9298: URL: https://github.com/apache/iceberg/pull/9298#discussion_r1442241575 ## spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/BaseFileRewriteCoordinator.java: ## @@ -72,18 +70,12 @@ public void clearRewrite(Table table, String

Re: [PR] Core: Remove partition statistics files during purge table [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on PR #9409: URL: https://github.com/apache/iceberg/pull/9409#issuecomment-1877783387 Thanks @dramaticlly for the review, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Core: Remove partition statistics files during purge table [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar merged PR #9409: URL: https://github.com/apache/iceberg/pull/9409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-04 Thread via GitHub
Fokko commented on code in PR #247: URL: https://github.com/apache/iceberg-python/pull/247#discussion_r1442296384 ## pyiceberg/table/__init__.py: ## @@ -942,15 +942,16 @@ def snapshot(self) -> Optional[Snapshot]: return self.table.current_snapshot() def projectio

Re: [I] Add a Function variable as an extra partition filter to filter DataFiles [iceberg]

2024-01-04 Thread via GitHub
github-actions[bot] closed issue #6871: Add a Function variable as an extra partition filter to filter DataFiles URL: https://github.com/apache/iceberg/issues/6871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Add a Function variable as an extra partition filter to filter DataFiles [iceberg]

2024-01-04 Thread via GitHub
github-actions[bot] commented on issue #6871: URL: https://github.com/apache/iceberg/issues/6871#issuecomment-1877934782 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] [Big manifest] If the manifest file is very big, the decode cost time is very long [iceberg]

2024-01-04 Thread via GitHub
github-actions[bot] commented on issue #6868: URL: https://github.com/apache/iceberg/issues/6868#issuecomment-1877934801 This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs.

Re: [I] Cache delete files when reading v2 format with merge-on-read mode [iceberg]

2024-01-04 Thread via GitHub
github-actions[bot] closed issue #6865: Cache delete files when reading v2 format with merge-on-read mode URL: https://github.com/apache/iceberg/issues/6865 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] Cache delete files when reading v2 format with merge-on-read mode [iceberg]

2024-01-04 Thread via GitHub
github-actions[bot] commented on issue #6865: URL: https://github.com/apache/iceberg/issues/6865#issuecomment-1877934826 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] [Big manifest] If the manifest file is very big, the decode cost time is very long [iceberg]

2024-01-04 Thread via GitHub
zombee0 closed issue #6868: [Big manifest] If the manifest file is very big, the decode cost time is very long URL: https://github.com/apache/iceberg/issues/6868 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] check_github_labeler_v5 [iceberg]

2024-01-04 Thread via GitHub
panbingkun closed pull request #9413: check_github_labeler_v5 URL: https://github.com/apache/iceberg/pull/9413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#issuecomment-1878030924 Hi @Fokko, if you think this PR is too large, I can split it up. For instance, I could add the scripts in separate PRs. -- This is an automated message from the Apache Git Service. To

Re: [I] Failed to assign splits due to the serialized split size [iceberg]

2024-01-04 Thread via GitHub
javrasya commented on issue #9410: URL: https://github.com/apache/iceberg/issues/9410#issuecomment-1878085557 It seems this bug has been introduced by version 1.4.0 which is kid of new. Tried fixing it by tweaking the SplitAssignerFactory I pass down to the IcebergSource but even though I r

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
liurenjie1024 commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442448609 ## crates/catalog/hms/DEPENDENCIES.rust.tsv: ## Review Comment: What are these tsv files used for? ## website/src/release.md: ## @@ -0,

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442472242 ## crates/catalog/hms/DEPENDENCIES.rust.tsv: ## Review Comment: The ASF release requires users to have a complete list of our dependencies to ensure compliance

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442472860 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apache req

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473048 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apache req

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473406 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apache req

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442473747 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apache req

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
Xuanwo commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442474047 ## website/src/download.md: ## Review Comment: > I think maybe we don't need this ASF release policy requires that users have the ability to download and

[PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar opened a new pull request, #9414: URL: https://github.com/apache/iceberg/pull/9414 When working on Trino Iceberg view support, I realized that updating column comments across engines is the same logic 1.) Get the view schema 2.) Find the field to update, update it 3.)

Re: [PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442512815 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1739,4 +1739,61 @@ public void testSqlForInvalidArguments() { .isInstanceO

Re: [PR] API, Core: Add withUpdatedColumnDoc API to Schema [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442516050 ## core/src/test/java/org/apache/iceberg/view/ViewCatalogTests.java: ## @@ -1739,4 +1739,61 @@ public void testSqlForInvalidArguments() { .isInstanceO

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
liurenjie1024 commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442519521 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apa

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
liurenjie1024 commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442520171 ## website/src/download.md: ## Review Comment: > ASF release policy requires that users have the ability to download and build from source. Then h

Re: [PR] docs: Add release guide for iceberg-rust [iceberg-rust]

2024-01-04 Thread via GitHub
liurenjie1024 commented on code in PR #147: URL: https://github.com/apache/iceberg-rust/pull/147#discussion_r1442520271 ## website/src/release.md: ## @@ -0,0 +1,383 @@ + + +This document mainly introduces how the release manager releases a new version in accordance with the Apa

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442535706 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442535706 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442541492 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on code in PR #9414: URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442541492 ## core/src/main/java/org/apache/iceberg/view/BaseView.java: ## @@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) { return closes

Re: [PR] Nessie: Strip trailing slash for warehouse location [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on code in PR #9415: URL: https://github.com/apache/iceberg/pull/9415#discussion_r1442549368 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java: ## @@ -183,7 +184,8 @@ private String validateWarehouseLocation(String name, Map catalo

Re: [PR] Nessie: Strip trailing slash for warehouse location [iceberg]

2024-01-04 Thread via GitHub
ajantha-bhat commented on PR #9415: URL: https://github.com/apache/iceberg/pull/9415#issuecomment-1878214701 cc: @snazy, @dimas-b , @adutra -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Correct schema behavior [iceberg-python]

2024-01-04 Thread via GitHub
Fokko merged PR #247: URL: https://github.com/apache/iceberg-python/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.

Re: [PR] API, Core: Add Schema#withUpdatedDoc and View#updateColumnDoc APIs [iceberg]

2024-01-04 Thread via GitHub
amogh-jahagirdar commented on PR #9414: URL: https://github.com/apache/iceberg/pull/9414#issuecomment-1878270693 Hmafter thinking about this a bit more, I think we can remove the Schema API and add an API to ReplaceViewVersion `withUpdatedColumnDoc`. This API can do change tracking and