amogh-jahagirdar commented on code in PR #9414:
URL: https://github.com/apache/iceberg/pull/9414#discussion_r1442540195
##########
core/src/main/java/org/apache/iceberg/view/BaseView.java:
##########
@@ -128,4 +128,23 @@ public SQLViewRepresentation sqlFor(String dialect) {
return closest;
}
+
+ @Override
+ @SuppressWarnings("checkstyle:HiddenField")
+ public ReplaceViewVersion updateColumnDoc(String name, String doc) {
Review Comment:
Ah the awkward thing here is method chaining....
view.updateColumnDoc("col1", "docs").updateColumnDoc("col2",
"docs").commit() will only update column2.
Maybe this should be updated to allow multiple column/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
