jasonf20 commented on PR #9323: URL: https://github.com/apache/iceberg/pull/9323#issuecomment-1876954557
@rdblue Sure. I added support for setting the sequence number explicitly per file in `MergingSnapshotProducer`. This was almost supported already (it didn't support per file level for added files). This is then used in a similar way to how `Rewrite` used it, but the main difference is that we don't set the sequence number when the user adds the file. Instead, we just collect an ordered list of files and only assign the sequence numbers when `apply` is called. Since apply is called with the `base` metadata we can calculate the sequence numbers from there. If the commit fails due to a conflict `apply` is called again and we can re-calculate the new sequence numbers. Looking again now, I think I might need to remove the `requiresApply` boolean from the `apply` method for retries to work properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
