Re: [PR] chroes:Manage dependencies using workspace. [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko merged PR #93: URL: https://github.com/apache/iceberg-rust/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] chroes:Manage dependencies using workspace. [iceberg-rust]

2023-11-13 Thread via GitHub
my-vegetable-has-exploded commented on PR #93: URL: https://github.com/apache/iceberg-rust/pull/93#issuecomment-1807670975 thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [I] Manage dependencies using workspace. [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko closed issue #24: Manage dependencies using workspace. URL: https://github.com/apache/iceberg-rust/issues/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

Re: [PR] minor: Provide Debug impl for pub structs #73 [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko merged PR #92: URL: https://github.com/apache/iceberg-rust/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Implement `Debug` trait for public structs [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko closed issue #73: Implement `Debug` trait for public structs URL: https://github.com/apache/iceberg-rust/issues/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-11-13 Thread via GitHub
nastra closed issue #7094: Deprecate usages of AssertHelpers in codebase URL: https://github.com/apache/iceberg/issues/7094 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [I] Deprecate usages of AssertHelpers in codebase [iceberg]

2023-11-13 Thread via GitHub
nastra commented on issue #7094: URL: https://github.com/apache/iceberg/issues/7094#issuecomment-1807706741 The only modules left are Spark 3.2 + Spark 3.3 ![image](https://github.com/apache/iceberg/assets/271029/869d8ec2-7d9d-4a14-8dd9-3326c64db850) I don't think we want to sp

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.15 to 2.21.21 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9044: URL: https://github.com/apache/iceberg/pull/9044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump orc from 1.9.1 to 1.9.2 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9045: URL: https://github.com/apache/iceberg/pull/9045 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump arrow from 14.0.0 to 14.0.1 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9043: URL: https://github.com/apache/iceberg/pull/9043 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump net.snowflake:snowflake-jdbc from 3.14.2 to 3.14.3 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9039: URL: https://github.com/apache/iceberg/pull/9039 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Support tencent COS fileIO [iceberg]

2023-11-13 Thread via GitHub
nastra commented on code in PR #9048: URL: https://github.com/apache/iceberg/pull/9048#discussion_r1390789456 ## tencent/src/test/java/org/apache/iceberg/tencentcloud/cos/TestCosClientFactories.java: ## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Core: Adding Serializing TableMetadataLocation in TableMetadataParser [iceberg]

2023-11-13 Thread via GitHub
nastra commented on PR #9034: URL: https://github.com/apache/iceberg/pull/9034#issuecomment-1807721947 @leewjae can you please elaborate why this change is needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Core: Adding Serializing TableMetadataLocation in TableMetadataParser [iceberg]

2023-11-13 Thread via GitHub
nastra commented on code in PR #9034: URL: https://github.com/apache/iceberg/pull/9034#discussion_r1390795112 ## core/src/main/java/org/apache/iceberg/TableMetadataParser.java: ## @@ -84,6 +84,7 @@ public static Codec fromFileName(String fileName) { private TableMetadataParse

Re: [PR] Build: Bump junit from 5.10.0 to 5.10.1 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9037: URL: https://github.com/apache/iceberg/pull/9037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump com.google.cloud:libraries-bom from 26.26.0 to 26.27.0 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9036: URL: https://github.com/apache/iceberg/pull/9036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump jetty from 9.4.53.v20231009 to 11.0.18 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] commented on PR #8987: URL: https://github.com/apache/iceberg/pull/8987#issuecomment-1807731057 Looks like these dependencies are no longer updatable, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Build: Bump jetty from 9.4.53.v20231009 to 11.0.18 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] closed pull request #8987: Build: Bump jetty from 9.4.53.v20231009 to 11.0.18 URL: https://github.com/apache/iceberg/pull/8987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390768529 ## crates/iceberg/src/avro/schema.rs: ## @@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString, schema: &Schema) -> Res visit_schema(schema

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko commented on PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#issuecomment-1807742634 I'll move this forward since it has been pending for a while (Sorry for that!). I have one comment about ignoring the scale, which looks incorrect to me. Thanks @ZENOTME for working on thi

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
Fokko merged PR #82: URL: https://github.com/apache/iceberg-rust/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.43.2.2 [iceberg]

2023-11-13 Thread via GitHub
nastra commented on PR #8985: URL: https://github.com/apache/iceberg/pull/8985#issuecomment-1807744712 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.44.0.0 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9051: URL: https://github.com/apache/iceberg/pull/9051 Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.43.2.1 to 3.44.0.0. Release notes Sourced from https://github.com/xerial/sqlite-jdbc/releases";>org.xerial

Re: [PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.43.2.2 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] commented on PR #8985: URL: https://github.com/apache/iceberg/pull/8985#issuecomment-1807746597 Superseded by #9051. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.43.2.2 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] closed pull request #8985: Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.43.2.2 URL: https://github.com/apache/iceberg/pull/8985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] AWS: Support S3 DSSE-KMS encryption [iceberg]

2023-11-13 Thread via GitHub
aajisaka commented on PR #8370: URL: https://github.com/apache/iceberg/pull/8370#issuecomment-1807762944 From my side, is there something do to make it forward? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
ZENOTME commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390885977 ## crates/iceberg/src/avro/schema.rs: ## @@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString, schema: &Schema) -> Res visit_schema(sche

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
ZENOTME commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390890336 ## crates/iceberg/src/avro/schema.rs: ## @@ -441,14 +453,35 @@ impl AvroSchemaVisitor for AvroSchemaToSchema { AvroSchema::Date => Type::Primitive(Primiti

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
ZENOTME commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390902968 ## crates/iceberg/src/spec/values.rs: ## @@ -893,9 +925,9 @@ impl Literal { PrimitiveLiteral::Binary(_) => Type::Primitive(PrimitiveType::Binary),

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
liurenjie1024 commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390944513 ## crates/iceberg/src/spec/values.rs: ## @@ -893,9 +925,9 @@ impl Literal { PrimitiveLiteral::Binary(_) => Type::Primitive(PrimitiveType::Binar

Re: [PR] Core: lazily create locationProvider in SerializableTable [iceberg]

2023-11-13 Thread via GitHub
przemekd commented on PR #9029: URL: https://github.com/apache/iceberg/pull/9029#issuecomment-1807918280 @aokolnychyi Sure. This one is not about serialization. The idea behind this fix is to allow to query (read) tables in Spark (and potentially other query engines using `SerializableTable

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
ZENOTME commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390968160 ## crates/iceberg/src/spec/values.rs: ## @@ -893,9 +925,9 @@ impl Literal { PrimitiveLiteral::Binary(_) => Type::Primitive(PrimitiveType::Binary),

Re: [I] hive integration iceberg related problems [iceberg]

2023-11-13 Thread via GitHub
dragon-feng commented on issue #8993: URL: https://github.com/apache/iceberg/issues/8993#issuecomment-1807953900 @pvary yes,Is there a way to deal with it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.2.1 to 3.44.0.0 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9051: URL: https://github.com/apache/iceberg/pull/9051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Hive: Improve performance of HiveCatalog#listTables [iceberg]

2023-11-13 Thread via GitHub
pvary commented on issue #9031: URL: https://github.com/apache/iceberg/issues/9031#issuecomment-1808289192 Please check #2722. We need to fix Hive issues for this, as mentioned there. I am here to review both Hive and Iceberg fixes -- This is an automated message from the Apache Git

Re: [I] Flink: Add support for Flink 1.18 [iceberg]

2023-11-13 Thread via GitHub
pvary commented on issue #8930: URL: https://github.com/apache/iceberg/issues/8930#issuecomment-1808311058 Thanks @PrabhuJoseph for the investigation! We will come back to this soon! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] hive integration iceberg related problems [iceberg]

2023-11-13 Thread via GitHub
pvary commented on issue #8993: URL: https://github.com/apache/iceberg/issues/8993#issuecomment-1808321603 You have 2 options: - Hive 3 - Use MR engine for write, and Tez engine for read - Hive 4 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Docs: Add section on pandas [iceberg-python]

2023-11-13 Thread via GitHub
rdblue commented on code in PR #138: URL: https://github.com/apache/iceberg-python/pull/138#discussion_r1391472946 ## mkdocs/docs/api.md: ## @@ -346,6 +346,45 @@ tpep_dropoff_datetime: [[2021-04-01 00:47:59.00,...,2021-05-01 00:14:47. This will only pull in the files

Re: [PR] GCP: Add Iceberg Catalog for GCP BigLake Metastore [iceberg]

2023-11-13 Thread via GitHub
rdblue commented on code in PR #7412: URL: https://github.com/apache/iceberg/pull/7412#discussion_r1391491378 ## gcp/src/main/java/org/apache/iceberg/gcp/biglake/BigLakeTableOperations.java: ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Hive: Refactor HiveTableOperations with common code for View. [iceberg]

2023-11-13 Thread via GitHub
nk1506 commented on code in PR #9011: URL: https://github.com/apache/iceberg/pull/9011#discussion_r1391550697 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java: ## @@ -156,7 +147,7 @@ protected void doRefresh() { String metadataLocation = null

Re: [PR] Hive: Refactor HiveTableOperations with common code for View. [iceberg]

2023-11-13 Thread via GitHub
nk1506 commented on code in PR #9011: URL: https://github.com/apache/iceberg/pull/9011#discussion_r1391553311 ## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveMetastoreConnector.java: ## @@ -0,0 +1,173 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391561630 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391563201 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391589914 ## site/README.md: ## @@ -35,107 +35,101 @@ In MkDocs, the [`docs_dir`](https://www.mkdocs.org/user-guide/configuration/#doc ### Iceberg docs layout -In th

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391601671 ## site/dev/common.sh: ## @@ -0,0 +1,124 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391628443 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- co

[PR] Doc: Adding PuppyGraph to the vendor list [iceberg-docs]

2023-11-13 Thread via GitHub
FreeMem17 opened a new pull request, #293: URL: https://github.com/apache/iceberg-docs/pull/293 This PR adds to the vendor page a section for PuppyGraph. The paragraphs and links to be added contain more details about PuppyGraph. -- This is an automated message from the Apache Git S

Re: [PR] Doc: Adding PuppyGraph to the vendor list [iceberg-docs]

2023-11-13 Thread via GitHub
danielcweeks commented on code in PR #293: URL: https://github.com/apache/iceberg-docs/pull/293#discussion_r1391755452 ## landing-page/content/common/vendors.md: ## @@ -56,6 +56,16 @@ With Dremio, an organization can easily build and manage a data lakehouse in whi IOMETE is

Re: [PR] fix: Migrate from tempdir to tempfile crate [iceberg-rust]

2023-11-13 Thread via GitHub
cdaudt commented on PR #91: URL: https://github.com/apache/iceberg-rust/pull/91#issuecomment-1809211353 > Great catch @cdaudt, and thanks for fixing this. Can you resolve the conflicts? done -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Doc: Adding PuppyGraph to the vendor list [iceberg-docs]

2023-11-13 Thread via GitHub
danielcweeks commented on code in PR #293: URL: https://github.com/apache/iceberg-docs/pull/293#discussion_r1391756354 ## landing-page/content/common/vendors.md: ## @@ -56,6 +56,16 @@ With Dremio, an organization can easily build and manage a data lakehouse in whi IOMETE is

Re: [PR] Doc: Adding PuppyGraph to the vendor list [iceberg-docs]

2023-11-13 Thread via GitHub
danielcweeks commented on code in PR #293: URL: https://github.com/apache/iceberg-docs/pull/293#discussion_r1391763783 ## landing-page/content/common/vendors.md: ## @@ -56,6 +56,16 @@ With Dremio, an organization can easily build and manage a data lakehouse in whi IOMETE is

Re: [PR] Parquet: Remove the row position since parquet row group has it natively [iceberg]

2023-11-13 Thread via GitHub
flyrain commented on PR #6056: URL: https://github.com/apache/iceberg/pull/6056#issuecomment-1809224390 Thanks for sharing @ricardopereira33. Looks like the issue is due to a bug in Parquet 1.12.3, not directly related to this PR. It'd be nice to have this PR in though. -- This is an aut

Re: [PR] Doc: Adding PuppyGraph to the vendor list [iceberg-docs]

2023-11-13 Thread via GitHub
danielcweeks commented on code in PR #293: URL: https://github.com/apache/iceberg-docs/pull/293#discussion_r1391763783 ## landing-page/content/common/vendors.md: ## @@ -56,6 +56,16 @@ With Dremio, an organization can easily build and manage a data lakehouse in whi IOMETE is

[PR] Build: Bump pydantic from 2.4.2 to 2.5.0 [iceberg-python]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #141: URL: https://github.com/apache/iceberg-python/pull/141 Bumps [pydantic](https://github.com/pydantic/pydantic) from 2.4.2 to 2.5.0. Release notes Sourced from https://github.com/pydantic/pydantic/releases";>pydantic's releases.

[PR] Build: Bump mkdocstrings-python from 1.7.3 to 1.7.4 [iceberg-python]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #142: URL: https://github.com/apache/iceberg-python/pull/142 Bumps [mkdocstrings-python](https://github.com/mkdocstrings/python) from 1.7.3 to 1.7.4. Release notes Sourced from https://github.com/mkdocstrings/python/releases";>mkdocstrings

[PR] Build: Bump moto from 4.2.7 to 4.2.8 [iceberg-python]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #143: URL: https://github.com/apache/iceberg-python/pull/143 Bumps [moto](https://github.com/getmoto/moto) from 4.2.7 to 4.2.8. Changelog Sourced from https://github.com/getmoto/moto/blob/master/CHANGELOG.md";>moto's changelog. 4.2.

[PR] Build: Bump griffe from 0.36.9 to 0.38.0 [iceberg-python]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #144: URL: https://github.com/apache/iceberg-python/pull/144 Bumps [griffe](https://github.com/mkdocstrings/griffe) from 0.36.9 to 0.38.0. Release notes Sourced from https://github.com/mkdocstrings/griffe/releases";>griffe's releases.

Re: [PR] Add dependabot to automatically update the site [iceberg]

2023-11-13 Thread via GitHub
Fokko commented on PR #9004: URL: https://github.com/apache/iceberg/pull/9004#issuecomment-1809267436 @aokolnychyi No worries, thanks for the review. Thanks @nastra as well 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Add dependabot to automatically update the site [iceberg]

2023-11-13 Thread via GitHub
Fokko merged PR #9004: URL: https://github.com/apache/iceberg/pull/9004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apach

[PR] Build: Bump mkdocs-material-extensions from 1.1.1 to 1.3 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9052: URL: https://github.com/apache/iceberg/pull/9052 Bumps [mkdocs-material-extensions](https://github.com/facelessuser/mkdocs-material-extensions) from 1.1.1 to 1.3. Release notes Sourced from https://github.com/facelessuser/mkdocs-ma

[PR] Build: Bump software.amazon.awssdk:bom from 2.21.21 to 2.21.22 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9053: URL: https://github.com/apache/iceberg/pull/9053 Bumps software.amazon.awssdk:bom from 2.21.21 to 2.21.22. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=softwa

[PR] Build: Bump datamodel-code-generator from 0.22.0 to 0.23.0 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9054: URL: https://github.com/apache/iceberg/pull/9054 Bumps [datamodel-code-generator](https://github.com/koxudaxi/datamodel-code-generator) from 0.22.0 to 0.23.0. Release notes Sourced from https://github.com/koxudaxi/datamodel-code-ge

[PR] Build: Bump mkdocs-material from 9.1.21 to 9.4.8 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9055: URL: https://github.com/apache/iceberg/pull/9055 Bumps [mkdocs-material](https://github.com/squidfunk/mkdocs-material) from 9.1.21 to 9.4.8. Release notes Sourced from https://github.com/squidfunk/mkdocs-material/releases";>mkdocs-m

[PR] Build: Update pydantic requirement from <2.4.0 to <2.6.0 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9056: URL: https://github.com/apache/iceberg/pull/9056 Updates the requirements on [pydantic](https://github.com/pydantic/pydantic) to permit the latest version. Release notes Sourced from https://github.com/pydantic/pydantic/releases";>p

[PR] Build: Bump openapi-spec-validator from 0.5.2 to 0.7.1 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9057: URL: https://github.com/apache/iceberg/pull/9057 Bumps [openapi-spec-validator](https://github.com/python-openapi/openapi-spec-validator) from 0.5.2 to 0.7.1. Release notes Sourced from https://github.com/python-openapi/openapi-spe

[PR] Build: Bump mkdocs-macros-plugin from 1.0.4 to 1.0.5 [iceberg]

2023-11-13 Thread via GitHub
dependabot[bot] opened a new pull request, #9058: URL: https://github.com/apache/iceberg/pull/9058 Bumps [mkdocs-macros-plugin](https://github.com/fralau/mkdocs_macros_plugin) from 1.0.4 to 1.0.5. Changelog Sourced from https://github.com/fralau/mkdocs_macros_plugin/blob/master/CHA

Re: [I] About ICEBERG's experience in using large data tables [iceberg]

2023-11-13 Thread via GitHub
github-actions[bot] closed issue #7514: About ICEBERG's experience in using large data tables URL: https://github.com/apache/iceberg/issues/7514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] Expose ManifestLists as a public class [iceberg]

2023-11-13 Thread via GitHub
github-actions[bot] closed issue #7511: Expose ManifestLists as a public class URL: https://github.com/apache/iceberg/issues/7511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] About ICEBERG's experience in using large data tables [iceberg]

2023-11-13 Thread via GitHub
github-actions[bot] commented on issue #7514: URL: https://github.com/apache/iceberg/issues/7514#issuecomment-1809333409 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [I] Expose ManifestLists as a public class [iceberg]

2023-11-13 Thread via GitHub
github-actions[bot] commented on issue #7511: URL: https://github.com/apache/iceberg/issues/7511#issuecomment-1809333434 This issue has been closed because it has not received any activity in the last 14 days since being marked as 'stale' -- This is an automated message from the Apache Gi

Re: [PR] Open-API: Refactor TableRequirements [iceberg]

2023-11-13 Thread via GitHub
romusz commented on PR #7710: URL: https://github.com/apache/iceberg/pull/7710#issuecomment-1809358653 Hi, Have you tested this refactoring with code generated for Go? What we get now is: ```go type TableRequirement struct { Type string `json:"type"` } ```

Re: [PR] Open-API: Refactor TableRequirements [iceberg]

2023-11-13 Thread via GitHub
romusz commented on PR #7710: URL: https://github.com/apache/iceberg/pull/7710#issuecomment-1809368041 @Fokko not sure if you'll see the above comment since the pr has been merged, thus an explicit call-out. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] Replace i64 with DateTime [iceberg-rust]

2023-11-13 Thread via GitHub
fqaiser94 commented on PR #94: URL: https://github.com/apache/iceberg-rust/pull/94#issuecomment-1809425134 Moving back to draft while i address comments. Will ping when it's ready again, shouldn't take too long! -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] Spark: Add serialzable isolation test for concurrent MERGE INTOs [iceberg]

2023-11-13 Thread via GitHub
aokolnychyi commented on PR #9050: URL: https://github.com/apache/iceberg/pull/9050#issuecomment-1809442786 I will check tomorrow morning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] Core: Enable column statistics filtering after planning [iceberg]

2023-11-13 Thread via GitHub
aokolnychyi commented on code in PR #8803: URL: https://github.com/apache/iceberg/pull/8803#discussion_r1391932246 ## core/src/main/java/org/apache/iceberg/BaseDistributedDataScan.java: ## @@ -368,7 +369,9 @@ private CloseableIterable toFileTasks( ScanMetricsUtil.file

Re: [PR] Core: Enable column statistics filtering after planning [iceberg]

2023-11-13 Thread via GitHub
aokolnychyi commented on code in PR #8803: URL: https://github.com/apache/iceberg/pull/8803#discussion_r1391927184 ## .palantir/revapi.yml: ## @@ -866,6 +866,11 @@ acceptedBreaks: old: "method void org.apache.iceberg.encryption.Ciphers::()" new: "method void org.ap

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [PR] Shift site build to use monorepo and gh-pages [iceberg]

2023-11-13 Thread via GitHub
bitsondatadev commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391967054 ## site/mkdocs.yml: ## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: +- con

Re: [I] Implement bucket transform hash() function [iceberg-python]

2023-11-13 Thread via GitHub
puchengy closed issue #145: Implement bucket transform hash() function URL: https://github.com/apache/iceberg-python/issues/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] use uuid as primary key not in first column,flinksql wirte delete event to iceberg,spark read table not delete [iceberg]

2023-11-13 Thread via GitHub
mengshangxun closed issue #6996: use uuid as primary key not in first column,flinksql wirte delete event to iceberg,spark read table not delete URL: https://github.com/apache/iceberg/issues/6996 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [I] use uuid as primary key not in first column,flinksql wirte delete event to iceberg,spark read table not delete [iceberg]

2023-11-13 Thread via GitHub
mengshangxun commented on issue #6996: URL: https://github.com/apache/iceberg/issues/6996#issuecomment-1809588366 thank you, this issue is resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Build: Bump mkdocs-macros-plugin from 1.0.4 to 1.0.5 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9058: URL: https://github.com/apache/iceberg/pull/9058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] Build: Bump datamodel-code-generator from 0.22.0 to 0.23.0 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9054: URL: https://github.com/apache/iceberg/pull/9054 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
JanKaul commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1392079536 ## crates/iceberg/src/spec/values.rs: ## @@ -893,9 +925,9 @@ impl Literal { PrimitiveLiteral::Binary(_) => Type::Primitive(PrimitiveType::Binary),

Re: [PR] Nessie: reimplement namespace operations [iceberg]

2023-11-13 Thread via GitHub
nastra commented on code in PR #8857: URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392080692 ## nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java: ## @@ -540,4 +585,64 @@ public void close() { api.close(); } } + + private vo

Re: [PR] Nessie: reimplement namespace operations [iceberg]

2023-11-13 Thread via GitHub
nastra commented on code in PR #8857: URL: https://github.com/apache/iceberg/pull/8857#discussion_r1392081563 ## nessie/src/test/java/org/apache/iceberg/nessie/TestNessieIcebergClient.java: ## @@ -91,6 +111,412 @@ public void testWithReferenceAfterRecreatingBranch() Asserti

Re: [PR] feat: support ser/deser of value [iceberg-rust]

2023-11-13 Thread via GitHub
JanKaul commented on code in PR #82: URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1392082466 ## crates/iceberg/src/avro/schema.rs: ## @@ -233,23 +222,46 @@ pub(crate) fn schema_to_avro_schema(name: impl ToString, schema: &Schema) -> Res visit_schema(sche

Re: [PR] Build: Bump mkdocs-material-extensions from 1.1.1 to 1.3 [iceberg]

2023-11-13 Thread via GitHub
nastra merged PR #9052: URL: https://github.com/apache/iceberg/pull/9052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac

Re: [I] Iceberg Materialized View Spec [iceberg]

2023-11-13 Thread via GitHub
JanKaul commented on issue #6420: URL: https://github.com/apache/iceberg/issues/6420#issuecomment-1809654712 @jackye1995 it would be great if you could have a look at the google doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Build: Bump software.amazon.awssdk:bom from 2.21.21 to 2.21.22 [iceberg]

2023-11-13 Thread via GitHub
nastra commented on PR #9053: URL: https://github.com/apache/iceberg/pull/9053#issuecomment-1809690344 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] API: implement types timestamp_ns and timestamptz_ns [iceberg]

2023-11-13 Thread via GitHub
nastra commented on PR #9008: URL: https://github.com/apache/iceberg/pull/9008#issuecomment-1809702760 > Do these need to be addressed in this PR? > > ``` > TestSpark3Util > testDescribeSortOrder FAILED > org.junit.ComparisonFailure: Sort order isn't correct. expected:<[hour