ZENOTME commented on code in PR #82:
URL: https://github.com/apache/iceberg-rust/pull/82#discussion_r1390890336
##########
crates/iceberg/src/avro/schema.rs:
##########
@@ -441,14 +453,35 @@ impl AvroSchemaVisitor for AvroSchemaToSchema {
AvroSchema::Date => Type::Primitive(PrimitiveType::Date),
AvroSchema::TimeMicros => Type::Primitive(PrimitiveType::Time),
AvroSchema::TimestampMicros =>
Type::Primitive(PrimitiveType::Timestamp),
- AvroSchema::Uuid => Type::Primitive(PrimitiveType::Uuid),
AvroSchema::Boolean => Type::Primitive(PrimitiveType::Boolean),
AvroSchema::Int => Type::Primitive(PrimitiveType::Int),
AvroSchema::Long => Type::Primitive(PrimitiveType::Long),
AvroSchema::Float => Type::Primitive(PrimitiveType::Float),
AvroSchema::Double => Type::Primitive(PrimitiveType::Double),
AvroSchema::String | AvroSchema::Enum(_) =>
Type::Primitive(PrimitiveType::String),
- AvroSchema::Fixed(fixed) =>
Type::Primitive(PrimitiveType::Fixed(fixed.size as u64)),
+ AvroSchema::Fixed(fixed) => {
+ if let Some(logical_type) = fixed.attributes.get(LOGICAL_TYPE)
{
+ let logical_type = logical_type.as_str().ok_or_else(|| {
+ Error::new(
+ ErrorKind::DataInvalid,
+ "logicalType in attributes of avro schema is not a
string type",
+ )
+ })?;
+ match logical_type {
+ UUID_LOGICAL_TYPE =>
Type::Primitive(PrimitiveType::Uuid),
+ ty => {
Review Comment:
Thanks! We should add more checks here I think. I will do it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
