RussellSpitzer commented on code in PR #8919: URL: https://github.com/apache/iceberg/pull/8919#discussion_r1391628443
########## site/mkdocs.yml: ########## @@ -23,33 +23,37 @@ theme: logo: assets/images/iceberg-logo-icon.png favicon: assets/images/favicon-96x96.png features: + - content.tabs.link + - content.code.copy + - content.code.annotate - navigation.tabs - navigation.path - navigation.top - navigation.tracking - - toc.follow + - offline - search.suggest - search.highlight - - content.tabs.link - - content.code.copy - - content.code.annotate + - toc.follow plugins: - search - macros: include_yaml: - variables.yml - monorepo + - offline: + enabled: !ENV [OFFLINE, false] nav: - Quickstart: - Spark: spark-quickstart.md - Hive: hive-quickstart.md - Docs: - nightly: '!include docs/docs/nightly/mkdocs.yml' -# - latest: '!include docs/docs/latest/mkdocs.yml' -# - 1.3.1: '!include docs/docs/1.3.1/mkdocs.yml' -# - 1.3.0: '!include docs/docs/1.3.0/mkdocs.yml' + - latest: '!include docs/docs/latest/mkdocs.yml' Review Comment: For me I was wondering why "nightly" was first isn't that our "unstable" basically? I agree ideally we have something like 1.4.2 (latest) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org