MarquisC commented on PR #109:
URL: https://github.com/apache/iceberg-python/pull/109#issuecomment-1783740841
Will test and close, unit test wise looks like #83 is the fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
tomtongue commented on code in PR #8931:
URL: https://github.com/apache/iceberg/pull/8931#discussion_r1375256629
##
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/MigrateTableSparkAction.java:
##
@@ -108,6 +109,23 @@ public MigrateTableSparkAction backupTableNam
coded9 commented on issue #7154:
URL: https://github.com/apache/iceberg/issues/7154#issuecomment-1783824507
It seems all usages were replaced. Are we good to close this @nastra ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
tomtongue commented on code in PR #8931:
URL: https://github.com/apache/iceberg/pull/8931#discussion_r1375265726
##
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMigrateTableProcedure.java:
##
@@ -142,6 +142,48 @@ public void testMigrateWithBa
adutra commented on code in PR #8909:
URL: https://github.com/apache/iceberg/pull/8909#discussion_r1375268337
##
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##
@@ -378,27 +420,63 @@ public void renameTable(TableIdentifier from,
TableIdentifier to) {
amogh-jahagirdar merged PR #8925:
URL: https://github.com/apache/iceberg/pull/8925
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1375281991
##
hive-metastore/src/test/java/org/apache/iceberg/hive/HiveMetastoreSetup.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
nk1506 commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1375282054
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
coded9 opened a new pull request, #8937:
URL: https://github.com/apache/iceberg/pull/8937
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
nk1506 commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375284710
##
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##
@@ -435,13 +437,11 @@ public void testConcurrentFastAppends(@TempDir File dir)
throws Excepti
amogh-jahagirdar opened a new pull request, #8938:
URL: https://github.com/apache/iceberg/pull/8938
Cherry pick #8925 onto 1.4.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Fokko merged PR #78:
URL: https://github.com/apache/iceberg-rust/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
Fokko commented on code in PR #78:
URL: https://github.com/apache/iceberg-rust/pull/78#discussion_r1375302993
##
crates/catalog/rest/src/catalog.rs:
##
@@ -0,0 +1,845 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. S
rdblue commented on code in PR #8920:
URL: https://github.com/apache/iceberg/pull/8920#discussion_r1375308092
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -939,7 +967,12 @@ private static Cache
newSessionCache(Map pr
return Caffeine.newBuild
rdblue commented on code in PR #8920:
URL: https://github.com/apache/iceberg/pull/8920#discussion_r1375308246
##
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##
@@ -839,11 +841,37 @@ private FileIO tableFileIO(SessionContext context,
Map config) {
}
rdblue commented on code in PR #7710:
URL: https://github.com/apache/iceberg/pull/7710#discussion_r1375308652
##
open-api/rest-catalog-open-api.yaml:
##
@@ -1824,58 +1824,146 @@ components:
- $ref: '#/components/schemas/SetPropertiesUpdate'
- $ref: '#/component
rdblue commented on PR #7710:
URL: https://github.com/apache/iceberg/pull/7710#issuecomment-1783900918
Sorry for the late review. This looks great. Thanks @Fokko!
I didn't merge this in case it conflicts with the other linked PR. Feel free
to merge in the order that makes the most sen
rdblue merged PR #8938:
URL: https://github.com/apache/iceberg/pull/8938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apac
rdblue commented on PR #8922:
URL: https://github.com/apache/iceberg/pull/8922#issuecomment-1783905941
@jzhuge, what is the rationale for this change? Iceberg has always ignored
Spark's settings here.
--
This is an automated message from the Apache Git Service.
To respond to the message,
rdblue commented on code in PR #8919:
URL: https://github.com/apache/iceberg/pull/8919#discussion_r1375311282
##
.github/labeler.yml:
##
@@ -32,6 +32,7 @@ BUILD:
- "**/*gradle*"
DOCS:
- docs/**/*
+ - site/**/*
Review Comment:
Can we fix this in a separate PR? It isn'
rdblue commented on code in PR #8919:
URL: https://github.com/apache/iceberg/pull/8919#discussion_r1375311435
##
site/README.md:
##
@@ -65,7 +65,7 @@ The non-versioned site pages are all the `/site/docs/.*md`
files and the docs ar
> This build process is currently missing olde
rdblue commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375313899
##
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##
@@ -199,6 +199,11 @@ public Map refs() {
return table().refs();
}
+ @Override
+ public St
rdblue commented on code in PR #8683:
URL: https://github.com/apache/iceberg/pull/8683#discussion_r1375314183
##
format/spec.md:
##
@@ -177,8 +177,10 @@ A **`map`** is a collection of key-value pairs with a key
type and a value type.
| **`decimal(P,S)`** | Fixed-point decimal;
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375314451
##
api/src/main/java/org/apache/iceberg/Scan.java:
##
@@ -77,6 +78,21 @@ public interface Scan> {
*/
ThisT includeColumnStats();
+ /**
+ * Create a new scan
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375314451
##
api/src/main/java/org/apache/iceberg/Scan.java:
##
@@ -77,6 +78,21 @@ public interface Scan> {
*/
ThisT includeColumnStats();
+ /**
+ * Create a new scan
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375314743
##
core/src/main/java/org/apache/iceberg/GenericDataFile.java:
##
@@ -66,23 +68,31 @@ class GenericDataFile extends BaseFile implements
DataFile {
* Copy constructo
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375315072
##
core/src/main/java/org/apache/iceberg/GenericDataFile.java:
##
@@ -66,23 +68,31 @@ class GenericDataFile extends BaseFile implements
DataFile {
* Copy constructo
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375314451
##
api/src/main/java/org/apache/iceberg/Scan.java:
##
@@ -77,6 +78,21 @@ public interface Scan> {
*/
ThisT includeColumnStats();
+ /**
+ * Create a new scan
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375315318
##
api/src/main/java/org/apache/iceberg/Scan.java:
##
@@ -77,6 +78,21 @@ public interface Scan> {
*/
ThisT includeColumnStats();
+ /**
+ * Create a new scan
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375315462
##
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##
@@ -560,6 +561,11 @@ public F copy() {
throw new UnsupportedOperationException("Cannot copy IndexedDa
rdblue commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375315526
##
core/src/main/java/org/apache/iceberg/util/ContentFileUtil.java:
##
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more co
rdblue closed pull request #8704: Spec: `snapshot_id` is optional for V1
URL: https://github.com/apache/iceberg/pull/8704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
rdblue commented on PR #8704:
URL: https://github.com/apache/iceberg/pull/8704#issuecomment-1783910095
I'm going to close this. The reason why it was optional is that the
`snapshot_id` can be inherited in v1 using a table setting to enable breaking
forward compatibility.
--
This is an au
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317106
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317363
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317481
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317591
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375317766
##
core/src/main/java/org/apache/iceberg/UpdateRequirement.java:
##
@@ -20,11 +20,17 @@
import org.apache.iceberg.exceptions.CommitFailedException;
import org.apache
rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375317766
##
core/src/main/java/org/apache/iceberg/UpdateRequirement.java:
##
@@ -20,11 +20,17 @@
import org.apache.iceberg.exceptions.CommitFailedException;
import org.apache
rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375318035
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops,
UpdateTableRequest request
rdblue commented on code in PR #7913:
URL: https://github.com/apache/iceberg/pull/7913#discussion_r1375318196
##
core/src/main/java/org/apache/iceberg/rest/CatalogHandlers.java:
##
@@ -374,4 +386,128 @@ static TableMetadata commit(TableOperations ops,
UpdateTableRequest request
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375318398
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
ismailsimsek commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375318438
##
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace()
mchamberlain-mdsol commented on PR #109:
URL: https://github.com/apache/iceberg-python/pull/109#issuecomment-1783934646
> Will test and close, unit test wise looks like #83 is the fix.
This can be closed, confirmed.
--
This is an automated message from the Apache Git Service.
To res
amogh-jahagirdar commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323
##
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##
@@ -199,6 +199,11 @@ public Map refs() {
return table().refs();
}
+ @Override
+
amogh-jahagirdar commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323
##
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##
@@ -199,6 +199,11 @@ public Map refs() {
return table().refs();
}
+ @Override
+
amogh-jahagirdar commented on code in PR #8800:
URL: https://github.com/apache/iceberg/pull/8800#discussion_r1375331323
##
core/src/main/java/org/apache/iceberg/BaseMetadataTable.java:
##
@@ -199,6 +199,11 @@ public Map refs() {
return table().refs();
}
+ @Override
+
jacobmarble commented on code in PR #8683:
URL: https://github.com/apache/iceberg/pull/8683#discussion_r1375335785
##
format/spec.md:
##
@@ -177,8 +177,10 @@ A **`map`** is a collection of key-value pairs with a key
type and a value type.
| **`decimal(P,S)`** | Fixed-point dec
github-actions[bot] commented on issue #7492:
URL: https://github.com/apache/iceberg/issues/7492#issuecomment-1783948762
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #7465:
URL: https://github.com/apache/iceberg/issues/7465#issuecomment-1783948766
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
github-actions[bot] commented on issue #7393:
URL: https://github.com/apache/iceberg/issues/7393#issuecomment-1783948782
This issue has been automatically marked as stale because it has been open
for 180 days with no activity. It will be closed in next 14 days if no further
activity occurs.
pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375354727
##
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##
@@ -560,6 +561,11 @@ public F copy() {
throw new UnsupportedOperationException("Cannot copy IndexedDat
pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375354727
##
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##
@@ -560,6 +561,11 @@ public F copy() {
throw new UnsupportedOperationException("Cannot copy IndexedDat
nk1506 commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375367087
##
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/SparkSQLExecutionHelper.java:
##
@@ -53,7 +53,7 @@ public static String lastExecutedMetricValue(SparkSe
nk1506 commented on code in PR #8804:
URL: https://github.com/apache/iceberg/pull/8804#discussion_r1375367111
##
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/source/SparkSQLExecutionHelper.java:
##
@@ -53,7 +53,7 @@ public static String lastExecutedMetricValue(SparkSe
dependabot[bot] opened a new pull request, #8939:
URL: https://github.com/apache/iceberg/pull/8939
Bumps [com.azure:azure-sdk-bom](https://github.com/azure/azure-sdk-for-java)
from 1.2.17 to 1.2.18.
Commits
https://github.com/Azure/azure-sdk-for-java/commit/0b0dd7ffc9c7bd55fa96
dependabot[bot] opened a new pull request, #8940:
URL: https://github.com/apache/iceberg/pull/8940
Bumps
[com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom)
from 26.25.0 to 26.26.0.
Release notes
Sourced from https://github.com/googleapis/java-cloud-bom/
dependabot[bot] opened a new pull request, #8941:
URL: https://github.com/apache/iceberg/pull/8941
Bumps `nessie` from 0.72.1 to 0.73.0.
Updates `org.projectnessie.nessie:nessie-client` from 0.72.1 to 0.73.0
Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.72.1 t
dependabot[bot] opened a new pull request, #8942:
URL: https://github.com/apache/iceberg/pull/8942
Bumps me.champeau.jmh:jmh-gradle-plugin from 0.7.1 to 0.7.2.
[
from 4.42.0 to 5.30.0.
Release notes
Sourced from https://github.com/palantir/gradle-b
dependabot[bot] closed pull request #8899: Build: Bump
com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.28.0
URL: https://github.com/apache/iceberg/pull/8899
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ajantha-bhat commented on code in PR #8907:
URL: https://github.com/apache/iceberg/pull/8907#discussion_r1375370586
##
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveViewOperations.java:
##
@@ -0,0 +1,346 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1375372030
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -859,7 +862,7 @@ private void removeNamespaceOwnershipAndVerify(
}
@Test
- p
nk1506 commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1375372100
##
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##
@@ -354,7 +402,7 @@ public void testCreateTableCustomSortOrder() throws
Exception {
coded9 opened a new pull request, #8945:
URL: https://github.com/apache/iceberg/pull/8945
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
coded9 opened a new pull request, #8946:
URL: https://github.com/apache/iceberg/pull/8946
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
68 matches
Mail list logo
