rdblue commented on code in PR #8340:
URL: https://github.com/apache/iceberg/pull/8340#discussion_r1375317363
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -601,15 +601,81 @@ public void testDropNamespace() {
public void testCreateNamespace() {
Namespace testNamespace = Namespace.of("testDb", "ns1", "ns2");
assertThat(catalog.namespaceExists(testNamespace)).isFalse();
- // Test with no metadata
+ assertThat(catalog.namespaceExists(Namespace.of("testDb",
"ns1"))).isFalse();
catalog.createNamespace(testNamespace);
assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb",
"ns1"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("ns1", "ns2"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb",
"ns%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb",
"ns_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb", "ns1",
"ns2"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb", "ns1", "ns2",
"ns3"))).isFalse();
+ }
+
+ @Test
+ public void testCreateNamespaceWithBackslashCharacter() {
+
+ Namespace testNamespace = Namespace.of("test\\Db", "ns\\1", "ns3");
+ assertThat(catalog.namespaceExists(testNamespace)).isFalse();
+ catalog.createNamespace(testNamespace);
+ assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("test\\Db",
"ns\\1"))).isTrue();
+ //
+ assertThat(catalog.namespaceExists(Namespace.of("test\\%Db",
"ns\\.1"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test%Db",
"ns\\.1"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test%Db"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test\\%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test_Db",
"ns\\.1"))).isFalse();
+ }
+
+ @Test
+ public void testCreateNamespaceWithPercentCharacter() {
+
+ Namespace testNamespace = Namespace.of("testDb%", "ns%1");
+ assertThat(catalog.namespaceExists(testNamespace)).isFalse();
+ catalog.createNamespace(testNamespace);
+ assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb%"))).isTrue();
+ //
+ assertThat(catalog.namespaceExists(Namespace.of("testDb\\%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("tes%Db%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("testDb%",
"ns%"))).isFalse();
+ }
+
+ @Test
+ public void testCreateNamespaceWithUnderscoreCharacter() {
+ Namespace testNamespace = Namespace.of("test_Db", "ns_1", "ns_");
+ catalog.createNamespace(testNamespace);
+ assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("test_Db",
"ns_1"))).isTrue();
+ //
+ assertThat(catalog.namespaceExists(Namespace.of("test_Db"))).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("test_D_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test_D%"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test_Db",
"ns_"))).isFalse();
+ assertThat(catalog.namespaceExists(Namespace.of("test_Db",
"ns_%"))).isFalse();
+ }
+
+ @Test
+ public void testCreateNamespaceWithDotCharacter() {
+ Namespace testNamespace = Namespace.of("test.Db", "ns1", "ns2");
+ catalog.createNamespace(testNamespace);
+ assertThat(catalog.namespaceExists(testNamespace)).isTrue();
+ assertThat(catalog.namespaceExists(Namespace.of("test.Db",
"ns1"))).isTrue();
+ // TODO FIX handle Dot (its namespace SEPERATOR)? in the namespace levels.
currently its
+ // accepted and threaded as a level
Review Comment:
I'm not sure what problem you're referring to, but in general Iceberg avoids
needing to escape the `.` character by mandating that ambiguous names are not
allowed. That is, you can either have `["a", "b"] -> "a.b"` or `["a.b"] ->
"a.b"` but you can't have both objects since they have a conflicting name
(`"a.b"`). This is how many places work, including column indexing, and no one
ever has a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
