pvary commented on code in PR #8803:
URL: https://github.com/apache/iceberg/pull/8803#discussion_r1375354727


##########
core/src/main/java/org/apache/iceberg/V2Metadata.java:
##########
@@ -560,6 +561,11 @@ public F copy() {
       throw new UnsupportedOperationException("Cannot copy IndexedDataFile 
wrapper");
     }
 
+    @Override
+    public F copyWithStats(Set<Integer> columnsToKeepStats) {

Review Comment:
   @rdblue: Is there an easy way to convert column name to column id in case of 
schema evolution? How should we handle cases where the column is renamed, or a 
column is dropped and a new column is created with the same name?
   Would it be enough to use the `Schema.findField` for this, and accept that 
we can only enable the feature for current columns?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to