liurenjie1024 merged PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
liurenjie1024 commented on PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#issuecomment-2008988301
cc @Xuanwo Any other comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1531644153
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1052,6 +1052,89 @@ pub struct DataFile {
pub(crate) sort_order_id: Option,
}
+impl DataFile {
+/// G
a-agmon commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1531518572
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1052,6 +1052,89 @@ pub struct DataFile {
pub(crate) sort_order_id: Option,
}
+impl DataFile {
+/// Get the
liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1531416557
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1052,6 +1052,89 @@ pub struct DataFile {
pub(crate) sort_order_id: Option,
}
+impl DataFile {
+/// G
a-agmon commented on PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#issuecomment-2007989888
Hi @liurenjie1024 , @Xuanwo
I have addressed the issues and updated the PR.
Please let me know what do you think
--
This is an automated message from the Apache Git Service
a-agmon commented on PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#issuecomment-2006678166
> Hi @a-agmon Thanks for this pr. But per our previous discussion, we prefer
to expose getter methods rather fields directly to user, you can see [the
discussion](https://github.com/ap
liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1530069119
##
crates/iceberg/src/spec/manifest.rs:
##
@@ -1049,7 +1049,7 @@ pub struct DataFile {
/// order id to null. Readers must ignore sort order id for positio
Xuanwo commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1530015552
##
crates/iceberg/src/scan.rs:
##
@@ -209,7 +209,7 @@ pub struct FileScanTask {
pub type ArrowRecordBatchStream = BoxStream<'static,
crate::Result>;
impl FileSca
a-agmon commented on PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#issuecomment-2005960689
Just to add a motivation the purpose is to allow this kind of API access:
```rust
let mut stream = table_scan.plan_files().await?;
while let Some(file) = stream.next
a-agmon commented on PR #281:
URL: https://github.com/apache/iceberg-rust/pull/281#issuecomment-2005923666
Closing this re-opening a new PR after fix to CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
a-agmon closed pull request #281: fix: enable public access to ManifestEntry
properties
URL: https://github.com/apache/iceberg-rust/pull/281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
12 matches
Mail list logo
