Xuanwo commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1530015552
##########
crates/iceberg/src/scan.rs:
##########
@@ -209,7 +209,7 @@ pub struct FileScanTask {
pub type ArrowRecordBatchStream = BoxStream<'static,
crate::Result<RecordBatch>>;
impl FileScanTask {
- pub(crate) fn data_file(&self) -> ManifestEntryRef {
+ pub fn data_file(&self) -> ManifestEntryRef {
Review Comment:
This change looks good to me.
##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1049,7 +1049,7 @@ pub struct DataFile {
/// order id to null. Readers must ignore sort order id for position
/// delete files.
#[builder(default, setter(strip_option))]
- pub(crate) sort_order_id: Option<i32>,
+ pub sort_order_id: Option<i32>,
Review Comment:
I remembered that we don't want users to access those fields directly.
cc @liurenjie1024 for ideas.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
