liurenjie1024 commented on code in PR #284:
URL: https://github.com/apache/iceberg-rust/pull/284#discussion_r1531416557


##########
crates/iceberg/src/spec/manifest.rs:
##########
@@ -1052,6 +1052,89 @@ pub struct DataFile {
     pub(crate) sort_order_id: Option<i32>,
 }
 
+impl DataFile {
+    /// Get the content type of the data file (data, equality deletes, or 
position deletes)
+    pub fn content(&self) -> DataContentType {

Review Comment:
   We can have `#[inline]` attribute to give compiler a hint, but this is 
optional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to