liurenjie1024 merged PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ic
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1697497521
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1697497521
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1697495594
##
crates/test_utils/src/cmd.rs:
##
@@ -28,14 +28,27 @@ pub fn run_command(mut cmd: Command, desc: impl ToString) {
}
}
-pub fn get_cmd_output(mut cmd: Comm
liurenjie1024 commented on PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#issuecomment-2258505768
One minor hint: it's better to use merge rather than force push so that
review could pick up from last review.
--
This is an automated message from the Apache Git Service.
To r
liurenjie1024 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1697072080
##
crates/test_utils/src/cmd.rs:
##
@@ -28,14 +28,27 @@ pub fn run_command(mut cmd: Command, desc: impl ToString) {
}
}
-pub fn get_cmd_output(mut cmd:
Xuanwo commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r169242
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curren
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1696120360
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1696120360
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695784467
##
crates/test_utils/src/docker.rs:
##
@@ -40,15 +41,28 @@ impl DockerCompose {
self.project_name.as_str()
}
+// docker/podman do not consistent
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695784200
##
crates/test_utils/src/cmd.rs:
##
@@ -28,6 +28,17 @@ pub fn run_command(mut cmd: Command, desc: impl ToString) {
}
}
+pub fn get_cmd_output_dont_panic(mut
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695747997
##
crates/test_utils/src/cmd.rs:
##
@@ -28,6 +28,17 @@ pub fn run_command(mut cmd: Command, desc: impl ToString) {
}
}
+pub fn get_cmd_output_dont_panic(mut
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695719265
##
crates/catalog/hms/testdata/hms_catalog/Dockerfile:
##
@@ -15,8 +15,6 @@
FROM --platform=$BUILDPLATFORM openjdk:8-jre-slim AS build
-ARG BUILDPLATFORM
Revi
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695718458
##
crates/catalog/glue/tests/glue_catalog_test.rs:
##
@@ -83,15 +81,15 @@ async fn get_catalog() -> GlueCatalog {
(AWS_REGION_NAME.to_string(), "us-east-1"
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695717804
##
crates/catalog/glue/tests/glue_catalog_test.rs:
##
@@ -83,15 +81,15 @@ async fn get_catalog() -> GlueCatalog {
(AWS_REGION_NAME.to_string(), "us-east-1"
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695714416
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695710521
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695706639
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695706639
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which containerizati
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695526821
##
crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml:
##
@@ -15,6 +15,9 @@
# specific language governing permissions and limitations
# under the Licen
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695652798
##
CONTRIBUTING.md:
##
@@ -110,14 +110,16 @@ $ cargo version
cargo 1.69.0 (6e9a83356 2023-04-12)
```
- Install docker
+ Install Docker or Podman
-Curr
Xuanwo commented on PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#issuecomment-2256406009
> Is there a cleaner way of having "CONTRIBUTING.MD" appear in the website
and as a toplevel file in the github? It's a little tricky getting both the
"github.com" version and the "rust
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695528164
##
crates/catalog/hms/testdata/hms_catalog/Dockerfile:
##
@@ -15,8 +15,6 @@
FROM --platform=$BUILDPLATFORM openjdk:8-jre-slim AS build
-ARG BUILDPLATFORM
Revi
alexyin1 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695526821
##
crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml:
##
@@ -15,6 +15,9 @@
# specific language governing permissions and limitations
# under the Licen
liurenjie1024 commented on PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#issuecomment-2256148753
Hi, @alexyin1
> What is the purpose of ARG BUILDPLATFORM and when/where should that be
used? It was only present in one of the Dockerfiles, so I removed it.
It's us
liurenjie1024 commented on code in PR #489:
URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695336217
##
website/src/reference/podman.md:
##
@@ -0,0 +1,87 @@
+
+
+# Using Podman instead of Docker
+
+The majority of iceberg-rust is agnostic as to which container
28 matches
Mail list logo
