alexyin1 commented on code in PR #489: URL: https://github.com/apache/iceberg-rust/pull/489#discussion_r1695526821
########## crates/catalog/rest/testdata/rest_catalog/docker-compose.yaml: ########## @@ -15,6 +15,9 @@ # specific language governing permissions and limitations # under the License. +networks: Review Comment: [Docker docs](https://docs.docker.com/network/links ) warn that "links" keyword is legacy and should be replaced with "networks" when possible. My particular issue seemed to be that using "links" is not allowed by "SELinux" https://github.com/wazuh/wazuh-docker/issues/709#issuecomment-1335406948 https://github.com/StackStorm/st2-docker/issues/213 Are there use cases that "links" supports better that "networks"? If so, it may be better to keep the "links" setup around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
