Fokko commented on PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#issuecomment-2596093935
Thanks @sungwy and I hope you had some great time off :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
Fokko merged PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceber
sungwy commented on PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#issuecomment-2595750279
> Sorry for the long wait, I think this one got buried in my mailbox. I left
one minor nit, this looks great @sungwy 🙌
no problem @Fokko - I'm just coming back from holidays m
sungwy commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1918589143
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -760,50 +760,104 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catalog)
Fokko commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1917829595
##
pyiceberg/transforms.py:
##
@@ -193,6 +195,24 @@ def supports_pyarrow_transform(self) -> bool:
@abstractmethod
def pyarrow_transform(self, source: Ice
kevinjqliu commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1917748644
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -760,50 +760,104 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catal
sungwy commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1897010250
##
tests/test_transforms.py:
##
@@ -1563,3 +1561,43 @@ def test_ymd_pyarrow_transforms(
else:
with pytest.raises(ValueError):
transfor
kevinjqliu commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1896992186
##
tests/integration/test_writes/test_partitioned_writes.py:
##
@@ -719,50 +719,105 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catal
