kevinjqliu commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1917748644
##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -760,50 +760,104 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catalog) -> Non
@pytest.mark.parametrize(
"spec",
[
- # mixed with non-identity is not supported
- (
- PartitionSpec(
- PartitionField(source_id=4, field_id=1001,
transform=BucketTransform(2), name="int_bucket"),
- PartitionField(source_id=1, field_id=1002,
transform=IdentityTransform(), name="bool"),
- )
- ),
Review Comment:
is this case supported now?
##########
tests/integration/test_writes/test_partitioned_writes.py:
##########
@@ -760,50 +760,104 @@ def test_invalid_arguments(spark: SparkSession,
session_catalog: Catalog) -> Non
@pytest.mark.parametrize(
"spec",
[
- # mixed with non-identity is not supported
- (
- PartitionSpec(
- PartitionField(source_id=4, field_id=1001,
transform=BucketTransform(2), name="int_bucket"),
- PartitionField(source_id=1, field_id=1002,
transform=IdentityTransform(), name="bool"),
- )
- ),
- # none of non-identity is supported
- (PartitionSpec(PartitionField(source_id=4, field_id=1001,
transform=BucketTransform(2), name="int_bucket"))),
- (PartitionSpec(PartitionField(source_id=5, field_id=1001,
transform=BucketTransform(2), name="long_bucket"))),
- (PartitionSpec(PartitionField(source_id=10, field_id=1001,
transform=BucketTransform(2), name="date_bucket"))),
- (PartitionSpec(PartitionField(source_id=8, field_id=1001,
transform=BucketTransform(2), name="timestamp_bucket"))),
- (PartitionSpec(PartitionField(source_id=9, field_id=1001,
transform=BucketTransform(2), name="timestamptz_bucket"))),
- (PartitionSpec(PartitionField(source_id=2, field_id=1001,
transform=BucketTransform(2), name="string_bucket"))),
- (PartitionSpec(PartitionField(source_id=12, field_id=1001,
transform=BucketTransform(2), name="fixed_bucket"))),
- (PartitionSpec(PartitionField(source_id=11, field_id=1001,
transform=BucketTransform(2), name="binary_bucket"))),
(PartitionSpec(PartitionField(source_id=4, field_id=1001,
transform=TruncateTransform(2), name="int_trunc"))),
(PartitionSpec(PartitionField(source_id=5, field_id=1001,
transform=TruncateTransform(2), name="long_trunc"))),
(PartitionSpec(PartitionField(source_id=2, field_id=1001,
transform=TruncateTransform(2), name="string_trunc"))),
- (PartitionSpec(PartitionField(source_id=11, field_id=1001,
transform=TruncateTransform(2), name="binary_trunc"))),
Review Comment:
should we include `binary_trunc` too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
