sungwy commented on code in PR #1345:
URL: https://github.com/apache/iceberg-python/pull/1345#discussion_r1897010250
##########
tests/test_transforms.py:
##########
@@ -1563,3 +1561,43 @@ def test_ymd_pyarrow_transforms(
else:
with pytest.raises(ValueError):
transform.pyarrow_transform(DateType())(arrow_table_date_timestamps[source_col])
+
+
+@pytest.mark.parametrize(
+ "source_type, input_arr, expected, num_buckets",
+ [
+ (IntegerType(), pa.array([1, 2]), pa.array([6, 2], type=pa.int32()),
10),
+ (
+ IntegerType(),
+ pa.chunked_array([pa.array([1, 2]), pa.array([3, 4])]),
+ pa.chunked_array([pa.array([6, 2], type=pa.int32()), pa.array([5,
0], type=pa.int32())]),
+ 10,
+ ),
+ (IntegerType(), pa.array([1, 2]), pa.array([6, 2], type=pa.int32()),
10),
+ ],
+)
+def test_bucket_pyarrow_transforms(
+ source_type: PrimitiveType,
+ input_arr: Union[pa.Array, pa.ChunkedArray],
+ expected: Union[pa.Array, pa.ChunkedArray],
+ num_buckets: int,
Review Comment:
Hmm I think I feel indifferent here - there’s something nice about having
the input and expected arrays side by side
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
