Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1872653751 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

ZENOTME commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1872615636 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a given pre

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1872463255 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

ZENOTME commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1869860138 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a given pre

Re: [PR] feat: Project transform [iceberg-rust]

ZENOTME commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1869860138 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a given pre

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 merged PR #309: URL: https://github.com/apache/iceberg-rust/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2039348517 > Hi, @marvinlanhenke Thanks for pr, it looks great! I have some small suggestion to restructure the code to make it easier for review. Really greatful for these tests! T

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1553275061 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1553272539 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1553271703 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1553262971 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2039007641 cc @Fokko Do you have other comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1548808318 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,323 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547819858 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547785953 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547681855 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547676828 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547667177 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547649993 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547653811 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547639860 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2031700958 > Hi, @marvinlanhenke Thanks for pr, it looks great! I have some small suggestion to restructure the code to make it easier for review. Really greatful for these tests! T

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1547488931 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +269,300 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029473672 > Hi, @marvinlanhenke I skimmed through the code and it seems that we only need to split tests into separate modules to make it easier to maintain and read. But I agree that we

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029468475 Hi, @marvinlanhenke I skimmed through the code and it seems that we only need to split tests into separate modules to make it easier to maintain and read. But I agree that we can

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029456431 > > @Fokko @liurenjie1024 PTAL > > I ported all the tests - and fixed #311. Now, all tests are passing and align with the Java implementation. I think we only can optimize the

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029440339 > @Fokko @liurenjie1024 PTAL > > I ported all the tests - and fixed #311. Now, all tests are passing and align with the Java implementation. I think we only can optimize th

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2029426833 @Fokko @liurenjie1024 PTAL I ported all the tests - and fixed #311. Now, all tests are passing and align with the Java implementation. I think we only can optimize

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2028045351 @Fokko @liurenjie1024 I'm having trouble understanding/ verifiying the test-case for [timestamps_day_inclusive_epoch](https://github.com/apache/iceberg/blob/d350c9b8c995a2953

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2026487818 Hi, @marvinlanhenke Thanks for your contribution, the overall design looks good to me! Please take your time and enjoy time with family😁 -- This is an automated message from th

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1543956147 ## crates/iceberg/src/transform/mod.rs: ## @@ -37,6 +36,15 @@ pub trait TransformFunction: Send { fn transform(&self, input: ArrayRef) -> Result; ///

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1543730206 ## crates/iceberg/src/spec/transform.rs: ## @@ -398,6 +679,80 @@ mod tests { } } +#[test] +fn test_none_projection() -> Result<()> { +

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2025357488 @liurenjie1024 I think I covered most of your suggestions. PTAL if the overall design and implementation in general is fine? ### Unresolved Issues: - [ ] How to

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542937628 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542923641 ## crates/iceberg/src/spec/values.rs: ## @@ -683,6 +684,47 @@ impl Datum { pub fn data_type(&self) -> &PrimitiveType { &self.r#type } + +

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542923641 ## crates/iceberg/src/spec/values.rs: ## @@ -683,6 +684,47 @@ impl Datum { pub fn data_type(&self) -> &PrimitiveType { &self.r#type } + +

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542916299 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542902827 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542870129 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542878163 ## crates/iceberg/src/transform/mod.rs: ## @@ -16,6 +16,7 @@ // under the License. //! Transform function used to compute partition values. + Review Comme

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542877714 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542870129 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a gi

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542837809 ## crates/iceberg/src/transform/mod.rs: ## @@ -16,6 +16,7 @@ // under the License. //! Transform function used to compute partition values. + Review Comm

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542833995 ## crates/iceberg/src/spec/values.rs: ## @@ -683,6 +684,47 @@ impl Datum { pub fn data_type(&self) -> &PrimitiveType { &self.r#type } + +

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2025035027 > Basically, I got rid of the trait and implemented boundary on Datum itself - which makes more sense to me, now that I have a better overall picture with the dates transformatio

Re: [PR] feat: Project transform [iceberg-rust]

liurenjie1024 commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542630137 ## crates/iceberg/src/spec/transform.rs: ## @@ -261,6 +270,174 @@ impl Transform { _ => self == other, } } + +/// Projects a giv

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2024950370 @Fokko Is it correct to assume, as far as I understood the Java implementation, that we support `dates` projection only for `year, month, and day`? @liurenjie1024 I

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2024663637 > Thanks for picking this up @marvinlanhenke > > The most important part of adding projection is making that they are absolutely correct. If rust would generate something

Re: [PR] feat: Project transform [iceberg-rust]

Fokko commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542486911 ## crates/iceberg/src/spec/transform.rs: ## @@ -398,6 +679,80 @@ mod tests { } } +#[test] +fn test_none_projection() -> Result<()> { +l

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2024617450 > LGTM, with the caveat that I'm not an expert on this part of the spec, but the PR seems well-structured. > > I wouldn't mind seeing more comments in the tests though to

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542468150 ## crates/iceberg/src/spec/transform.rs: ## @@ -398,6 +679,80 @@ mod tests { } } +#[test] +fn test_none_projection() -> Result<()> { +

Re: [PR] feat: Project transform [iceberg-rust]

sdd commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542459274 ## crates/iceberg/src/spec/transform.rs: ## @@ -398,6 +679,80 @@ mod tests { } } +#[test] +fn test_none_projection() -> Result<()> { +let

Re: [PR] feat: Project transform [iceberg-rust]

sdd commented on code in PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#discussion_r1542459274 ## crates/iceberg/src/spec/transform.rs: ## @@ -398,6 +679,80 @@ mod tests { } } +#[test] +fn test_none_projection() -> Result<()> { +let

Re: [PR] feat: Project transform [iceberg-rust]

marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2023840212 @liurenjie1024 @ZENOTME @sdd PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to