marvinlanhenke commented on PR #309: URL: https://github.com/apache/iceberg-rust/pull/309#issuecomment-2024617450
> LGTM, with the caveat that I'm not an expert on this part of the spec, but the PR seems well-structured. > > I wouldn't mind seeing more comments in the tests though to explain the "why" aspect of each test. Thanks for your feedback. If the others approve "the correctness" of the PR - I'll add those comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
