Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

liurenjie1024 commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2713350950 > cc @manuzhang @liurenjie1024 @Fokko @sdd, what do you think about merging this PR and enabling the community to build on it? I'm fine with this initial version. But still

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2704518519 cc @manuzhang @liurenjie1024 @Fokko @sdd, what do you think about merging this PR and enabling the community to build on it? -- This is an automated message from the Apache Git Servic

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2703268633 > Ah, and the bindings are fairly minimal I see? I was going to try to experiment with them + cuDF but it seems more work is necessary. In any case it's neat that we can get a C/potenti

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1982977723 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

waruto210 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1982951213 ## bindings/c/src/specs.rs: ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1982941064 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

waruto210 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1982908977 ## bindings/c/src/specs.rs: ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2677421602 Ah, and the bindings are fairly minimal I see? I was going to try to experiment with them + cuDF but it seems more work is necessary. In any case it's neat that we can get a C/potenti

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1967029673 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1967028458 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2674515227 > It's also possible to use [cxx](https://github.com/dtolnay/cxx) to create a pure C++ binding, but it depends on the direction we want to take for iceberg-cpp. Maybe we can p

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2673451050 Good to know, thanks! I have run into `cxx` in an internal project and IMO even with that it takes some manual wrapping to generate "nice" APIs. As far as I am concerne

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2673388726 For @wgtmac > * Is it a battery-included solution or is flexible enough to let downstreams plugin their own implementations of I/O (cloud object store, hdfs, async I/O, etc.), f

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

lidavidm commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2672986293 I'm also curious if there's any potential for linking issues if say, we use this (with OpenDAL enabled) and also OpenDAL's C++ bindings separately. (For another project, we have recei

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

wgtmac commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2671757585 With regard to the possible integration with iceberg-cpp (or even replace it), I have some initial questions (might be dumb since I'm a newbie to the Rust world): 1. Is it a battery-

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959177072 ## bindings/c/README.md: ## @@ -0,0 +1,22 @@ + + +# Iceberg C FFI + +This project is used to build an FFI for iceberg-rust. Review Comment: Added. ## b

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959174275 ## bindings/c/Cargo.toml: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959173058 ## bindings/c/.gitignore: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959174508 ## bindings/c/README.md: ## @@ -0,0 +1,22 @@ + + +# Iceberg C FFI + +This project is used to build an FFI for iceberg-rust. Review Comment: Makes sense, will do.

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959155416 ## bindings/c/README.md: ## @@ -0,0 +1,22 @@ + + +# Iceberg C FFI + +This project is used to build an FFI for iceberg-rust. Review Comment: Add a build guide?

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959155090 ## bindings/c/Cargo.toml: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOT

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959156862 ## bindings/c/cbindgen.toml: ## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1959152456 ## bindings/c/.gitignore: ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOT

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2664744562 I'd suggest notifying the dev list on this feature and open early discussion with iceberg-cpp folks for collaboration. -- This is an automated message from the Apache Git Service.

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2664596679 > Just curious how would this interface work with [iceberg-cpp](https://github.com/apache/iceberg-cpp?rgh-link-date=2025-02-18T04%3A37%3A15Z)? Will there be collaboration or duplication

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

manuzhang commented on PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#issuecomment-2664590010 @Xuanwo Just curious how would this interface work with [iceberg-cpp](https://github.com/apache/iceberg-cpp)? Will there be collaboration or duplication? -- This is an automated m

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

liurenjie1024 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1957681443 ## bindings/c/Cargo.toml: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r195768 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1957670325 ## bindings/c/src/specs.rs: ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the N

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1957669757 ## bindings/c/Cargo.toml: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

liurenjie1024 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1957485800 ## bindings/c/Cargo.toml: ## @@ -0,0 +1,37 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

liurenjie1024 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1957483479 ## bindings/c/CMakeLists.txt: ## Review Comment: Oh, I forgot what we need to use cmake to build static c library. -- This is an automated message fro

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1954356055 ## bindings/c/CMakeLists.txt: ## Review Comment: `CMakeLists` will generate Makefile and served for us to build `libiceberg`. -- This is an automated message

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1954355077 ## bindings/c/CMakeLists.txt: ## @@ -0,0 +1,77 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NO

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

liurenjie1024 commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1953933561 ## bindings/python/Cargo.lock: ## Review Comment: This seems unrelated? ## bindings/c/CMakeLists.txt: ## Review Comment: I'm not c

Re: [PR] feat: Introduce C FFI for iceberg rust [iceberg-rust]

github-actions[bot] commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1953813017 ## bindings/c/.gitignore: ## @@ -0,0 +1 @@ +build/ Review Comment: ```suggestion # Licensed to the Apache Software Foundation (ASF) under one #