Xuanwo commented on code in PR #966: URL: https://github.com/apache/iceberg-rust/pull/966#discussion_r1982941064
########## bindings/c/CMakeLists.txt: ########## @@ -0,0 +1,61 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +cmake_minimum_required(VERSION 3.24) +cmake_policy(SET CMP0135 NEW) + +project(iceberg-c) + +if (NOT CMAKE_BUILD_TYPE) + set(CMAKE_BUILD_TYPE "Debug") +endif() + +# force the compiler to support these standards +set(CMAKE_C_STANDARD 11) +set(CMAKE_C_STANDARD_REQUIRED ON) +set(CMAKE_CXX_STANDARD 14) +set(CMAKE_CXX_STANDARD_REQUIRED ON) + +set(CARGO_DIST_DIR "${PROJECT_SOURCE_DIR}/target/debug") Review Comment: Thanks for this. Do you think this is blocking the PR, or can we fix it in future PRs? ########## bindings/c/src/specs.rs: ########## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Iceberg Spec FFI + +use std::ffi::CString; +use std::mem::ManuallyDrop; +use std::os::raw::c_char; + +use iceberg as core; + +#[repr(C)] +#[derive(Debug, Copy, Clone)] +pub enum PrimitiveLiteralTag { + Boolean, + Int, + Long, + Float, + Double, + String, + Binary, + Int128, + UInt128, + AboveMax, + BelowMin, +} + +#[repr(C)] +pub union PrimitiveLiteralUnion { + boolean: bool, + int: i32, Review Comment: Any ideas for the naming? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
