Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-13 Thread via GitHub
liurenjie1024 merged PR #765: URL: https://github.com/apache/iceberg-rust/pull/765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ic

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-11 Thread via GitHub
liurenjie1024 commented on PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#issuecomment-258031 Let's wait for a moment to see if others need to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-11 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1912193550 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-11 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1912193550 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-11 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1912192560 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-11 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1912192306 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-06 Thread via GitHub
liurenjie1024 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903911917 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,777 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903607534 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903607534 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903608079 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903610687 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903609625 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903608079 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-05 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903607534 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2025-01-01 Thread via GitHub
liurenjie1024 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1900504741 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885104849 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103610 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885103027 ## crates/iceberg/src/puffin/metadata.rs: ## @@ -0,0 +1,809 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agree

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885019802 ## crates/iceberg/src/puffin/compression.rs: ## @@ -15,9 +15,12 @@ // specific language governing permissions and limitations // under the License. +use serde::{D

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-14 Thread via GitHub
Xuanwo commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1885019094 ## crates/puffin/src/lib.rs: ## @@ -23,3 +23,8 @@ mod compression; pub use compression::CompressionCodec; + +mod metadata; Review Comment: That's great! --

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-13 Thread via GitHub
c-thiel commented on PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#issuecomment-2541965685 @fqaiser94, just added the higher level statistic files in https://github.com/apache/iceberg-rust/pull/799 FYI. I would guess you would end up building those soon too. -- This is an

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-07 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1874212744 ## crates/puffin/src/lib.rs: ## @@ -23,3 +23,8 @@ mod compression; pub use compression::CompressionCodec; + +mod metadata; Review Comment: Note that I have

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-07 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1874212744 ## crates/puffin/src/lib.rs: ## @@ -23,3 +23,8 @@ mod compression; pub use compression::CompressionCodec; + +mod metadata; Review Comment: Note that I have

Re: [PR] feat(puffin): Parse Puffin FileMetadata [iceberg-rust]

2024-12-06 Thread via GitHub
fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1874212744 ## crates/puffin/src/lib.rs: ## @@ -23,3 +23,8 @@ mod compression; pub use compression::CompressionCodec; + +mod metadata; Review Comment: Note that I have