fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1874212744
########## crates/puffin/src/lib.rs: ########## @@ -23,3 +23,8 @@ mod compression; pub use compression::CompressionCodec; + +mod metadata; Review Comment: Note that I have deliberately chosen to not expose anything at the moment. I want to create a separate, intentional PR to add `pub` modifiers after the reader and writer implementations have been added. This way, we can develop inside this crate without having to worry about breaking changes until we're ready. If it helps though, I intend to expose the following outside of the crate eventually: ```rust pub use metadata::{BlobMetadata, FileMetadata, CREATED_BY_PROPERTY}; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org