fqaiser94 commented on code in PR #765: URL: https://github.com/apache/iceberg-rust/pull/765#discussion_r1903607534
########## crates/iceberg/src/puffin/metadata.rs: ########## @@ -0,0 +1,797 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::{HashMap, HashSet}; + +use bytes::Bytes; +use once_cell::sync::Lazy; +use serde::{Deserialize, Serialize}; + +use crate::io::{FileRead, InputFile}; +use crate::puffin::compression::CompressionCodec; +use crate::{Error, ErrorKind, Result}; + +/// Human-readable identification of the application writing the file, along with its version. +/// Example: "Trino version 381" +pub(crate) const CREATED_BY_PROPERTY: &str = "created-by"; + +/// Metadata about a blob. +/// For more information, see: https://iceberg.apache.org/puffin-spec/#blobmetadata +#[derive(Debug, PartialEq, Eq, Serialize, Deserialize, Clone)] +#[serde(rename_all = "kebab-case")] +pub(crate) struct BlobMetadata { + /// See blob types: https://iceberg.apache.org/puffin-spec/#blob-types + pub(crate) r#type: String, Review Comment: I don't think so. If you look at the reference Java implementation, the [`type` field is modelled as an arbitrary `String`](https://github.com/apache/iceberg/blob/fcd5dd932a21066d6127c94c50f3de43e8c2d80c/core/src/main/java/org/apache/iceberg/puffin/BlobMetadata.java#L39) there as well. Also, the [unit tests have arbitrary string values like `"some-blob"`](https://github.com/apache/iceberg/blob/fcd5dd932a21066d6127c94c50f3de43e8c2d80c/core/src/test/java/org/apache/iceberg/puffin/TestPuffinWriter.java#L95). Same goes for the reference files e.g. [`core/src/test/resources/org/apache/iceberg/puffin/v1/sample-metric-data-compressed-zstd.bin`](https://github.com/apache/iceberg/blob/main/core/src/test/resources/org/apache/iceberg/puffin/v1/sample-metric-data-compressed-zstd.bin) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
