Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-22 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810042673 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810042422 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810045803 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java: ## @@ -88,12 +88,12 @@ import software.amazon.awssdk.services.s3.model.HeadObjectRequest; import so

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810042880 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810044895 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java: ## @@ -88,12 +88,12 @@ import software.amazon.awssdk.services.s3.model.HeadObjectRequest; import so

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810038705 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioUtil.java: ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more c

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on PR #11349: URL: https://github.com/apache/iceberg/pull/11349#issuecomment-2427914053 Github Actions CI passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809149320 ## build.gradle: ## @@ -495,20 +495,18 @@ project(':iceberg-aws') { testImplementation("software.amazon.awssdk:s3control") testImplementation("software.amaz

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809125303 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809112969 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java: ## @@ -30,21 +29,21 @@ import org.apache.iceberg.io.SeekableInputStream; import org.junit.jupi

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809106800 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809100569 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1809098219 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioHelper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808237078 ## build.gradle: ## @@ -495,20 +495,18 @@ project(':iceberg-aws') { testImplementation("software.amazon.awssdk:s3control") testImplementation("software.amaz

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808235153 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestS3InputStream.java: ## @@ -30,21 +29,21 @@ import org.apache.iceberg.io.SeekableInputStream; import org.junit.jupi

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808233795 ## aws/src/test/java/org/apache/iceberg/aws/s3/TestMinioHelper.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808232736 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808231994 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-21 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1808230962 ## aws/src/test/java/org/apache/iceberg/aws/s3/MinioHelper.java: ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more con

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-18 Thread via GitHub
sullis commented on PR #11349: URL: https://github.com/apache/iceberg/pull/11349#issuecomment-2423404051 GitHub Actions CI passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-18 Thread via GitHub
sullis commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1807054261 ## aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java: ## @@ -71,11 +73,10 @@ public class TestS3RestSigner { private static final Region RE

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-18 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1806186638 ## aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java: ## @@ -71,11 +73,10 @@ public class TestS3RestSigner { private static final Region RE

Re: [PR] core: use testcontainers-minio [iceberg]

2024-10-18 Thread via GitHub
nastra commented on code in PR #11349: URL: https://github.com/apache/iceberg/pull/11349#discussion_r1806186638 ## aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java: ## @@ -71,11 +73,10 @@ public class TestS3RestSigner { private static final Region RE