nastra commented on code in PR #11349:
URL: https://github.com/apache/iceberg/pull/11349#discussion_r1810044895
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIO.java:
##########
@@ -88,12 +88,12 @@
import software.amazon.awssdk.services.s3.model.HeadObjectRequest;
import software.amazon.awssdk.services.s3.model.S3Error;
-@ExtendWith(S3MockExtension.class)
+@Testcontainers
public class TestS3FileIO {
- @RegisterExtension
- public static final S3MockExtension S3_MOCK =
S3MockExtension.builder().silent().build();
+ @Container private static final MinIOContainer MINIO =
MinioUtil.createContainer();
- public SerializableSupplier<S3Client> s3 = S3_MOCK::createS3ClientV2;
+ public final SerializableSupplier<S3Client> s3 =
+ (SerializableSupplier<S3Client>) () -> MinioUtil.createS3Client(MINIO);
Review Comment:
the cast is redundant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
