sullis commented on code in PR #11349:
URL: https://github.com/apache/iceberg/pull/11349#discussion_r1807054261
##########
aws/src/test/java/org/apache/iceberg/aws/s3/signer/TestS3RestSigner.java:
##########
@@ -71,11 +73,10 @@ public class TestS3RestSigner {
private static final Region REGION = Region.US_WEST_2;
private static final String BUCKET = "iceberg-s3-signer-test";
+ private static final MinIOContainer MINIO_CONTAINER =
MinioHelper.createContainer();
static final AwsCredentialsProvider CREDENTIALS_PROVIDER =
StaticCredentialsProvider.create(
- AwsBasicCredentials.create("accessKeyId", "secretAccessKey"));
- private static final MinioContainer MINIO_CONTAINER =
- new MinioContainer(CREDENTIALS_PROVIDER.resolveCredentials());
+ AwsBasicCredentials.create(MINIO_CONTAINER.getUserName(),
MINIO_CONTAINER.getPassword()));
Review Comment:
1) I have restored virtual-host-style addressing (restored MINIO_DOMAIN)
2) MINIO_ACCESS_KEY is deprecated in favor of MINIO_ROOT_USER
3) MINIO_SECRET_KEY is deprecated in favor of MINIO_ROOT_PASSWORD
source:
https://min.io/docs/minio/linux/reference/minio-server/settings/deprecated.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
