Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-13 Thread via GitHub
Fokko commented on PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2587320031 Thanks for the quick follow up @smaheshwar-pltr, and thanks for the review @kevinjqliu 🙌 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-13 Thread via GitHub
Fokko merged PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceber

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on code in PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912296503 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -297,8 +297,8 @@ def test_object_storage_location_provider_excludes_partition_path(

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on code in PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912296178 ## pyiceberg/table/__init__.py: ## @@ -190,7 +190,7 @@ class TableProperties: WRITE_PY_LOCATION_PROVIDER_IMPL = "write.py-location-provider.impl"

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on code in PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912296178 ## pyiceberg/table/__init__.py: ## @@ -190,7 +190,7 @@ class TableProperties: WRITE_PY_LOCATION_PROVIDER_IMPL = "write.py-location-provider.impl"

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2585391350 > In terms of the default value for WRITE_OBJECT_STORE_PARTITIONED_PATHS, here are the four different scenarios. ([source](https://github.com/apache/iceberg-python/blob/cad

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
kevinjqliu commented on code in PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912162975 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -297,8 +297,8 @@ def test_object_storage_location_provider_excludes_partition_path( t

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2585318235 The main downside of this PR is that file paths and their directory structures are more obscured by default with a bunch of hash directories inserted in the middle. But IMH

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#issuecomment-2585317026 Want to strongly highlight for folks reviewing (@kevinjqliu + @Fokko?) that I've **not** changed `WRITE_OBJECT_STORE_PARTITIONED_PATHS_DEFAULT` to `False` even though it's

Re: [PR] Use `ObjectStoreLocationProvider` by default [iceberg-python]

2025-01-11 Thread via GitHub
smaheshwar-pltr commented on code in PR #1509: URL: https://github.com/apache/iceberg-python/pull/1509#discussion_r1912071614 ## tests/integration/test_writes/test_partitioned_writes.py: ## @@ -297,8 +297,8 @@ def test_object_storage_location_provider_excludes_partition_path(